Bug 1035314 - vdsm-hook-nestedvt uses kvm_intel-only syntax
Summary: vdsm-hook-nestedvt uses kvm_intel-only syntax
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: oVirt
Classification: Retired
Component: vdsm
Version: 3.3
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
: 3.4.0
Assignee: Michal Skrivanek
QA Contact: Lukas Svaty
URL:
Whiteboard: virt
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-11-27 14:24 UTC by Sander
Modified: 2014-03-31 12:23 UTC (History)
9 users (show)

Fixed In Version: ovirt-3.4.0-beta1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-03-31 12:23:43 UTC
oVirt Team: ---

Attachments (Terms of Use)
Patch that uses the right nestedvt flag on AMD-based systems. (531 bytes, patch)
2013-11-27 14:24 UTC, Sander 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 23164 0 None None None Never

Description Sander 2013-11-27 14:24:15 UTC 
Created attachment 829764 [details]
Patch that uses the right nestedvt flag on AMD-based systems.

Description of problem:

vdsm-hook-nestedvt uses kvm_intel-only syntax

Version-Release number of selected component (if applicable):

All versions that I checked.

How reproducible:

Use an amd-based node with oVirt and try to use nested virtualization.

Steps to Reproduce:
1. Install vdsm-hook-nestedvt on AMD-based oVirt node.
2. Start VM
3. Look in the vdsm log for the generated VM XML

Actual results:
No svm flag is added to cpu definition.

Expected results:
An svm flag is added to cpu definition.

Additional info:

kvm_amd uses "1" for it's nested flag, kvm_intel uses "Y"

Attached is a simple patch that fixes the behaviour on my systems.
Comment 1 Itamar Heim 2014-01-12 08:41:45 UTC 
setting target release to current version for consideration and review. please do not push non-RFE bugs to an undefined target release to make sure bugs are reviewed for relevancy, fix, closure, etc.
Comment 3 Sandro Bonazzola 2014-01-27 13:47:13 UTC 
This should be fixed in 3.4.0 beta1
Comment 4 Lukas Svaty 2014-02-27 13:26:07 UTC 
verified in beta3

vm cpu definition:
<cpu match="exact">
  <model>Opteron_G2</model>
  <topology cores="1" sockets="160" threads="1"/>
<feature name="svm" policy="require"/></cpu>
Comment 5 Sandro Bonazzola 2014-03-31 12:23:43 UTC 
this is an automated message: moving to Closed CURRENT RELEASE since oVirt 3.4.0 has been released
Note You need to log in before you can comment on or make changes to this bug.