Bug 1035420 - OOB content labels get cut off
Summary: OOB content labels get cut off
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Operations Network
Classification: JBoss
Component: UI
Version: JON 3.2
Hardware: All
OS: All
unspecified
medium
Target Milestone: ER04
: JON 3.3.0
Assignee: Jay Shaughnessy
QA Contact: Armine Hovsepyan
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-11-27 17:28 UTC by Viet Nguyen
Modified: 2015-09-03 00:02 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-12-11 14:03:41 UTC
Type: Bug

Attachments (Terms of Use)
IE9 (139.61 KB, image/png)
2013-11-27 17:28 UTC, Viet Nguyen 		no flags Details
Firefox (525.94 KB, image/png)
2013-11-27 17:29 UTC, Viet Nguyen 		no flags Details
IE9 (629.36 KB, image/png)
2013-11-27 17:50 UTC, Viet Nguyen 		no flags Details
Metric names cropped (195.33 KB, application/octet-stream)
2014-09-10 15:03 UTC, Jan Bednarik 		no flags Details
measurements_names_ie9_ff (210.56 KB, image/png)
2014-10-06 14:51 UTC, Armine Hovsepyan 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Description Viet Nguyen 2013-11-27 17:28:42 UTC 
Created attachment 829848 [details]
IE9

Description of problem:

OOB value cells don't have enough width to fix the text if there are OOB metrics.  See attachments.


Version-Release number of selected component (if applicable):
ER7, Firefox, IE9

How reproducible:


Steps to Reproduce:
1. Import an agent.  Generate OOB conditions
2. RHQ Agent -> Agent Measurement Subsystem
Comment 1 Viet Nguyen 2013-11-27 17:29:13 UTC 
Created attachment 829849 [details]
Firefox
Comment 2 Viet Nguyen 2013-11-27 17:50:28 UTC 
Created attachment 829850 [details]
IE9
Comment 4 Jay Shaughnessy 2014-08-25 17:30:04 UTC 
I couldn't reproduce this, it looked the same on IE and Chrome and FF.  Unfortunately that means it looked crappy everywhere, the metric name is all cropped.  Let me see if I can just fix this to look better in general...
Comment 5 Jay Shaughnessy 2014-08-25 19:23:56 UTC 
Master commit 99774dccc1a8ed496a0f10e5d9fb1e1bb5ef0adc
Author: Jay Shaughnessy <jshaughn>
Date:   Mon Aug 25 15:06:32 2014 -0400

    This portlet could use some more TLC, but at least now the metric name should
    appear in full.  Added some better formatting to the list entries.  Note that
    LinkItem.setClipValue(false) needed to be set explicitly despite being the
    documented default.



release/jon3.3.x commit 265d68ad55c8beab9f415a2bdbf1f4724ac9cd9c
Author: Jay Shaughnessy <jshaughn>
Date:   Mon Aug 25 15:20:55 2014 -0400

    Cherry-Pick master: 99774dccc1a8ed496a0f10e5d9fb1e1bb5ef0adc
Comment 6 Simeon Pinder 2014-09-03 20:31:28 UTC 
Moving to ON_QA as available for test with the following brew build:
https://brewweb.devel.redhat.com//buildinfo?buildID=381194
Comment 7 Jan Bednarik 2014-09-10 15:02:38 UTC 
Moving to ASSIGNED.

As for the "Resource: OOB Metrics" portlet, the value cells are now wide enough to hold the text and the full metric name is visible as well.

The issue is now visible in "Resource: Measurements" portlet though. It can be seen in the attached screenshot (see below) that the metric name is cropped because the column with values is positioned too much in the left. This was not the case of JON 3.2.0.

Tested on Firefox 26.0 and Chrome 32.0.1700.107.

Version:3.3.0.ER02
Build Number:4fbb183:7da54e2
Comment 8 Jan Bednarik 2014-09-10 15:03:26 UTC 
Created attachment 936204 [details]
Metric names cropped
Comment 11 Jay Shaughnessy 2014-09-15 19:53:32 UTC 
master commit bc6764986a1665350e9fdbf2be1c6b5c8801e4a3
Author: Jay Shaughnessy <jshaughn>
Date:   Mon Sep 15 15:48:49 2014 -0400

    Analogous fixes for the measurement portlets



release/jon3.3.x commit 6300d6becebce97e47ace3189d3a5810961628ce
Author: Jay Shaughnessy <jshaughn>
Date:   Mon Sep 15 15:48:49 2014 -0400

    (cherry picked from commit bc6764986a1665350e9fdbf2be1c6b5c8801e4a3)
    Signed-off-by: Jay Shaughnessy <jshaughn>
Comment 13 Simeon Pinder 2014-10-01 21:33:00 UTC 
Moving to ON_QA as available for test with build:
https://brewweb.devel.redhat.com/buildinfo?buildID=388959
Comment 14 Armine Hovsepyan 2014-10-06 14:51:02 UTC 
Created attachment 944281 [details]
measurements_names_ie9_ff
Comment 15 Armine Hovsepyan 2014-10-06 14:51:39 UTC 
verified in JON 3.3 ER04
Note You need to log in before you can comment on or make changes to this bug.