Hide Forgot
Spec URL: http://rishi.fedorapeople.org/gfbgraph.spec SRPM URL: http://rishi.fedorapeople.org/gfbgraph-0.2.1-1.fc20.src.rpm Description: <description here> GLib/GObject wrapper for the Facebook Graph API that integrates with GNOME Online Accounts. Fedora Account System Username: rishi
1. RPM can handle pkg-config well now. Please remove Requires: pkgconfig in -devel. 2. %define api 0.2 --> %global api 0.2 3. %dir %{_includedir}/%{name}-%{api} %{_includedir}/%{name}-%{api}/%{name} Oh? Why not just %{_includedir}/%{name}-%{api} 4. Since you've defined an api macro, according to GNOME software release habit, is it O to define version tag like this? Version: %{api}.1
(In reply to Christopher Meng from comment #1) Spec: http://rishi.fedorapeople.org/gfbgraph.spec SRPM: http://rishi.fedorapeople.org/gfbgraph-0.2.1-2.fc20.src.rpm > 1. RPM can handle pkg-config well now. > > Please remove Requires: pkgconfig in -devel. Done. > 2. %define api 0.2 --> %global api 0.2 Done. > 3. %dir %{_includedir}/%{name}-%{api} > %{_includedir}/%{name}-%{api}/%{name} > > Oh? > > Why not just > > %{_includedir}/%{name}-%{api} Mostly a matter of style or habit to make it obvious (to myself?) that it is a directory and not a file. > 4. Since you've defined an api macro, according to GNOME software release > habit, is it O to define version tag like this? > > Version: %{api}.1 Done.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2.1 or later)", "GPL (v2 or later)", "Unknown or generated". 4 files have unknown license. Detailed output of licensecheck: GPL (v2 or later) ----------------- /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/gfbgraph-0.2.1/ltmain.sh ---> This can be ignored safely. LGPL (v2.1 or later) -------------------- /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/gfbgraph-0.2.1/gfbgraph/gfbgraph-album.c /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/gfbgraph-0.2.1/gfbgraph/gfbgraph-album.h /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/gfbgraph-0.2.1/gfbgraph/gfbgraph-authorizer.c /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/gfbgraph-0.2.1/gfbgraph/gfbgraph-authorizer.h /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/gfbgraph-0.2.1/gfbgraph/gfbgraph-common.c /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/gfbgraph-0.2.1/gfbgraph/gfbgraph-common.h /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/gfbgraph-0.2.1/gfbgraph/gfbgraph-connectable.c /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/gfbgraph-0.2.1/gfbgraph/gfbgraph-connectable.h /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/gfbgraph-0.2.1/gfbgraph/gfbgraph-goa-authorizer.c /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/gfbgraph-0.2.1/gfbgraph/gfbgraph-goa-authorizer.h /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/gfbgraph-0.2.1/gfbgraph/gfbgraph-node.c /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/gfbgraph-0.2.1/gfbgraph/gfbgraph-node.h /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/gfbgraph-0.2.1/gfbgraph/gfbgraph-photo.c /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/gfbgraph-0.2.1/gfbgraph/gfbgraph-photo.h /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/gfbgraph-0.2.1/gfbgraph/gfbgraph-simple-authorizer.c /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/gfbgraph-0.2.1/gfbgraph/gfbgraph-simple-authorizer.h /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/gfbgraph-0.2.1/gfbgraph/gfbgraph-user.c /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/gfbgraph-0.2.1/gfbgraph/gfbgraph-user.h /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/gfbgraph-0.2.1/gfbgraph/gfbgraph.h Unknown or generated -------------------- /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/gfbgraph-0.2.1/tests/credentials.h /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/gfbgraph-0.2.1/tests/gtestutils.c /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/gfbgraph-0.2.1/tests/test-async.c /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/gfbgraph-0.2.1/tests/test.c [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/gir-1.0(gobject- introspection-devel, libgee-devel, GConf2-devel, gtk2-devel, libgee06-devel, gtk3-devel, atk-devel, gdk-pixbuf2-devel, libgtop2-devel), /usr/lib/girepository-1.0(gobject-introspection, libxklavier, GConf2, libgnome-keyring, gdk-pixbuf2, libgtop2, libgee06, fcitx-libs, gtk2, gtk3, atk, vte3, gcr, libgee, libzapojit, gucharmap, libmash) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: gfbgraph-0.2.1-2.fc21.i686.rpm gfbgraph-devel-0.2.1-2.fc21.i686.rpm gfbgraph-0.2.1-2.fc21.src.rpm gfbgraph.i686: W: spelling-error Summary(en_US) GLib -> G Lib, Glib, Gib gfbgraph.i686: W: spelling-error %description -l en_US GLib -> G Lib, Glib, Gib gfbgraph-devel.i686: W: no-documentation gfbgraph.src: W: spelling-error Summary(en_US) GLib -> G Lib, Glib, Gib gfbgraph.src: W: spelling-error %description -l en_US GLib -> G Lib, Glib, Gib 3 packages and 0 specfiles checked; 0 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint gfbgraph gfbgraph-devel gfbgraph.i686: W: spelling-error Summary(en_US) GLib -> G Lib, Glib, Gib gfbgraph.i686: W: spelling-error %description -l en_US GLib -> G Lib, Glib, Gib gfbgraph.i686: W: unused-direct-shlib-dependency /usr/lib/libgfbgraph-0.2.so.0.0.0 /lib/libpthread.so.0 gfbgraph-devel.i686: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 4 warnings. # echo 'rpmlint-done:' Requires -------- gfbgraph (rpmlib, GLIBC filtered): /sbin/ldconfig gobject-introspection libc.so.6 libgio-2.0.so.0 libglib-2.0.so.0 libgoa-1.0.so.0 libgobject-2.0.so.0 libjson-glib-1.0.so.0 libpthread.so.0 librest-0.7.so.0 libsoup-2.4.so.1 rtld(GNU_HASH) gfbgraph-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config gfbgraph(x86-32) gobject-introspection-devel libgfbgraph-0.2.so.0 pkgconfig(gio-2.0) pkgconfig(glib-2.0) pkgconfig(goa-1.0) pkgconfig(json-glib-1.0) pkgconfig(libsoup-2.4) pkgconfig(rest-0.7) Provides -------- gfbgraph: gfbgraph gfbgraph(x86-32) libgfbgraph-0.2.so.0 gfbgraph-devel: gfbgraph-devel gfbgraph-devel(x86-32) pkgconfig(libgfbgraph-0.2) Source checksums ---------------- http://download.gnome.org/sources/gfbgraph/0.2/gfbgraph-0.2.1.tar.xz : CHECKSUM(SHA256) this package : 1bdf448908dda62928de2c9563bee098acda95bd0cb4f14b4af8576e9708f5c9 CHECKSUM(SHA256) upstream package : 1bdf448908dda62928de2c9563bee098acda95bd0cb4f14b4af8576e9708f5c9 Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30 Command line :/usr/bin/fedora-review -rvn gfbgraph-0.2.1-2.fc20.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, SugarActivity, Perl, R, PHP, Ruby Disabled flags: EPEL5, EXARCH, DISTTAG ---------------- PACKAGE APPROVED.
New Package SCM Request ======================= Package Name: gfbgraph Short Description: GLib/GObject wrapper for the Facebook Graph API Owners: rishi Branches: InitialCC:
Git done (by process-git-requests).
Thank you very much for the review!