Bug 1035782 - perl-CPANPLUS: unnecessary download of 03modlist.data.gz
Summary: perl-CPANPLUS: unnecessary download of 03modlist.data.gz
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: perl-CPANPLUS
Version: 7.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: perl-maint-list
QA Contact: Martin Kyral
URL:
Whiteboard:
Depends On:
Blocks: 1035754
TreeView+ depends on / blocked
 
Reported: 2013-11-28 13:21 UTC by Florian Weimer
Modified: 2014-06-18 08:07 UTC (History)
2 users (show)

Fixed In Version: perl-CPANPLUS-0.91.38-3.el7
Doc Type: Bug Fix
Doc Text:
Cause: Running cpanp command. Consequence: CPANPLUS mirrors 03modlist.data.gz which is not used by CPANPLUS anymore. Fix: CPANPLUS::Internals::Source Perl module has been modified not to download dslip database. Result: CPANPLUS does not perform useless downloads anymore.
Clone Of:
Environment:
Last Closed: 2014-06-12 07:56:57 UTC
Target Upstream Version:

Attachments (Terms of Use)
Proposed fix (1.83 KB, patch)
2013-12-09 12:18 UTC, Petr Pisar 		no flags Details | Diff
Upstream fix (1.93 KB, patch)
2013-12-11 08:01 UTC, Petr Pisar 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)


Links
System ID Private Priority Status Summary Last Updated
CPAN 91273 0 None None None Never

Description Florian Weimer 2013-11-28 13:21:02 UTC 
The modlist parser has been disabled with this line in lib/CPANPLUS/Internals/Source.pm:

    return {}; # Quick hack

which was added to the __create_dslip_tree sub.  This is nice because of the evals further down, which appear to enable arbitrary code execution.

However, the 03modlist.data.gz file is still downloaded and stored locally, which seems wasteful.
Comment 2 Petr Pisar 2013-12-09 12:17:47 UTC 
Indeed, the file seems unused now. I will propose a patch to the upstream.
Comment 3 Petr Pisar 2013-12-09 12:18:48 UTC 
Created attachment 834310 [details]
Proposed fix
Comment 4 Petr Pisar 2013-12-11 08:01:30 UTC 
Created attachment 835171 [details]
Upstream fix

The patch has been accepted by upstream as:

commit 68f75c070e1c77a63164a8d127ea775d0ddb62dc
Author: Petr Písař <ppisar>
Date:   Mon Dec 9 19:52:01 2013 +0000

    [RT#91273] Useless downloading 03modlist.data.gz
Note You need to log in before you can comment on or make changes to this bug.