Created attachment 830724 [details]
vdsm.log

Description of problem:
MissingOvfFileFromVM issue it should not make getting list of all VMs on export domain fail.

With some miracle I got empty uuid-named dir on export domain, vdsm python code could not recover from this and I could not get any list of VMs on the export domain. Silly.

-%-
Thread-277::INFO::2013-11-29 15:58:37,654::sd::582::Storage.StorageDomain::(getVMsList) vmList=['74b35bd3-67e7-4206-ba0b-f53ac5ec7254', 'bb443c22-8086-4a64-824
4-e1150399bb05', '38b4eddf-5e4e-4011-b0a6-c73e01eeca4e', '83bc41b5-ba50-435c-9aac-eb1ffdaba1f0', '53f47625-8b98-4b09-bf46-2dd5717f48e1', 'a27a66bf-72f1-42b7-ba
76-cecfe5d91ac9', '2c9c6fb7-2ea9-4489-83bf-25d17cec2fa6', '5d93ea43-c794-4ee1-b788-7239b4faa885', 'cb8b1462-3cb6-4bf0-b7e4-28be5702b6ac', 'db5665ff-d27e-462a-b
7b4-49301bfefbb2', 'd3e97774-3f2a-4f00-936d-909f89c7f700', '26d6e68e-2c02-412e-ba0b-210c920b4517', '7f442680-1579-4eea-a426-1cf3a5e743a8', '8d809727-1f36-4633-
b0da-9ea71cd66182', 'ed3b010f-673e-4bb0-a58e-ff1ae2b2da00', 'a7df4022-42c5-47b6-aba2-189c47f9fef7', 'c8dc7c6a-f410-4d56-9e31-802d67907155', 'ccca02ce-6a76-4f87
-8ca9-67a57793e791']
Thread-277::INFO::2013-11-29 15:58:37,654::sd::599::Storage.StorageDomain::(getVMsInfo) vmList=['74b35bd3-67e7-4206-ba0b-f53ac5ec7254', 'bb443c22-8086-4a64-824
4-e1150399bb05', '38b4eddf-5e4e-4011-b0a6-c73e01eeca4e', '83bc41b5-ba50-435c-9aac-eb1ffdaba1f0', '53f47625-8b98-4b09-bf46-2dd5717f48e1', 'a27a66bf-72f1-42b7-ba
76-cecfe5d91ac9', '2c9c6fb7-2ea9-4489-83bf-25d17cec2fa6', '5d93ea43-c794-4ee1-b788-7239b4faa885', 'cb8b1462-3cb6-4bf0-b7e4-28be5702b6ac', 'db5665ff-d27e-462a-b
7b4-49301bfefbb2', 'd3e97774-3f2a-4f00-936d-909f89c7f700', '26d6e68e-2c02-412e-ba0b-210c920b4517', '7f442680-1579-4eea-a426-1cf3a5e743a8', '8d809727-1f36-4633-
b0da-9ea71cd66182', 'ed3b010f-673e-4bb0-a58e-ff1ae2b2da00', 'a7df4022-42c5-47b6-aba2-189c47f9fef7', 'c8dc7c6a-f410-4d56-9e31-802d67907155', 'ccca02ce-6a76-4f87
-8ca9-67a57793e791']
Thread-277::ERROR::2013-11-29 15:58:37,709::task::850::TaskManager.Task::(_setError) Task=`3c94c3ed-7c3d-4b7a-acb1-157dd5fea727`::Unexpected error
Traceback (most recent call last):
  File "/usr/share/vdsm/storage/task.py", line 857, in _run
  File "/usr/share/vdsm/logUtils.py", line 45, in wrapper
  File "/usr/share/vdsm/storage/hsm.py", line 1411, in getVmsInfo
  File "/usr/share/vdsm/storage/securable.py", line 68, in wrapper
  File "/usr/share/vdsm/storage/sp.py", line 1983, in getVmsInfo
  File "/usr/share/vdsm/storage/sd.py", line 608, in getVMsInfo
MissingOvfFileFromVM: Missing OVF file from VM: ('83bc41b5-ba50-435c-9aac-eb1ffdaba1f0',)
Thread-277::DEBUG::2013-11-29 15:58:37,710::task::869::TaskManager.Task::(_run) Task=`3c94c3ed-7c3d-4b7a-acb1-157dd5fea727`::Task._run: 3c94c3ed-7c3d-4b7a-acb1
-157dd5fea727 ('5849b030-626e-47cb-ad90-3ce782d831b3', 'ca414eb9-98ab-422f-8c4e-c2c513231058', []) {} failed - stopping task
Thread-277::DEBUG::2013-11-29 15:58:37,710::task::1194::TaskManager.Task::(stop) Task=`3c94c3ed-7c3d-4b7a-acb1-157dd5fea727`::stopping in state preparing (forc
e False)
-%-


Version-Release number of selected component (if applicable):
is25 RHEVH - vdsm-4.13.0-0.9.beta1.el6ev.x86_64 vdsm-python-4.13.0-0.9.beta1.el6ev.x86_64

How reproducible:
100%

Steps to Reproduce:
1. go to directly to export domain and do following kung-fu to mimic my miracle issue

# uuid=`uuidgen`; mkdir -p master/vms/$uuid ; ls -ldZ master/vms/$uuid ; ls -laZ master/vms/$uuid
drwxr-xr-x. root root unconfined_u:object_r:file_t:s0  master/vms/6b822415-d79e-44cd-a261-538f0a61c46b
drwxr-xr-x. root root unconfined_u:object_r:file_t:s0  .
drwxr-xr-x. vdsm kvm  system_u:object_r:file_t:s0      ..

2. click in RHEVM UI (admin portal) to see VM Import subtab and see list
3.

Actual results:
- vdsm: failed - stopping task
- admin portal: VM Import subtab is happily loading, loading, loading... and loading... still loading :-)

Expected results:
smartly recover and skip

Additional info:
- I found there was nothing refering to this dir so I rmdir that and voila, got my VM list in Admin Portal