Bug 1036390 - Review Request: python-django-sekizai - Django Template Blocks with extra functionality
Summary: Review Request: python-django-sekizai - Django Template Blocks with extra fun...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Matej Stuchlik
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-12-01 19:59 UTC by Jakub Dorňák
Modified: 2016-12-01 00:59 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-08-18 09:10:01 UTC
Type: ---
mstuchli: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Jakub Dorňák 2013-12-01 19:59:22 UTC
Spec URL: http://jdornak.fedorapeople.org/python-django-sekizai.spec
SRPM URL: http://jdornak.fedorapeople.org/python-django-sekizai-0.7-1.fc20.src.rpm
Description:
Sekizai means “blocks” in Japanese, and that’s what this app provides.
A fresh look at blocks. With django-sekizai you can define placeholders
where your blocks get rendered and at different places in your templates
append to those blocks. This is especially useful for css and javascript.
Your sub-templates can now define css and Javascript files to be included,
and the css will be nicely put at the top and the Javascript to the bottom,
just like you should. Also sekizai will ignore any duplicate content
in a single block.

Fedora Account System Username: jdornak

Comment 1 Matej Stuchlik 2014-03-03 08:51:26 UTC
* The license should be "BSD" instead of "BSD License".

* there's an empty file that I'm not sure if it's needed:

python-django-sekizai.noarch: E: zero-length /usr/lib/python2.7/site-packages/sekizai/models.py

Could you please verify that it is actually necessary? Otherwise we should prolly delete it. [0]

[0] https://fedoraproject.org/wiki/Common_Rpmlint_issues#zero-length

Comment 2 Jakub Dorňák 2014-03-03 10:50:48 UTC
It is part of standard django application layout. It would probably work without this file (it is not mandatory), but I see no real reason to delete it.
(License fixed)

Comment 3 Matej Stuchlik 2014-03-03 10:56:49 UTC
Okay, seems fine now, approved.

Comment 4 Jakub Dorňák 2014-03-03 12:39:26 UTC
New Package SCM Request
=======================
Package Name: python-django-sekizai
Short Description: Django Template Blocks with extra functionality
Owners: jdornak
Branches: f20
InitialCC:

Comment 5 Gwyn Ciesla 2014-03-03 13:06:47 UTC
Git done (by process-git-requests).

Comment 6 Matej Stuchlik 2015-08-18 09:10:01 UTC
Closing this as it seems to be resolved, feel free to reopen if necessary. :)


Note You need to log in before you can comment on or make changes to this bug.