Bug 1036396 - Review Request: python-social-auth - Social auth made simple
Summary: Review Request: python-social-auth - Social auth made simple
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Christopher Meng
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1036393
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-12-01 20:23 UTC by Jakub Dorňák
Modified: 2016-12-01 00:57 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-02-24 03:53:00 UTC
Type: ---
Embargoed:
i: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Jakub Dorňák 2013-12-01 20:23:25 UTC
Spec URL: http://jdornak.fedorapeople.org/python-social-auth.spec
SRPM URL: http://jdornak.fedorapeople.org/python-social-auth-0.1.17-1.fc20.src.rpm
Description:
Python Social Auth is an easy to setup social authentication/registration
mechanism with support for several frameworks and auth providers.

Crafted using base code from django-social-auth, implements a common interface
to define new authentication providers from third parties. And to bring support
for more frameworks and ORMs.

Fedora Account System Username: jdornak

Comment 1 Christopher Meng 2013-12-02 04:42:54 UTC
First, will you push it to EPEL?

Issue need to be fixed first:

Please write down files list explicitly in %files, don't use .files to ease the work. ;)

Comment 2 Christopher Meng 2013-12-19 10:54:17 UTC
Please look at comment 1 and answer my question.

Comment 3 Jakub Dorňák 2014-01-09 13:38:28 UTC
I do not plan to push it to EPEL until somebody asks for it.
What would be the implications?

Comment 4 Christopher Meng 2014-01-09 17:29:09 UTC
Assume that you are now only interested in Fedora, please improve:

0. Don't create file list by script, write down them in %files.

1. Version the python2 macro: %{__python} --> %{__python2}; %{python_sitelib} --> %{python2_sitelib}

Comment 5 Jakub Dorňák 2014-01-09 17:55:01 UTC
improved

Comment 6 Christopher Meng 2014-01-10 06:49:04 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines
- Sources used to build the package match the upstream source, as provided in
  the spec URL.
  Note: Check did not completechecksum differs and there are problems running
  diff. Please verify manually.
  See: http://fedoraproject.org/wiki/Packaging/SourceURL


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 400 files have unknown license. Detailed output
     of licensecheck:

Unknown or generated
--------------------
python-social-auth-0.1.17/%{py3dir}/docs/conf.py
python-social-auth-0.1.17/%{py3dir}/setup.py
python-social-auth-0.1.17/%{py3dir}/social/__init__.py
python-social-auth-0.1.17/%{py3dir}/social/actions.py
python-social-auth-0.1.17/%{py3dir}/social/apps/django_app/__init__.py
python-social-auth-0.1.17/%{py3dir}/social/apps/django_app/context_processors.py
python-social-auth-0.1.17/%{py3dir}/social/apps/django_app/default/__init__.py
python-social-auth-0.1.17/%{py3dir}/social/apps/django_app/default/admin.py
python-social-auth-0.1.17/%{py3dir}/social/apps/django_app/default/fields.py
python-social-auth-0.1.17/%{py3dir}/social/apps/django_app/default/models.py
python-social-auth-0.1.17/%{py3dir}/social/apps/django_app/default/tests.py
python-social-auth-0.1.17/%{py3dir}/social/apps/django_app/me/__init__.py
python-social-auth-0.1.17/%{py3dir}/social/apps/django_app/me/models.py
python-social-auth-0.1.17/%{py3dir}/social/apps/django_app/me/tests.py
python-social-auth-0.1.17/%{py3dir}/social/apps/django_app/middleware.py
python-social-auth-0.1.17/%{py3dir}/social/apps/django_app/tests.py
python-social-auth-0.1.17/%{py3dir}/social/apps/django_app/urls.py
python-social-auth-0.1.17/%{py3dir}/social/apps/django_app/utils.py
python-social-auth-0.1.17/%{py3dir}/social/apps/django_app/views.py
python-social-auth-0.1.17/%{py3dir}/social/apps/flask_app/fields.py
python-social-auth-0.1.17/%{py3dir}/social/apps/flask_app/models.py
python-social-auth-0.1.17/%{py3dir}/social/apps/flask_app/routes.py
python-social-auth-0.1.17/%{py3dir}/social/apps/flask_app/template_filters.py
python-social-auth-0.1.17/%{py3dir}/social/apps/flask_app/utils.py
python-social-auth-0.1.17/%{py3dir}/social/apps/pyramid_app/__init__.py
python-social-auth-0.1.17/%{py3dir}/social/apps/pyramid_app/fields.py
python-social-auth-0.1.17/%{py3dir}/social/apps/pyramid_app/models.py
python-social-auth-0.1.17/%{py3dir}/social/apps/pyramid_app/utils.py
python-social-auth-0.1.17/%{py3dir}/social/apps/pyramid_app/views.py
python-social-auth-0.1.17/%{py3dir}/social/apps/tornado_app/fields.py
python-social-auth-0.1.17/%{py3dir}/social/apps/tornado_app/handlers.py
python-social-auth-0.1.17/%{py3dir}/social/apps/tornado_app/models.py
python-social-auth-0.1.17/%{py3dir}/social/apps/tornado_app/routes.py
python-social-auth-0.1.17/%{py3dir}/social/apps/tornado_app/utils.py
python-social-auth-0.1.17/%{py3dir}/social/apps/webpy_app/app.py
python-social-auth-0.1.17/%{py3dir}/social/apps/webpy_app/fields.py
python-social-auth-0.1.17/%{py3dir}/social/apps/webpy_app/models.py
python-social-auth-0.1.17/%{py3dir}/social/apps/webpy_app/utils.py
python-social-auth-0.1.17/%{py3dir}/social/backends/amazon.py
python-social-auth-0.1.17/%{py3dir}/social/backends/angel.py
python-social-auth-0.1.17/%{py3dir}/social/backends/aol.py
python-social-auth-0.1.17/%{py3dir}/social/backends/appsfuel.py
python-social-auth-0.1.17/%{py3dir}/social/backends/base.py
python-social-auth-0.1.17/%{py3dir}/social/backends/behance.py
python-social-auth-0.1.17/%{py3dir}/social/backends/belgiumeid.py
python-social-auth-0.1.17/%{py3dir}/social/backends/bitbucket.py
python-social-auth-0.1.17/%{py3dir}/social/backends/box.py
python-social-auth-0.1.17/%{py3dir}/social/backends/dailymotion.py
python-social-auth-0.1.17/%{py3dir}/social/backends/disqus.py
python-social-auth-0.1.17/%{py3dir}/social/backends/douban.py
python-social-auth-0.1.17/%{py3dir}/social/backends/dropbox.py
python-social-auth-0.1.17/%{py3dir}/social/backends/email.py
python-social-auth-0.1.17/%{py3dir}/social/backends/evernote.py
python-social-auth-0.1.17/%{py3dir}/social/backends/exacttarget.py
python-social-auth-0.1.17/%{py3dir}/social/backends/facebook.py
python-social-auth-0.1.17/%{py3dir}/social/backends/fedora.py
python-social-auth-0.1.17/%{py3dir}/social/backends/fitbit.py
python-social-auth-0.1.17/%{py3dir}/social/backends/flickr.py
python-social-auth-0.1.17/%{py3dir}/social/backends/foursquare.py
python-social-auth-0.1.17/%{py3dir}/social/backends/gae.py
python-social-auth-0.1.17/%{py3dir}/social/backends/github.py
python-social-auth-0.1.17/%{py3dir}/social/backends/google.py
python-social-auth-0.1.17/%{py3dir}/social/backends/instagram.py
python-social-auth-0.1.17/%{py3dir}/social/backends/jawbone.py
python-social-auth-0.1.17/%{py3dir}/social/backends/legacy.py
python-social-auth-0.1.17/%{py3dir}/social/backends/linkedin.py
python-social-auth-0.1.17/%{py3dir}/social/backends/live.py
python-social-auth-0.1.17/%{py3dir}/social/backends/livejournal.py
python-social-auth-0.1.17/%{py3dir}/social/backends/mailru.py
python-social-auth-0.1.17/%{py3dir}/social/backends/mendeley.py
python-social-auth-0.1.17/%{py3dir}/social/backends/mixcloud.py
python-social-auth-0.1.17/%{py3dir}/social/backends/oauth.py
python-social-auth-0.1.17/%{py3dir}/social/backends/odnoklassniki.py
python-social-auth-0.1.17/%{py3dir}/social/backends/open_id.py
python-social-auth-0.1.17/%{py3dir}/social/backends/orkut.py
python-social-auth-0.1.17/%{py3dir}/social/backends/persona.py
python-social-auth-0.1.17/%{py3dir}/social/backends/podio.py
python-social-auth-0.1.17/%{py3dir}/social/backends/rdio.py
python-social-auth-0.1.17/%{py3dir}/social/backends/readability.py
python-social-auth-0.1.17/%{py3dir}/social/backends/reddit.py
python-social-auth-0.1.17/%{py3dir}/social/backends/runkeeper.py
python-social-auth-0.1.17/%{py3dir}/social/backends/shopify.py
python-social-auth-0.1.17/%{py3dir}/social/backends/skyrock.py
python-social-auth-0.1.17/%{py3dir}/social/backends/soundcloud.py
python-social-auth-0.1.17/%{py3dir}/social/backends/stackoverflow.py
python-social-auth-0.1.17/%{py3dir}/social/backends/steam.py
python-social-auth-0.1.17/%{py3dir}/social/backends/stocktwits.py
python-social-auth-0.1.17/%{py3dir}/social/backends/stripe.py
python-social-auth-0.1.17/%{py3dir}/social/backends/suse.py
python-social-auth-0.1.17/%{py3dir}/social/backends/thisismyjam.py
python-social-auth-0.1.17/%{py3dir}/social/backends/trello.py
python-social-auth-0.1.17/%{py3dir}/social/backends/tripit.py
python-social-auth-0.1.17/%{py3dir}/social/backends/tumblr.py
python-social-auth-0.1.17/%{py3dir}/social/backends/twilio.py
python-social-auth-0.1.17/%{py3dir}/social/backends/twitter.py
python-social-auth-0.1.17/%{py3dir}/social/backends/username.py
python-social-auth-0.1.17/%{py3dir}/social/backends/utils.py
python-social-auth-0.1.17/%{py3dir}/social/backends/vk.py
python-social-auth-0.1.17/%{py3dir}/social/backends/weibo.py
python-social-auth-0.1.17/%{py3dir}/social/backends/xing.py
python-social-auth-0.1.17/%{py3dir}/social/backends/yahoo.py
python-social-auth-0.1.17/%{py3dir}/social/backends/yammer.py
python-social-auth-0.1.17/%{py3dir}/social/backends/yandex.py
python-social-auth-0.1.17/%{py3dir}/social/exceptions.py
python-social-auth-0.1.17/%{py3dir}/social/p3.py
python-social-auth-0.1.17/%{py3dir}/social/pipeline/disconnect.py
python-social-auth-0.1.17/%{py3dir}/social/pipeline/mail.py
python-social-auth-0.1.17/%{py3dir}/social/pipeline/partial.py
python-social-auth-0.1.17/%{py3dir}/social/pipeline/social_auth.py
python-social-auth-0.1.17/%{py3dir}/social/pipeline/user.py
python-social-auth-0.1.17/%{py3dir}/social/storage/base.py
python-social-auth-0.1.17/%{py3dir}/social/storage/django_orm.py
python-social-auth-0.1.17/%{py3dir}/social/storage/sqlalchemy_orm.py
python-social-auth-0.1.17/%{py3dir}/social/store.py
python-social-auth-0.1.17/%{py3dir}/social/strategies/base.py
python-social-auth-0.1.17/%{py3dir}/social/strategies/django_strategy.py
python-social-auth-0.1.17/%{py3dir}/social/strategies/flask_strategy.py
python-social-auth-0.1.17/%{py3dir}/social/strategies/pyramid_strategy.py
python-social-auth-0.1.17/%{py3dir}/social/strategies/tornado_strategy.py
python-social-auth-0.1.17/%{py3dir}/social/strategies/utils.py
python-social-auth-0.1.17/%{py3dir}/social/strategies/webpy_strategy.py
python-social-auth-0.1.17/%{py3dir}/social/tests/actions/actions.py
python-social-auth-0.1.17/%{py3dir}/social/tests/actions/test_associate.py
python-social-auth-0.1.17/%{py3dir}/social/tests/actions/test_disconnect.py
python-social-auth-0.1.17/%{py3dir}/social/tests/actions/test_login.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/base.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/legacy.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/oauth.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/open_id.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_amazon.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_angel.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_behance.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_bitbucket.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_box.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_broken.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_dailymotion.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_disqus.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_dropbox.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_dummy.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_email.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_evernote.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_facebook.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_fitbit.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_flickr.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_foursquare.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_github.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_google.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_instagram.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_linkedin.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_live.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_livejournal.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_mixcloud.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_podio.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_readability.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_reddit.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_skyrock.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_soundcloud.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_stackoverflow.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_steam.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_stocktwits.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_stripe.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_thisismyjam.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_tripit.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_tumblr.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_twitter.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_username.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_utils.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_vk.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_xing.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_yahoo.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_yammer.py
python-social-auth-0.1.17/%{py3dir}/social/tests/backends/test_yandex.py
python-social-auth-0.1.17/%{py3dir}/social/tests/models.py
python-social-auth-0.1.17/%{py3dir}/social/tests/pipeline.py
python-social-auth-0.1.17/%{py3dir}/social/tests/run_tests.sh
python-social-auth-0.1.17/%{py3dir}/social/tests/strategy.py
python-social-auth-0.1.17/%{py3dir}/social/tests/test_exceptions.py
python-social-auth-0.1.17/%{py3dir}/social/tests/test_pipeline.py
python-social-auth-0.1.17/%{py3dir}/social/tests/test_storage.py
python-social-auth-0.1.17%check/%{py3dir}/social/tests/test_utils.py
python-social-auth-0.1.17/%{py3dir}/social/utils.py
python-social-auth-0.1.17/docs/conf.py
python-social-auth-0.1.17/examples/django_example/example/app/mail.py
python-social-auth-0.1.17/examples/django_example/example/app/models.py
python-social-auth-0.1.17/examples/django_example/example/app/pipeline.py
python-social-auth-0.1.17/examples/django_example/example/app/views.py
python-social-auth-0.1.17/examples/django_example/example/settings.py
python-social-auth-0.1.17/examples/django_example/example/urls.py
python-social-auth-0.1.17/examples/django_example/example/wsgi.py
python-social-auth-0.1.17/examples/django_example/manage.py
python-social-auth-0.1.17/examples/django_me_example/example/app/mail.py
python-social-auth-0.1.17/examples/django_me_example/example/app/models.py
python-social-auth-0.1.17/examples/django_me_example/example/app/pipeline.py
python-social-auth-0.1.17/examples/django_me_example/example/app/views.py
python-social-auth-0.1.17/examples/django_me_example/example/settings.py
python-social-auth-0.1.17/examples/django_me_example/example/urls.py
python-social-auth-0.1.17/examples/django_me_example/example/wsgi.py
python-social-auth-0.1.17/examples/django_me_example/manage.py
python-social-auth-0.1.17/examples/flask_example/__init__.py
python-social-auth-0.1.17/examples/flask_example/manage.py
python-social-auth-0.1.17/examples/flask_example/models/__init__.py
python-social-auth-0.1.17/examples/flask_example/models/user.py
python-social-auth-0.1.17/examples/flask_example/routes/__init__.py
python-social-auth-0.1.17/examples/flask_example/routes/main.py
python-social-auth-0.1.17/examples/flask_example/settings.py
python-social-auth-0.1.17/examples/pyramid_example/example/__init__.py
python-social-auth-0.1.17/examples/pyramid_example/example/auth.py
python-social-auth-0.1.17/examples/pyramid_example/example/models.py
python-social-auth-0.1.17/examples/pyramid_example/example/scripts/__init__.py
python-social-auth-0.1.17/examples/pyramid_example/example/scripts/initializedb.py
python-social-auth-0.1.17/examples/pyramid_example/example/settings.py
python-social-auth-0.1.17/examples/pyramid_example/example/tests.py
python-social-auth-0.1.17/examples/pyramid_example/example/views.py
python-social-auth-0.1.17/examples/pyramid_example/setup.py
python-social-auth-0.1.17/examples/tornado_example/app.py
python-social-auth-0.1.17/examples/tornado_example/models.py
python-social-auth-0.1.17/examples/tornado_example/settings.py
python-social-auth-0.1.17/examples/webpy_example/app.py
python-social-auth-0.1.17/examples/webpy_example/migrate.py
python-social-auth-0.1.17/examples/webpy_example/models.py
python-social-auth-0.1.17/setup.py
python-social-auth-0.1.17/social/__init__.py
python-social-auth-0.1.17/social/actions.py
python-social-auth-0.1.17/social/apps/django_app/__init__.py
python-social-auth-0.1.17/social/apps/django_app/context_processors.py
python-social-auth-0.1.17/social/apps/django_app/default/__init__.py
python-social-auth-0.1.17/social/apps/django_app/default/admin.py
python-social-auth-0.1.17/social/apps/django_app/default/fields.py
python-social-auth-0.1.17/social/apps/django_app/default/models.py
python-social-auth-0.1.17/social/apps/django_app/default/tests.py
python-social-auth-0.1.17/social/apps/django_app/me/__init__.py
python-social-auth-0.1.17/social/apps/django_app/me/models.py
python-social-auth-0.1.17/social/apps/django_app/me/tests.py
python-social-auth-0.1.17/social/apps/django_app/middleware.py
python-social-auth-0.1.17/social/apps/django_app/tests.py
python-social-auth-0.1.17/social/apps/django_app/urls.py
python-social-auth-0.1.17/social/apps/django_app/utils.py
python-social-auth-0.1.17/social/apps/django_app/views.py
python-social-auth-0.1.17/social/apps/flask_app/fields.py
python-social-auth-0.1.17/social/apps/flask_app/models.py
python-social-auth-0.1.17/social/apps/flask_app/routes.py
python-social-auth-0.1.17/social/apps/flask_app/template_filters.py
python-social-auth-0.1.17/social/apps/flask_app/utils.py
python-social-auth-0.1.17/social/apps/pyramid_app/__init__.py
python-social-auth-0.1.17/social/apps/pyramid_app/fields.py
python-social-auth-0.1.17/social/apps/pyramid_app/models.py
python-social-auth-0.1.17/social/apps/pyramid_app/utils.py
python-social-auth-0.1.17/social/apps/pyramid_app/views.py
python-social-auth-0.1.17/social/apps/tornado_app/fields.py
python-social-auth-0.1.17/social/apps/tornado_app/handlers.py
python-social-auth-0.1.17/social/apps/tornado_app/models.py
python-social-auth-0.1.17/social/apps/tornado_app/routes.py
python-social-auth-0.1.17/social/apps/tornado_app/utils.py
python-social-auth-0.1.17/social/apps/webpy_app/app.py
python-social-auth-0.1.17/social/apps/webpy_app/fields.py
python-social-auth-0.1.17/social/apps/webpy_app/models.py
python-social-auth-0.1.17/social/apps/webpy_app/utils.py
python-social-auth-0.1.17/social/backends/amazon.py
python-social-auth-0.1.17/social/backends/angel.py
python-social-auth-0.1.17/social/backends/aol.py
python-social-auth-0.1.17/social/backends/appsfuel.py
python-social-auth-0.1.17/social/backends/base.py
python-social-auth-0.1.17/social/backends/behance.py
python-social-auth-0.1.17/social/backends/belgiumeid.py
python-social-auth-0.1.17/social/backends/bitbucket.py
python-social-auth-0.1.17/social/backends/box.py
python-social-auth-0.1.17/social/backends/dailymotion.py
python-social-auth-0.1.17/social/backends/disqus.py
python-social-auth-0.1.17/social/backends/douban.py
python-social-auth-0.1.17/social/backends/dropbox.py
python-social-auth-0.1.17/social/backends/email.py
python-social-auth-0.1.17/social/backends/evernote.py
python-social-auth-0.1.17/social/backends/exacttarget.py
python-social-auth-0.1.17/social/backends/facebook.py
python-social-auth-0.1.17/social/backends/fedora.py
python-social-auth-0.1.17/social/backends/fitbit.py
python-social-auth-0.1.17/social/backends/flickr.py
python-social-auth-0.1.17/social/backends/foursquare.py
python-social-auth-0.1.17/social/backends/gae.py
python-social-auth-0.1.17/social/backends/github.py
python-social-auth-0.1.17/social/backends/google.py
python-social-auth-0.1.17/social/backends/instagram.py
python-social-auth-0.1.17/social/backends/jawbone.py
python-social-auth-0.1.17/social/backends/legacy.py
python-social-auth-0.1.17/social/backends/linkedin.py
python-social-auth-0.1.17/social/backends/live.py
python-social-auth-0.1.17/social/backends/livejournal.py
python-social-auth-0.1.17/social/backends/mailru.py
python-social-auth-0.1.17/social/backends/mendeley.py
python-social-auth-0.1.17/social/backends/mixcloud.py
python-social-auth-0.1.17/social/backends/oauth.py
python-social-auth-0.1.17/social/backends/odnoklassniki.py
python-social-auth-0.1.17/social/backends/open_id.py
python-social-auth-0.1.17/social/backends/orkut.py
python-social-auth-0.1.17/social/backends/persona.py
python-social-auth-0.1.17/social/backends/podio.py
python-social-auth-0.1.17/social/backends/rdio.py
python-social-auth-0.1.17/social/backends/readability.py
python-social-auth-0.1.17/social/backends/reddit.py
python-social-auth-0.1.17/social/backends/runkeeper.py
python-social-auth-0.1.17/social/backends/shopify.py
python-social-auth-0.1.17/social/backends/skyrock.py
python-social-auth-0.1.17/social/backends/soundcloud.py
python-social-auth-0.1.17/social/backends/stackoverflow.py
python-social-auth-0.1.17/social/backends/steam.py
python-social-auth-0.1.17/social/backends/stocktwits.py
python-social-auth-0.1.17/social/backends/stripe.py
python-social-auth-0.1.17/social/backends/suse.py
python-social-auth-0.1.17/social/backends/thisismyjam.py
python-social-auth-0.1.17/social/backends/trello.py
python-social-auth-0.1.17/social/backends/tripit.py
python-social-auth-0.1.17/social/backends/tumblr.py
python-social-auth-0.1.17/social/backends/twilio.py
python-social-auth-0.1.17/social/backends/twitter.py
python-social-auth-0.1.17/social/backends/username.py
python-social-auth-0.1.17/social/backends/utils.py
python-social-auth-0.1.17/social/backends/vk.py
python-social-auth-0.1.17/social/backends/weibo.py
python-social-auth-0.1.17/social/backends/xing.py
python-social-auth-0.1.17/social/backends/yahoo.py
python-social-auth-0.1.17/social/backends/yammer.py
python-social-auth-0.1.17/social/backends/yandex.py
python-social-auth-0.1.17/social/exceptions.py
python-social-auth-0.1.17/social/p3.py
python-social-auth-0.1.17/social/pipeline/disconnect.py
python-social-auth-0.1.17/social/pipeline/mail.py
python-social-auth-0.1.17/social/pipeline/partial.py
python-social-auth-0.1.17/social/pipeline/social_auth.py
python-social-auth-0.1.17/social/pipeline/user.py
python-social-auth-0.1.17/social/storage/base.py
python-social-auth-0.1.17/social/storage/django_orm.py
python-social-auth-0.1.17/social/storage/sqlalchemy_orm.py
python-social-auth-0.1.17/social/store.py
python-social-auth-0.1.17/social/strategies/base.py
python-social-auth-0.1.17/social/strategies/django_strategy.py
python-social-auth-0.1.17/social/strategies/flask_strategy.py
python-social-auth-0.1.17/social/strategies/pyramid_strategy.py
python-social-auth-0.1.17/social/strategies/tornado_strategy.py
python-social-auth-0.1.17/social/strategies/utils.py
python-social-auth-0.1.17/social/strategies/webpy_strategy.py
python-social-auth-0.1.17/social/tests/actions/actions.py
python-social-auth-0.1.17/social/tests/actions/test_associate.py
python-social-auth-0.1.17/social/tests/actions/test_disconnect.py
python-social-auth-0.1.17/social/tests/actions/test_login.py
python-social-auth-0.1.17/social/tests/backends/base.py
python-social-auth-0.1.17/social/tests/backends/legacy.py
python-social-auth-0.1.17/social/tests/backends/oauth.py
python-social-auth-0.1.17/social/tests/backends/open_id.py
python-social-auth-0.1.17/social/tests/backends/test_amazon.py
python-social-auth-0.1.17/social/tests/backends/test_angel.py
python-social-auth-0.1.17/social/tests/backends/test_behance.py
python-social-auth-0.1.17/social/tests/backends/test_bitbucket.py
python-social-auth-0.1.17/social/tests/backends/test_box.py
python-social-auth-0.1.17/social/tests/backends/test_broken.py
python-social-auth-0.1.17/social/tests/backends/test_dailymotion.py
python-social-auth-0.1.17/social/tests/backends/test_disqus.py
python-social-auth-0.1.17/social/tests/backends/test_dropbox.py
python-social-auth-0.1.17/social/tests/backends/test_dummy.py
python-social-auth-0.1.17/social/tests/backends/test_email.py
python-social-auth-0.1.17/social/tests/backends/test_evernote.py
python-social-auth-0.1.17/social/tests/backends/test_facebook.py
python-social-auth-0.1.17/social/tests/backends/test_fitbit.py
python-social-auth-0.1.17/social/tests/backends/test_flickr.py
python-social-auth-0.1.17/social/tests/backends/test_foursquare.py
python-social-auth-0.1.17/social/tests/backends/test_github.py
python-social-auth-0.1.17/social/tests/backends/test_google.py
python-social-auth-0.1.17/social/tests/backends/test_instagram.py
python-social-auth-0.1.17/social/tests/backends/test_linkedin.py
python-social-auth-0.1.17/social/tests/backends/test_live.py
python-social-auth-0.1.17/social/tests/backends/test_livejournal.py
python-social-auth-0.1.17/social/tests/backends/test_mixcloud.py
python-social-auth-0.1.17/social/tests/backends/test_podio.py
python-social-auth-0.1.17/social/tests/backends/test_readability.py
python-social-auth-0.1.17/social/tests/backends/test_reddit.py
python-social-auth-0.1.17/social/tests/backends/test_skyrock.py
python-social-auth-0.1.17/social/tests/backends/test_soundcloud.py
python-social-auth-0.1.17/social/tests/backends/test_stackoverflow.py
python-social-auth-0.1.17/social/tests/backends/test_steam.py
python-social-auth-0.1.17/social/tests/backends/test_stocktwits.py
python-social-auth-0.1.17/social/tests/backends/test_stripe.py
python-social-auth-0.1.17/social/tests/backends/test_thisismyjam.py
python-social-auth-0.1.17/social/tests/backends/test_tripit.py
python-social-auth-0.1.17/social/tests/backends/test_tumblr.py
python-social-auth-0.1.17/social/tests/backends/test_twitter.py
python-social-auth-0.1.17/social/tests/backends/test_username.py
python-social-auth-0.1.17/social/tests/backends/test_utils.py
python-social-auth-0.1.17/social/tests/backends/test_vk.py
python-social-auth-0.1.17/social/tests/backends/test_xing.py
python-social-auth-0.1.17/social/tests/backends/test_yahoo.py
python-social-auth-0.1.17/social/tests/backends/test_yammer.py
python-social-auth-0.1.17/social/tests/backends/test_yandex.py
python-social-auth-0.1.17/social/tests/models.py
python-social-auth-0.1.17/social/tests/pipeline.py
python-social-auth-0.1.17/social/tests/run_tests.sh
python-social-auth-0.1.17/social/tests/strategy.py
python-social-auth-0.1.17/social/tests/test_exceptions.py
python-social-auth-0.1.17/social/tests/test_pipeline.py
python-social-auth-0.1.17/social/tests/test_storage.py
python-social-auth-0.1.17/social/tests/test_utils.py
python-social-auth-0.1.17/social/utils.py

[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 40960 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3
     -social-auth , python3-social-auth-doc
[x]: Package functions as described.
[-]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint


Installation errors
-------------------
INFO: mock.py version 1.1.35 starting...
Start: init plugins
INFO: selinux enabled
Finish: init plugins
Start: run
Mock Version: 1.1.35
INFO: Mock Version: 1.1.35
Start: lock buildroot
INFO: installing package(s): /home/rpmaker/Desktop/python-social-auth/results/python-social-auth-0.1.17-1.fc21.noarch.rpm /home/rpmaker/Desktop/python-social-auth/results/python-social-auth-doc-0.1.17-1.fc21.noarch.rpm /home/rpmaker/Desktop/python-social-auth/results/python3-social-auth-0.1.17-1.fc21.noarch.rpm /home/rpmaker/Desktop/python-social-auth/results/python3-social-auth-doc-0.1.17-1.fc21.noarch.rpm
ERROR: Command failed: 
 # ['/usr/bin/yum', '--installroot', '/var/lib/mock/fedora-rawhide-i386/root/', 'install', '/home/rpmaker/Desktop/python-social-auth/results/python-social-auth-0.1.17-1.fc21.noarch.rpm', '/home/rpmaker/Desktop/python-social-auth/results/python-social-auth-doc-0.1.17-1.fc21.noarch.rpm', '/home/rpmaker/Desktop/python-social-auth/results/python3-social-auth-0.1.17-1.fc21.noarch.rpm', '/home/rpmaker/Desktop/python-social-auth/results/python3-social-auth-doc-0.1.17-1.fc21.noarch.rpm', '--setopt=tsflags=nocontexts']
Error: Package: python3-social-auth-0.1.17-1.fc21.noarch (/python3-social-auth-0.1.17-1.fc21.noarch)
           Requires: python3-openid >= 3.0.1
 You could try using --skip-broken to work around the problem
 You could try running: rpm -Va --nofiles --nodigest



Rpmlint
-------
Checking: python-social-auth-0.1.17-1.fc21.noarch.rpm
          python-social-auth-doc-0.1.17-1.fc21.noarch.rpm
          python3-social-auth-0.1.17-1.fc21.noarch.rpm
          python3-social-auth-doc-0.1.17-1.fc21.noarch.rpm
          python-social-auth-0.1.17-1.fc21.src.rpm
python-social-auth.noarch: W: spelling-error %description -l en_US django -> fandango
python-social-auth.noarch: W: invalid-license BSD License
python-social-auth-doc.noarch: W: invalid-license BSD License
python-social-auth-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-social-auth-doc/html/.buildinfo
python3-social-auth.noarch: W: spelling-error %description -l en_US django -> fandango
python3-social-auth.noarch: W: invalid-license BSD License
python3-social-auth-doc.noarch: W: invalid-license BSD License
python3-social-auth-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python3-social-auth-doc/html/.buildinfo
python-social-auth.src: W: spelling-error %description -l en_US django -> fandango
python-social-auth.src: W: invalid-license BSD License
python-social-auth.src: W: strange-permission python-social-auth.spec 0640L
python-social-auth.src: W: strange-permission python-social-auth-0.1.17.tar.gz 0640L
5 packages and 0 specfiles checked; 0 errors, 12 warnings.




Requires
--------
python3-social-auth-doc (rpmlib, GLIBC filtered):
    python3-social-auth

python3-social-auth (rpmlib, GLIBC filtered):
    python(abi)
    python3-oauthlib
    python3-openid
    python3-requests
    python3-requests-oauthlib
    python3-six

python-social-auth-doc (rpmlib, GLIBC filtered):
    python-social-auth

python-social-auth (rpmlib, GLIBC filtered):
    python(abi)
    python-oauthlib
    python-openid
    python-requests
    python-requests-oauthlib
    python-six



Provides
--------
python3-social-auth-doc:
    python3-social-auth-doc

python3-social-auth:
    python3-social-auth

python-social-auth-doc:
    python-social-auth-doc

python-social-auth:
    python-social-auth



Source checksums
----------------
https://codeload.github.com/omab/python-social-auth/tar.gz/v0.1.17?filename=python-social-auth-0.1.17.tar.gz :
  CHECKSUM(SHA256) this package     : ERROR
  CHECKSUM(SHA256) upstream package : e9fbe93c98be0df32c42e4de8885310be5bd27cb23814e73401e3338b857e0b5


Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/bin/fedora-review -rvn python-social-auth-0.1.17-1.fc20.src.rpm
Buildroot used: fedora-rawhide-i386
Active plugins: Generic, Python, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: BATCH, EPEL5, EXARCH, DISTTAG

------------------------
1. Better re download sources again from pypi and rebuild the SRPM.

2. Correct the license field.

3. Solve the dependency problem.

Comment 7 Jakub Dorňák 2014-01-13 12:38:51 UTC
ad 1.)

The source from pypi does not contain docs and examples, while the source from githup does. Is it really better to use the one from pypi?

ad 2.)

I am not sure how to fix this.

ad 3.)

The dependancies will be solved by other (sub)packages proposed by me.

Comment 8 Christopher Meng 2014-01-14 11:44:34 UTC
(In reply to Jakub Dorňák from comment #7)
> ad 1.)
> 
> The source from pypi does not contain docs and examples, while the source
> from githup does. Is it really better to use the one from pypi?

No ;-).

But according to the results, this tag has been retagged, you can download source from URL again and then rebuild again with the sources just downloaded. And better file an issue on github of including docs into tarballs on pypi.

> ad 2.)
> 
> I am not sure how to fix this.

Just "BSD", no extra 'License' needed in the field, See: 

https://fedoraproject.org/wiki/Licensing:Main

> ad 3.)
> 
> The dependancies will be solved by other (sub)packages proposed by me.

-----------------------
I will set fedora-review + for this package, however please fix above #1 and #2 before SCM, I'm watching. ;D

PACKAGE APPROVED.

Comment 9 Jakub Dorňák 2014-01-16 16:19:21 UTC
New Package SCM Request
=======================
Package Name: python-social-auth
Short Description: Social auth made simple
Owners: jdornak
Branches: f20
InitialCC:

Comment 10 Gwyn Ciesla 2014-01-16 17:25:16 UTC
Git done (by process-git-requests).

Comment 11 Jakub Dorňák 2014-01-16 20:37:15 UTC
Anyway, I have to wait until python3-openid review process is finished first.

Comment 12 Patrick Uiterwijk 2014-01-18 20:41:34 UTC
Could we please get EPEL 6 and 7 branches? I would be more than glad to maintain those, as we need them for Fedora Infrastructure.

Comment 13 Jakub Dorňák 2014-01-20 08:17:20 UTC
Hi Christopher,
You have asked whether I am going to push it to EPEL.
Are there some additional requirements for the package to be pushed to EPEL?
How can I request epel branches?

Thank You,
QB

Comment 14 Christopher Meng 2014-01-20 09:00:54 UTC
For EPEL6 these python versioned macros don't exist, you need to add some hack for epel == 6 with __python macro redefined. 

But EPEL7 doesn't need this modification. 

For requesting new branches instructions, please refer to:

http://fedoraproject.org/wiki/Package_SCM_admin_requests#Package_Change_Requests_for_existing_packages

Comment 15 Jakub Dorňák 2014-01-20 09:39:39 UTC
Package Change Request
======================
Package Name: python-social-auth
New Branches: el6 epel7
Owners: jdornak
InitialCC: 

Users requested EPEL 6 and 7 branches.

Comment 16 Gwyn Ciesla 2014-01-21 14:04:47 UTC
Git done (by process-git-requests).

Comment 17 Eduardo Echeverria 2014-02-02 03:35:15 UTC
Jakub I'm using this package, thanks for bring this to Fedora :)
I saw that epel7 build fails, you can fix if put this lines above the spec, due to py3 doesn't exists in epel7, also python2 macro doesn't exists on epel.

# Workaround for epel versions where don't exists python2 macro
%{!?__python2: %global __python2 %{__python}}

%if 0%{?fedora} > 12
%global with_python3 1
%else
%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print (get_python_lib())")}
%endif

Best Regards, sorry for not open a bug for say this, due to isn't a bug, and the review is recent

Comment 18 Jakub Dorňák 2014-02-03 09:27:42 UTC
Well,
it now builds for epel7, but there are some broken dependences:

On x86_64:
python-social-auth-0.1.19-1.el7.noarch requires python-requests-oauthlib
python-social-auth-0.1.19-1.el7.noarch requires python-oauthlib

On ppc64:
python-social-auth-0.1.19-1.el7.noarch requires python-requests-oauthlib
python-social-auth-0.1.19-1.el7.noarch requires python-requests
python-social-auth-0.1.19-1.el7.noarch requires python-oauthlib

Comment 19 Jakub Dorňák 2014-02-03 11:34:42 UTC
There are epel7 branches of python-oauthlib and python-requests-oauthlib.
I have just requested epel7 branch of python-requests.

Comment 20 Christopher Meng 2014-02-24 03:53:00 UTC
No f20 build, no epel6 build, no epel7 build.

RAWHIDE only, anyway.


Note You need to log in before you can comment on or make changes to this bug.