Bug 1036471 - inadyn-mt does not fork when started by systemd
Summary: inadyn-mt does not fork when started by systemd
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: inadyn-mt
Version: 20
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jochen Schmitt
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-12-02 05:11 UTC by Gabriel M. Beddingfield
Modified: 2014-05-23 17:42 UTC (History)
3 users (show)

Fixed In Version: inadyn-mt-2.24.38-2.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-05-10 03:18:58 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Gabriel M. Beddingfield 2013-12-02 05:11:20 UTC
Description of problem:
When inadyn is started by systemd, it works fine but does not fork into the background.  systemd complains that the service timed out.

Version-Release number of selected component (if applicable):
Name        : inadyn-mt
Arch        : x86_64
Version     : 2.24.36
Release     : 11.fc19

How reproducible:
100%

Steps to Reproduce:
1. Install inadyn-mt
2. Edit /etc/inadyn-mt.conf with dyndns account information.
3. # systemctl start inadyn

Actual results:

After a long time, systemctl returns with:
[gabriel@localhost ~]$ sudo systemctl start inadyn
Job for inadyn.service failed. See 'systemctl status inadyn.service' and 'journalctl -xn' for details.
[gabriel@localhost ~]$ journalctl -xn
-- Logs begin at Thu 2013-11-28 10:45:53 PST, end at Sun 2013-12-01 20:38:24 PST. --
Dec 01 20:36:57 localhost.localdomain inadyn[6812]: Date: Mon, 02 Dec 2013 04:36:57 
Dec 01 20:36:57 localhost.localdomain inadyn[6812]: Server: Apache
Dec 01 20:36:57 localhost.localdomain inadyn[6812]: X-User-Status: vip
Dec 01 20:36:57 localhost.localdomain inadyn[6812]: Content-Type: text/plain
Dec 01 20:36:57 localhost.localdomain inadyn[6812]: Accept-Ranges: none
Dec 01 20:36:57 localhost.localdomain inadyn[6812]: Connection: close
Dec 01 20:36:57 localhost.localdomain inadyn[6812]: good 24.6.80.191
Dec 01 20:38:24 localhost.localdomain systemd[1]: inadyn.service operation timed out
Dec 01 20:38:24 localhost.localdomain systemd[1]: Failed to start Inadyn-mt, registe
-- Subject: Unit inadyn.service has failed
-- Defined-By: systemd
-- Support: http://lists.freedesktop.org/mailman/listinfo/systemd-devel
-- Documentation: http://www.freedesktop.org/wiki/Software/systemd/catalog/be02cf685
-- 
-- Unit inadyn.service has failed.
-- 
-- The result is failed.
Dec 01 20:38:24 localhost.localdomain systemd[1]: Unit inadyn.service entered failed

(Note: the IP address *was* updated on dyndns)

Expected results:

That systemctl return immediately with no messages.

Additional info:

I worked around the problem by adding `--background' to /etc/inadyn-mt.conf .  I tried to add it to /usr/lib/systemd/system/inadyn.service (Service.ExecStart), but that doesn't work.  When you add any command-line arguments, it doesn't open the default config file.

Comment 1 redhat-bugzilla 2014-02-15 19:44:26 UTC
This bug is still present in Fedora 20 as of 2014-02-15!

IMHO:
Type=simple and not using --background in the .conf file is the better 
solution. Works fine for me at least.

Or stay with type forking and use --background. But the way it is currently does not fit together - either change the inadyn.conf that comes with the package or change the unit file (inadyn.service)!

Also, when you're at this, please add
# do not run as root
change_persona 99:99

to the inadyn.conf file. Otherwise inadyn will run as root and I don't really see why the hell it should when it can do fine without by just adding a single line.

Comment 2 Gabriel M. Beddingfield 2014-02-17 05:12:18 UTC
Changed Fedora Version to 20.

Comment 3 Ville Skyttä 2014-04-23 14:27:48 UTC
A better fix is to simply remove Type=forking from the service file and let systemd handle daemonization.

Comment 4 Fedora Update System 2014-05-01 09:17:22 UTC
inadyn-mt-2.24.38-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/inadyn-mt-2.24.38-2.fc20

Comment 5 Fedora Update System 2014-05-01 22:23:52 UTC
Package inadyn-mt-2.24.38-2.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing inadyn-mt-2.24.38-2.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-5892/inadyn-mt-2.24.38-2.fc20
then log in and leave karma (feedback).

Comment 6 Fedora Update System 2014-05-10 03:18:58 UTC
inadyn-mt-2.24.38-2.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 7 Ville Skyttä 2014-05-23 17:42:56 UTC
(In reply to redhat-bugzilla from comment #1)
> Also, when you're at this, please add
> # do not run as root
> change_persona 99:99
> 
> to the inadyn.conf file. Otherwise inadyn will run as root and I don't
> really see why the hell it should when it can do fine without by just adding
> a single line.

Re-filed as #1100889 so it won't fall through the cracks.


Note You need to log in before you can comment on or make changes to this bug.