Bug 1036685 - Riftsaw bpel console deployment-structure.xml
Summary: Riftsaw bpel console deployment-structure.xml
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Fuse Service Works 6
Classification: JBoss
Component: BPEL Integration
Version: 6.0.0 GA
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ER8
: 6.0.0
Assignee: Eric Wittmann
QA Contact: lvaskova
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-12-02 13:23 UTC by Nick Cross
Modified: 2014-02-06 15:33 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: Bug


Attachments (Terms of Use)

Description Nick Cross 2013-12-02 13:23:21 UTC
Riftsaw, when building switchyard-bpel-console-server.war / switchyard-bpel-console.war bundles its own jboss-deployment-structure.xml. This is overwriting the new jboss-deployment-structure.xml in BPMConsole. Should BPMConsole now take precedence and the riftsaw ones be removed?

Comment 2 Eric Wittmann 2013-12-02 13:43:42 UTC
This is my bad.  I am actually not familiar with how riftsaw builds the BPM console.  As a result I may have added the deployment structure XML file unintentionally when trying to build it locally (for testing my changes).  Would it be possible for you to compare the two and see if they are different?

Most likely I did add the overlord auth module to the deployment structure file, so it will probably be different.  I was trying to make sure I didn't mess anything up in the community edition...working from imperfect understanding of how everything fits together. :(

Comment 3 Nick Cross 2013-12-02 14:13:05 UTC
Hi,

In Riftsaw we have e.g. for console/gwt-console-server/src/main/resources/jboss-deployment-structure.xml
<jboss-deployment-structure xmlns="urn:jboss:deployment-structure:1.0">
<deployment>
	 <dependencies>
		  <module name="org.slf4j" />
	      <module name="org.jboss.resteasy.resteasy-jaxrs" />
		  <module name="org.jboss.resteasy.resteasy-jaxb-provider" />
		  <module name="org.jboss.resteasy.resteasy-multipart-provider" />
	      <module name="org.switchyard.component.bpel" services="import"/>
	 </dependencies>
 </deployment>
</jboss-deployment-structure>

but in BPMConsole it is 
<jboss-deployment-structure xmlns="urn:jboss:deployment-structure:1.0">
<deployment>
     <dependencies>
          <module name="org.slf4j" />
          <module name="org.picketbox" />
          <module name="org.picketlink" />
          <module name="org.overlord.commons.overlord-commons-auth" />
          <module name="org.jboss.as.web" />
          <module name="org.jboss.resteasy.resteasy-jaxrs" />
          <module name="org.jboss.resteasy.resteasy-jaxb-provider" />
          <module name="org.jboss.resteasy.resteasy-multipart-provider" />
          <module name="org.switchyard.component.bpel" services="import"/>
     </dependencies>
 </deployment>
</jboss-deployment-structure>

Comment 4 Nick Cross 2013-12-02 14:20:57 UTC
For ./gui/war/target/default-war/META-INF/jboss-deployment-structure.xml there is

<jboss-deployment-structure xmlns="urn:jboss:deployment-structure:1.0">
    <deployment>
	 <dependencies>
          <module name="org.slf4j" />
          <module name="org.javassist" />
	      <module name="org.switchyard.component.bpel"/>
	    </dependencies>		
    </deployment>
</jboss-deployment-structure>


but in BPMConsole there is

<jboss-deployment-structure>
  <deployment>
    <dependencies>
      <module name="org.jboss.as.naming" />
      <module name="org.jboss.as.server" />
      <module name="org.jboss.msc" />
      <module name="org.jboss.netty" />
      <module name="org.picketbox" />
      <module name="org.picketlink" />
      <module name="org.jboss.resteasy.resteasy-jaxrs" />
      <module name="org.overlord.commons.overlord-commons-auth" />
      <module name="org.apache.httpcomponents" />
      <module name="org.apache.commons.codec" />
      <module name="org.apache.commons.configuration" />
      <module name="org.apache.commons.lang" />
      </dependencies>
  </deployment>
</jboss-deployment-structure>


Should BPMConsole have the "org.switchyard.component.bpel" dependency?

Comment 5 Eric Wittmann 2013-12-02 15:15:38 UTC
Ok I updated git with what I think is the right content for this file:

https://github.com/jboss-integration/bpm-console/commit/28bb6a0f89d1b2febd203f26badcfc3ad63929ad

As a result, I think we should deploy the one that's checked in to the BPM console repository:

https://github.com/jboss-integration/bpm-console/blob/28bb6a0f89d1b2febd203f26badcfc3ad63929ad/gui/war/src/main/webapp/META-INF/jboss-deployment-structure.xml

Please advise on what to do next - would you like a new ER7 tag?

Comment 6 Nick Cross 2013-12-02 16:23:07 UTC
Yes please. But can we update riftsaw as well so that it doesn't overwrite this file during assembly ?

Comment 7 Eric Wittmann 2013-12-03 14:28:13 UTC
I will update the jboss-deployment-structure.xml files appropriately (for both the bpel-console WAR and the bpel-console-server WAR) and check them in to the riftsaw repo.  I will also *delete* the copies in the bpm-console repository.  This will leave us with just one copy in the same place it's always been.

Comment 8 Nick Cross 2013-12-09 14:58:06 UTC
Done in latest tags.

Comment 9 Len DiMaggio 2014-01-08 16:06:56 UTC
The file contents in ER8 are:

more jboss-deployment-structure.xml
<!-- ~ Copyright 2011 JBoss, by Red Hat, Inc ~ ~ Licensed under the Apache License, Version 2.0 (the "License"); 
  ~ you may not use this file except in compliance with the License. ~ You may obtain a copy of the License at ~ 
  ~ http://www.apache.org/licenses/LICENSE-2.0 ~ ~ Unless required by applicable law or agreed to in writing, software 
  ~ distributed under the License is distributed on an "AS IS" BASIS, ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, 
  either express or implied. ~ See the License for the specific language governing permissions and ~ limitations 
  under the License. -->
<jboss-deployment-structure>
  <deployment>
    <dependencies>
      <module name="org.slf4j" />
      <module name="org.javassist" />
      <module name="org.jboss.as.naming" />
      <module name="org.jboss.as.server" />
      <module name="org.jboss.msc" />
      <module name="org.jboss.netty" />
      <module name="org.picketbox" />
      <module name="org.picketlink" />
      <module name="org.jboss.resteasy.resteasy-jaxrs" />
      <module name="org.overlord.commons.overlord-commons-auth" />
      <module name="org.apache.httpcomponents" />
      <module name="org.apache.commons.codec" />
      <module name="org.apache.commons.configuration" />
      <module name="org.apache.commons.lang" />
      <module name="org.switchyard.component.bpel" />
    </dependencies>
  </deployment>
</jboss-deployment-structure>

Comment 10 Eric Wittmann 2014-01-08 16:41:11 UTC
This looks right to me.


Note You need to log in before you can comment on or make changes to this bug.