Bug 1036906 - Cannot view translated revision history topics
Summary: Cannot view translated revision history topics
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: PressGang CCMS
Classification: Community
Component: Web-UI
Version: 1.2
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 1.3
Assignee: Lee Newson
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-12-02 21:31 UTC by Matthew Casperson
Modified: 2014-08-04 22:27 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-12-03 22:16:01 UTC

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Comment 1 Lee Newson 2013-12-02 22:36:15 UTC 
Just adding this appears to be a Firefox only issue as I can't reproduce it in Chrome.

For reference this is the error message:

Uncaught exception was detected. Redirecting you to the home page.
Exception: (TypeError) : d is null
Comment 2 Lee Newson 2013-12-02 23:19:34 UTC 
Fixed in 1.3-SNAPSHOT build 201312030913

The problem was that the additional xml being sent to be parsed was null and the Firefox parser implementation crashes when you do that. As such I've made two changes: 

1. The additional xml won't be processed if it is null or empty.
2. The convertStringToDocument method will now check if the xml value parsed is null and handle it accordingly.
Comment 3 Matthew Casperson 2013-12-03 02:34:46 UTC 
Confirmed the fix.
Note You need to log in before you can comment on or make changes to this bug.