Bug 1036944 - Review Request: rubygem-dependor - Simplify dependency injection in Ruby
Summary: Review Request: rubygem-dependor - Simplify dependency injection in Ruby
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-12-02 23:21 UTC by Ken Dreyer
Modified: 2013-12-24 05:36 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-12-24 05:36:43 UTC
Type: ---
mtasaka: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Ken Dreyer 2013-12-02 23:21:45 UTC 
Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-dependor.spec
SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-dependor-1.0.1-1.fc21.src.rpm
Description:
Dependor is not a framework for Dependency Injection, but something that
reduces duplication a little bit when doing manual dependency injection in
settings like Rails apps.
Fedora Account System Username: ktdreyer

F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6249363
Comment 1 Mamoru TASAKA 2013-12-12 05:19:21 UTC 
I will take this.

I would appreciate it if you would review my review request (bug 1040767)
Comment 2 Mamoru TASAKA 2013-12-15 12:50:20 UTC 
Okay, very simple package.

* spec file clean
* builds file
* can be installed
* At least the following works:

$ ruby -e "require 'dependor' ; puts Dependor::VERSION"
1.0.1

------------------------------------------------------
    This package (rubygem-dependor) is APPROVED
    by mtasaka
------------------------------------------------------
Comment 3 Ken Dreyer 2013-12-15 17:02:05 UTC 
New Package SCM Request
=======================
Package Name: rubygem-dependor
Short Description: Simplify dependency injection in Ruby
Owners: ktdreyer
Branches: f20
Comment 4 Gwyn Ciesla 2013-12-16 13:29:43 UTC 
Git done (by process-git-requests).
Comment 5 Ken Dreyer 2013-12-24 05:36:43 UTC 
Thank you for the review. I've built the package for Rawhide; closing.

F21 build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6330780
Note You need to log in before you can comment on or make changes to this bug.