Hide Forgot
Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-resque-cleaner.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-resque-cleaner-0.2.11-1.fc21.src.rpm Description: resque-cleaner maintains the cleanliness of failed jobs on Resque. Fedora Account System Username: ktdreyer F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6250270
Upstream released a new version. Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-resque-cleaner.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-resque-cleaner-0.2.12-1.fc21.src.rpm * Fri Dec 27 2013 Ken Dreyer <ktdreyer> - 0.2.12-1 - Update to 0.2.12 F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6335143
Upstream released a new version. * Tue May 27 2014 Ken Dreyer <ktdreyer> - 0.3.0-1 - Update to 0.3.0 - Adjustments for https://fedoraproject.org/wiki/Changes/Ruby_2.1 - Patch for Minitest 5 Exact changes in Git: http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-resque-cleaner.git/commit/?id=d8dd7500ea2c49b717ffc91d27b49331fa6d69d0 Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-resque-cleaner.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-resque-cleaner-0.3.0-1.fc21.src.rpm F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6899415
Taking. Instread I would appreciate it if you would review my rubygem-minitest4 review request (bug 1106324) as we currently have lots of FTBFS packages...
For 0.3.0-1: The blocker is "Test suite on armv7hl" only * %license - INFO: Now it "is advised" (NOT MUST be) to use %license for license text: https://fedorahosted.org/fpc/ticket/411 https://lists.fedoraproject.org/pipermail/packaging/2014-May/010157.html * Test suite on armv7hl - By the way, test suite seems to hang on armv7hl, would you check this? (Note that this srpm is for noarch, however on scratch build you can choose builder arch by $ koji build --scratch --arch-override=armv7hl f21 foo.src.rpm for example) i686: http://koji.fedoraproject.org/koji/taskinfo?taskID=7024258 x86_64: http://koji.fedoraproject.org/koji/taskinfo?taskID=7024268 armv7hl: http://koji.fedoraproject.org/koji/taskinfo?taskID=7024307
(Note that for "non-scratch" build, builder arch is chosen randomly for noarch srpm, so currently the test suite may or may not hang)
Thanks for the review. I don't know what's going on with Redis on ARM, but I just hit an identical bug when I tried to build redis-namespace: http://koji.fedoraproject.org/koji/taskinfo?taskID=7036200 I'm going to try to get some ARM folks to look at this.
Emailed the arm list: https://lists.fedoraproject.org/pipermail/arm/2014-June/007864.html
The Redis package has been updated and I think this must've fixed the bug with redis-server on ARM. I've updated rubygem-resque-cleaner package to avoid the "ps: command not found" error during %check. * Sat Jul 12 2014 Ken Dreyer <ktdreyer> - 0.3.0-2 - Add BR: procps-ng, since test suite uses "ps" to get Redis PID Exact changes in Git: http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-resque-cleaner.git/commit/?id=1beea32362778b5b32020c9ca7ad8e9abe0a7ce3 If it's ok with you I'd like to avoid %license until the last Fedora release that doesn't support %license (Fedora 20) is EOL, but I will be sure to adjust all my packages after that. Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-resque-cleaner.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-resque-cleaner-0.3.0-2.fc22.src.rpm F22 scratch build (using your recommended koji command to land on an ARM builder): http://koji.fedoraproject.org/koji/taskinfo?taskID=7132880
Sorry for delay, Ah, I didn't notice that "BR: procps" fixes test suite hang on arm. Now: ----------------------------------------------------------- This package (rubygem-resque-cleaner) is APPOVED by mtasaka -----------------------------------------------------------
Thanks very much for the review! New Package SCM Request ======================= Package Name: rubygem-resque-cleaner Short Description: Resque plugin to clean up failed jobs Upstream URL: https://github.com/ono/resque-cleaner Owners: ktdreyer Branches: f20 f21
Git done (by process-git-requests).
rubygem-resque-cleaner-0.3.0-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/rubygem-resque-cleaner-0.3.0-3.fc21
rubygem-resque-cleaner-0.3.0-3.fc21 has been pushed to the Fedora 21 testing repository.
rubygem-resque-cleaner-0.3.0-3.fc21 has been pushed to the Fedora 21 stable repository.