Bug 1039682 - The Deploy REST operations accept a different range of strings for the deployment Id than the other REST operations
Summary: The Deploy REST operations accept a different range of strings for the deploy...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss BPMS Platform 6
Classification: Retired
Component: Business Central
Version: 6.0.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ER6
: 6.0.0
Assignee: Marco Rietveld
QA Contact: Ivo Bek
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-12-09 18:40 UTC by Marco Rietveld
Modified: 2016-09-20 05:05 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-08-06 20:09:53 UTC
Type: Bug


Attachments (Terms of Use)

Description Marco Rietveld 2013-12-09 18:40:03 UTC
Description of problem:

The REST deployment operations currently use the following regex for the deployment Id: 

[^\\s:]+(:[^\\s:]+){2,2}(:[^\\s:]*){0,2}

The other REST operations currently use the following regex for the deployment Id:

[a-zA-Z0-9-:\\.]+

This means that users might be able to deploy a deployment with a deployment id that they would not be able to use in other REST operations. 

Furthermore the use of \\s (all non-whitespaces characters) could cause crashes or possible security problems. 

For both of the reasons above, we should change the regex used in both places to this: 

https://github.com/droolsjbpm/droolsjbpm-integration/commit/86b6d61d16db50165a55f933b24b1e5a336a47a2


This fix has already been committed to master. This bug is to ensure that it also gets added to the product branch.

Comment 2 Marco Rietveld 2013-12-09 18:42:38 UTC
Ahh, the regex that should be used is this: 

[\\w\\.-]+(:[\\w\\.-]+){2,2}(:[\\w\\.-]*){0,2}

Comment 4 Ivo Bek 2014-01-10 09:20:16 UTC
Verified in BPMS 6.0.0.ER7


Note You need to log in before you can comment on or make changes to this bug.