Hide Forgot
Description of problem: ====================== 1) Creating CG with no CG name provided fails with "Invalid snap name arguments" 2) Creating a CG with more than one CG name or CG description provided fails with the following message : snapshot create: failed: Invalid snap name arguments 3)Creating a CG with description , but -d option not specified fails with error: snapshot create: failed: Pre-validation failed on localhost. Please check log file for details Version-Release number of selected component (if applicable): ============================================================= glusterfs 3.4.0.snap.dec03.2013git How reproducible: ================ always Steps to Reproduce: ================== 1.Create 2 volumes and start it 2. Create CG with no name provided : gluster snapshot create volume2 volume3 -n snapshot create: failed: Invalid snap name arguments Usage: snapshot create <volnames> [-n <snap-name|cg-name>] [-d <description>] It should fail with "Invalid CG name arguments" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 3.Create a CG with more than one CG name or description provided gluster snapshot create volume2 volume3 -n CG8 CG9 snapshot create: failed: Invalid snap name arguments Usage: snapshot create <volnames> [-n <snap-name|cg-name>] [-d <description>] gluster snapshot create volume2 volume3 -n CG8 "new CG" "new CG" snapshot create: failed: Invalid snap name arguments Usage: snapshot create <volnames> [-n <snap-name|cg-name>] [-d <description>] It would be better if we could provide a clearer message stating that more than one CG name or CG description was provided and hence the command failed as below: gluster snapshot create volume2 volume3 -n CG8 CG9 snapshot create: failed: More than one CG name provided Usage: snapshot create <volnames> [-n <snap-name|cg-name>] [-d <description>] gluster snapshot create volume2 volume3 -n CG8 "new CG" "new CG" snapshot create: failed: More than one description provided Usage: snapshot create <volnames> [-n <snap-name|cg-name>] [-d <description>] ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 4.Create a CG with description , but -d option not specified gluster snapshot create volume2 volume3 "description" snapshot create: failed: Pre-validation failed on localhost. Please check log file for details Snapshot command failed "Invalid CG name arguments" along with the usage should be displayed ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Actual results: Expected results: Additional info:
More Invalid Scenarios : ====================== 5) Create a CG with -N option gluster snapshot create volume2 volume3 -N CG8 snapshot create: failed: Pre-validation failed on localhost. Please check log file for details Snapshot command failed "Invalid CG name arguments" along with the usage should be displayed ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 6) Create CG with Invalid volume name gluster snapshot create -volume2 -volume3 -n CG8 snapshot create: failed: Pre-validation failed on localhost. Please check log file for details Snapshot command failed snapshot create: failed: Invalid volume name along with usage should be displayed ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 7) Creating a CG of volume when the volume is offline gluster snapshot create volume2 volume3 -n CG9 snapshot create: failed: Pre-validation failed on localhost. Please check log file for details Snapshot command failed snapshot create: failed: Volume is offline along with usage should be displayed ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 8) Create a CG with -n as the CG name gluster snapshot create volume3 volume2 -n "-n" snapshot create: failed: Options(-n/-d) are not valid snap names Usage: snapshot create <volnames> [-n <snap-name|cg-name>] [-d <description>] snapshot create: failed: Options(-n/-d) are not valid CG names should be displayed along with the usage ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
similar changes would require in case of snap creation one such instance is: [root@snapshot-09 ~]# gluster snapshot create vol-snap0 -N snap1 snapshot create: failed: Pre-validation failed on localhost. Please check log file for details Snapshot command failed [root@snapshot-09 ~]#
CG functionality is dropped from the requirement list.
Version : glusterfs 3.4.1.2.snap.mar11.2014git Invalid Scenarios : ================= 1) No snap name provided while creating snapshot gives Usage as shown below. It would be better if we could also give a message "Please provide snap name" along with the Usage gluster snapshot create vol0 Usage: snapshot create <snapname> <volname(s)> [description <description>] [force] 2) gluster snapshot create "snap2 snap3" vol0 snapshot create: failed: Commit failed on localhost. Please check log file for details. Snapshot command failed We could mention Invalid Arguments along with usage in this scenario instead of mentioning "Commit failed" 3)Creating snapshot with more than 1 description gluster snapshot create snap3 vol0 description "%^*&" "abcd" Usage: snapshot create <snapname> <volname(s)> [description <description>] [force] Give a valid message along with the Usage 4)Creating snapshot without description gluster snapshot create snap4 vol1 description Usage: snapshot create <snapname> <volname(s)> [description <description>] [force] gluster snapshot create snap5 vol1 "description" Usage: snapshot create <snapname> <volname(s)> [description <description>] [force] Provide a message such as "Please provide description" along with the usage
Fix for this can be found in http://review.gluster.org/#/c/7324/
Giving devel ack to snapshot bugz
Version : glusterfs 3.4.1.7.snap.mar27.2014 ======= [root@snapshot-01 ~]# gluster snapshot create vol0 Invalid Syntax. Usage: snapshot create <snapname> <volname(s)> [description <description>] [force] [root@snapshot-01 ~]# gluster snapshot create "snap2 snap3" vol0 Please provide a valid snapname Usage: snapshot create <snapname> <volname(s)> [description <description>] [force] [root@snapshot-01 ~]# gluster snapshot create snap3 vol0 description "%^*&" "abcd" Invalid Syntax. Usage: snapshot create <snapname> <volname(s)> [description <description>] [force] [root@snapshot-01 ~]# gluster snapshot create snap4 vol1 description Please provide a description Usage: snapshot create <snapname> <volname(s)> [description <description>] [force] [root@snapshot-01 ~]# gluster snapshot create snap5 vol1 "description" Please provide a description Usage: snapshot create <snapname> <volname(s)> [description <description>] [force] Marking the bug as 'Verified'
Marking snapshot BZs to RHS 3.0.
Setting flags required to add BZs to RHS 3.0 Errata
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHEA-2014-1278.html