Bug 1041650 - 4.6 oo-install valid values for --workflow not discoverable unless run with invalid value
Summary: 4.6 oo-install valid values for --workflow not discoverable unless run with i...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Installer
Version: 2.0.0
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: ---
: ---
Assignee: N. Harrison Ripps
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-12-12 18:29 UTC by Aaron Weitekamp
Modified: 2017-03-08 17:38 UTC (History)
6 users (show)

Fixed In Version: oo-install-ose-20140602-1425
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-06-02 15:56:57 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description Aaron Weitekamp 2013-12-12 18:29:28 UTC
Description of problem:
--workflow WORKFLOW_ID sounds like a useful option but valid values are not documented. The help does not provide a list of valid values unless the tool is blindly run with an invalid workflow_id 

Version-Release number of selected component (if applicable):
2.0

Actual results:

INVALID VALUE:

[root@broker1 broker]#  sh <(curl -s https://install.openshift.com/ose/) --workflow asdf
Checking for necessary tools...
...looks good.
Downloading oo-install package...
Extracting oo-install to temporary directory...
Starting oo-install...
Unknown workflow ID 'asdf'. Valid values are:

* enterprise_add_node
* enterprise_deploy
* origin_add_node
* origin_deploy
* origin_deploy
* puppet_template
* vm_tutorial
* vm_view_console

Exiting.
oo-install exited; removing temporary assets.

Comment 2 Luke Meyer 2013-12-12 20:59:38 UTC
Good point. Most of those workflows are irrelevant to OSE too. In fact, I think it may make the most sense to have the OSE docs on this just list the option as "--workflow enterprise_deploy" (basically, deploy what you've already configured without bothering with the dialog -- useful for when something goes wrong and you want to just run it again).

The issue of what to put on install.openshift.com and in the -h output is separate and a little more complex.

Comment 3 N. Harrison Ripps 2013-12-12 22:08:17 UTC
This isn't a documentation error; it is a utility error. I will take ownership and update the oo-install code to provide a list of valid workflow IDs when the --help flag is passed to oo-install.

The reason it can't be a doc fix is that the workflow IDs vary according to the context (Origin/OSE/Origin VM)

Comment 5 Jason DeTiberus 2014-05-13 18:01:08 UTC
Harrison added a -l/--list-workflows flag upstream that we pulled in with the 2.1 changes.

To verify run the following command:
sh <(curl -s https://oo-jdetiber1.rhcloud.com/ose) -l

Comment 6 Anping Li 2014-05-14 08:00:45 UTC
The valid Workflow shouldn't include 'origin IDs'.  and the list-workflows works well.

root@br3 ~]# sh <(curl -s https://install.openshift.com/ose) -w invalidValues
Checking for necessary tools...
...looks good.
Downloading oo-install package...
Extracting oo-install to temporary directory...
Starting oo-install...
Unknown workflow ID 'abc'. Valid values are:

* enterprise_add_node
* enterprise_deploy
* origin_add_node
* origin_deploy
* origin_deploy
* puppet_template
* vm_tutorial
* vm_view_console

Exiting.
oo-install exited; removing temporary assets.

[anli@anli ~]$ sh <(curl -s https://oo-jdetiber1.rhcloud.com/ose) --list-workflows
<snip-->
The workflow IDs available for use with the '-w' setting are as follows:

enterprise_add_node
If you have already deployed an OpenShift Enterprise 2.1 system, use
this option to add a new Node host to the existing system.

enterprise_deploy
If you currently have no OpenShift Enterprise 2.1 system, select this
option to deploy OpenShift Enterprise to one or more target hosts.

Comment 8 Anping Li 2014-05-22 03:28:14 UTC
Verified and pass 

[hanli1@br151 ~]$ sh <(curl -s https://oo-jdetiber1.rhcloud.com/ose) -l
Checking for necessary tools...
...looks good.
Downloading oo-install package...
Extracting oo-install to temporary directory...
Starting oo-install...

The workflow IDs available for use with the '-w' setting are as follows:

enterprise_add_node
If you have already deployed an OpenShift Enterprise 2.1 system, use
this option to add a new Node host to the existing system.


enterprise_deploy
If you currently have no OpenShift Enterprise 2.1 system, select this
option to deploy OpenShift Enterprise to one or more target hosts.


oo-install exited; removing temporary assets.


[hanli1@br151 ~]$ sh <(curl -s https://oo-jdetiber1.rhcloud.com/ose) -w invalidValues
Checking for necessary tools...
...looks good.
Downloading oo-install package...
Extracting oo-install to temporary directory...
Starting oo-install...
Unknown workflow ID 'invalidValues'. Valid values are:

* enterprise_add_node
* enterprise_deploy

Exiting.
oo-install exited; removing temporary assets.

Comment 9 Jason DeTiberus 2014-06-02 15:56:57 UTC
This was deployed to install.openshift.com this morning.


Note You need to log in before you can comment on or make changes to this bug.