Bug 1041650
| Summary: | 4.6 oo-install valid values for --workflow not discoverable unless run with invalid value | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Aaron Weitekamp <aweiteka> |
| Component: | Installer | Assignee: | N. Harrison Ripps <hripps> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | low | Docs Contact: | |
| Priority: | medium | ||
| Version: | 2.0.0 | CC: | anli, bleanhar, hripps, jdetiber, libra-bugs, libra-onpremise-devel |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | oo-install-ose-20140602-1425 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-06-02 15:56:57 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Aaron Weitekamp
2013-12-12 18:29:28 UTC
Good point. Most of those workflows are irrelevant to OSE too. In fact, I think it may make the most sense to have the OSE docs on this just list the option as "--workflow enterprise_deploy" (basically, deploy what you've already configured without bothering with the dialog -- useful for when something goes wrong and you want to just run it again). The issue of what to put on install.openshift.com and in the -h output is separate and a little more complex. This isn't a documentation error; it is a utility error. I will take ownership and update the oo-install code to provide a list of valid workflow IDs when the --help flag is passed to oo-install. The reason it can't be a doc fix is that the workflow IDs vary according to the context (Origin/OSE/Origin VM) Harrison added a -l/--list-workflows flag upstream that we pulled in with the 2.1 changes. To verify run the following command: sh <(curl -s https://oo-jdetiber1.rhcloud.com/ose) -l The valid Workflow shouldn't include 'origin IDs'. and the list-workflows works well. root@br3 ~]# sh <(curl -s https://install.openshift.com/ose) -w invalidValues Checking for necessary tools... ...looks good. Downloading oo-install package... Extracting oo-install to temporary directory... Starting oo-install... Unknown workflow ID 'abc'. Valid values are: * enterprise_add_node * enterprise_deploy * origin_add_node * origin_deploy * origin_deploy * puppet_template * vm_tutorial * vm_view_console Exiting. oo-install exited; removing temporary assets. [anli@anli ~]$ sh <(curl -s https://oo-jdetiber1.rhcloud.com/ose) --list-workflows <snip--> The workflow IDs available for use with the '-w' setting are as follows: enterprise_add_node If you have already deployed an OpenShift Enterprise 2.1 system, use this option to add a new Node host to the existing system. enterprise_deploy If you currently have no OpenShift Enterprise 2.1 system, select this option to deploy OpenShift Enterprise to one or more target hosts. Verified and pass [hanli1@br151 ~]$ sh <(curl -s https://oo-jdetiber1.rhcloud.com/ose) -l Checking for necessary tools... ...looks good. Downloading oo-install package... Extracting oo-install to temporary directory... Starting oo-install... The workflow IDs available for use with the '-w' setting are as follows: enterprise_add_node If you have already deployed an OpenShift Enterprise 2.1 system, use this option to add a new Node host to the existing system. enterprise_deploy If you currently have no OpenShift Enterprise 2.1 system, select this option to deploy OpenShift Enterprise to one or more target hosts. oo-install exited; removing temporary assets. [hanli1@br151 ~]$ sh <(curl -s https://oo-jdetiber1.rhcloud.com/ose) -w invalidValues Checking for necessary tools... ...looks good. Downloading oo-install package... Extracting oo-install to temporary directory... Starting oo-install... Unknown workflow ID 'invalidValues'. Valid values are: * enterprise_add_node * enterprise_deploy Exiting. oo-install exited; removing temporary assets. This was deployed to install.openshift.com this morning. |