Bug 1041722 - [RFE][cinder]: Cinder monkey patching review
Summary: [RFE][cinder]: Cinder monkey patching review
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: RFEs
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: ---
Assignee: RHOS Maint
QA Contact:
URL: https://blueprints.launchpad.net/cind...
Whiteboard: upstream_milestone_none upstream_stat...
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-12-12 18:49 UTC by RHOS Integration
Modified: 2015-11-20 19:56 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-03-19 16:53:04 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description RHOS Integration 2013-12-12 18:49:29 UTC
Cloned from launchpad blueprint https://blueprints.launchpad.net/cinder/+spec/safer-monkey-patching-for-a-safer-planet.

Description:

Several cinder services do eventlet.monkey_patch() i.e. monkey patch everything that has an eventlet alternative. We should really consider a more conservative approach to doing this for the following reasons:

1. monkey patching everything increases the likelihood of unexpected results since you are using eventlet alternatives to modules which may not behave the same.
2. monkey patching everything is normally restricted to testing
3. other openstack services e.g. Glance use a whitelist approach so they know exactly what modules are being monkey patched thus making it easier to target tessts.
4. patching everyting makes it harder if you want to use a non-patched/original module

Specification URL (additional information):

None


Note You need to log in before you can comment on or make changes to this bug.