Bug 1042216 - [RFE][heat]: Reduce number of flake/pep8 ignored rules.
Summary: [RFE][heat]: Reduce number of flake/pep8 ignored rules.
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: RFEs
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: Upstream M3
: ---
Assignee: RHOS Maint
QA Contact:
URL: https://blueprints.launchpad.net/heat...
Whiteboard: upstream_milestone_next upstream_stat...
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-12-12 21:23 UTC by RHOS Integration
Modified: 2015-03-19 16:54 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-03-19 16:54:53 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description RHOS Integration 2013-12-12 21:23:30 UTC
Cloned from launchpad blueprint https://blueprints.launchpad.net/heat/+spec/reduce-flake8-ignored-rules.

Description:

Heat tox.ini has several ignored flake/pep8 rules. To make code more clean would be better to reduce it's numbers
 F841 local variable 'json_template' is assigned to but never used
 H201 no 'except:' at least use 'except Exception:'
 H302 import only modules.'bla..' does not import a module
 H306 imports not in alphabetical order
 H404 multi line docstring should start with a summary

First step - H201:
heat/db/sqlalchemy/migrate_repo/versions/015_grizzly.py:157:15: H201  no 'except:' at least use 'except Exception:'
        except:
              ^
heat/db/sqlalchemy/migrate_repo/versions/018_resource_id_uuid.py:35:11: H201  no 'except:' at least use 'except Exception:'
    except:
          ^
heat/engine/resource.py:414:15: H201  no 'except:' at least use 'except Exception:'
        except:
              ^
heat/engine/resource.py:638:15: H201  no 'except:' at least use 'except Exception:'
        except:
              ^
heat/engine/scheduler.py:242:31: H201  no 'except:' at least use 'except Exception:'
                        except:
                              ^
heat/engine/scheduler.py:257:19: H201  no 'except:' at least use 'except Exception:'
            except:
                  ^
heat/engine/scheduler.py:305:15: H201  no 'except:' at least use 'except Exception:'
        except:
              ^
heat/engine/scheduler.py:419:15: H201  no 'except:' at least use 'except Exception:'
        except:
              ^
heat/tests/test_engine_service.py:223:19: H201  no 'except:' at least use 'except Exception:'
            except:
                  ^
heat/tests/utils.py:69:15: H201  no 'except:' at least use 'except Exception:'
        except:
              ^
heat/tests/utils.py:107:15: H201  no 'except:' at least use 'except Exception:'
        except:


Specification URL (additional information):

None


Note You need to log in before you can comment on or make changes to this bug.