Bug 1042511 - Guided Editor - adding method calls to consequence of a rule does not persist change
Summary: Guided Editor - adding method calls to consequence of a rule does not persist...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss BRMS Platform 6
Classification: Retired
Component: Business Central
Version: 6.0.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: CR1
: 6.0.0
Assignee: Toni Rikkola
QA Contact: Tomas David
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-12-12 23:11 UTC by Tihomir Surdilovic
Modified: 2014-08-06 20:16 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-08-06 20:16:00 UTC
Type: Bug

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1042836 0 unspecified CLOSED Guided rule editor should show a selector for literal or bound variable when a method call is used 2021-02-22 00:41:40 UTC

Internal Links: 1042836

Description Tihomir Surdilovic 2013-12-12 23:11:49 UTC 
Guided Rule editor - after adding a method (with parameters with literal and bind values) are not persisted (dissapear) after saving the asset.
Comment 2 Lukáš Petrovický 2013-12-13 08:07:49 UTC 
This is a BRMS bug, moving.
Comment 4 Toni Rikkola 2013-12-13 14:06:08 UTC 
Literal should be fixed by this.
https://bugzilla.redhat.com/show_bug.cgi?id=1039639
Comment 5 Edson Tirelli 2013-12-18 20:13:22 UTC 
Toni, if this is fixed, I am setting the ticket to MODIFIED for QA to pick it up.
Comment 6 Edson Tirelli 2013-12-19 01:01:12 UTC 
Toni, I just checked and the problem still exists. See my e-mail, I believe the problem is that the widget is populating the method name attribute with the wrong string, i.e., with the paramenters, instead of just the method name:

method( X, Y )

instead of:

method

This code here looks suspicious:

https://github.com/droolsjbpm/drools-wb/blob/master/drools-wb-screens/drools-wb-guided-rule-editor/drools-wb-guided-rule-editor-client/src/main/java/org/drools/workbench/screens/guided/rule/client/widget/ActionCallMethodWidget.java#L239
Comment 7 Toni Rikkola 2013-12-19 08:29:39 UTC 
Looks like the commit only fixes the issue when we are loading the rule. If the method call is added in the editor it breaks.
Comment 8 Toni Rikkola 2013-12-19 09:18:22 UTC 
First set of commits:

Master:
https://github.com/droolsjbpm/kie-wb-common/commit/38abd5995
https://github.com/droolsjbpm/drools-wb/commit/6f6e1d199

6.0.x:
https://github.com/droolsjbpm/kie-wb-common/commit/fcbfb00ac
https://github.com/droolsjbpm/drools-wb/commit/e1df9230d
Comment 10 Tomas David 2014-01-27 13:35:30 UTC 
Verified on BRMS 6.0.0.CR2.
Note You need to log in before you can comment on or make changes to this bug.