Bug 1042711 - Replace the probamatic dependency jsr94-tck 1.0.3 in drools
Summary: Replace the probamatic dependency jsr94-tck 1.0.3 in drools
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss BRMS Platform 6
Classification: Retired
Component: Build and Assembly
Version: 6.0.0
Hardware: Unspecified
OS: Unspecified
high
unspecified
Target Milestone: CR1
: 6.0.0
Assignee: Geoffrey De Smet
QA Contact: Lukáš Petrovický
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-12-13 07:42 UTC by Ryan Zhang
Modified: 2014-08-06 20:18 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-08-06 20:18:50 UTC
Type: Bug


Attachments (Terms of Use)

Description Ryan Zhang 2013-12-13 07:42:47 UTC
Description of problem:
There is a dependency defined in drools jsr94 modules: jsr94:jsr94-tck:jar:1.0.3 
,which is problematic and stop productization build the drools module.
Please see: https://repository.jboss.org/nexus/content/groups/public-jboss/jsr94/jsr94-tck/1.0.3/jsr94-tck-1.0.3.pom

The groupdId in pom.xml show:jsr94-tck, however the maven repository show the groupId as jsr94.
This make MEAD not possible import this artifact and depend on it.

The suggestion is to update this artifact to a correct one.



Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 4 Geoffrey De Smet 2014-01-06 19:11:37 UTC
Looks like there are no newer versions of jsr94-tck jars available on the maven repo:
  https://repository.jboss.org/nexus/index.html#nexus-search;quick~jsr94

So simply upgrading the jar doesn't seem to be possible.

Comment 5 Ryan Zhang 2014-01-07 08:50:52 UTC
Is it possible to deploy a new jsr94 artifact by maven deploy:deploy-file?
To deploy it as groupId:artifact:version as jsr94-tck:jsr94-tck:1.0.3.

See http://maven.apache.org/guides/mini/guide-3rd-party-jars-remote.html
(In reply to Geoffrey De Smet from comment #4)
> Looks like there are no newer versions of jsr94-tck jars available on the
> maven repo:
>   https://repository.jboss.org/nexus/index.html#nexus-search;quick~jsr94
> 
> So simply upgrading the jar doesn't seem to be possible.

Comment 6 Geoffrey De Smet 2014-01-08 07:45:57 UTC
Fixed by taking jsr94-tck 1.0.3 and creating 1.0.3.1 with a fixed pom. Note: the jsr94 jars are from 2004 and jsr94 is dead. The version numbers of the jsr94 poms we're using are suspicious (to say the least as the last release was 1.0). Long term we might want to consider dropping jsr94 support altogether to meet our quality standards.


Fixed on master.
Fixed on 6.0.x:
  http://github.com/droolsjbpm/droolsjbpm-build-bootstrap/commit/c98cb9beb

Proposing a pull request on ip-bom to fix it there too.

Comment 7 Geoffrey De Smet 2014-01-08 07:47:02 UTC
@Ryan yes, this is basically what I 've done (but instead of changing the groupId last night, I 've just made it version 1.0.3.1).

Comment 8 Ryan Zhang 2014-01-08 08:11:51 UTC
That sounds fine too, Thanks!
(The reason I suggested changing the groupId only is that artifact has already been imported jck94-tck:jck94-tck:1.0.3 in product env. but I can manage it too since you updated it in a different way.)
(In reply to Geoffrey De Smet from comment #7)
> @Ryan yes, this is basically what I 've done (but instead of changing the
> groupId last night, I 've just made it version 1.0.3.1).

Comment 9 Geoffrey De Smet 2014-01-08 09:30:53 UTC
IP bom pull request:
  https://github.com/jboss-integration/jboss-integration-platform-bom/pull/33

Comment 10 Lukáš Petrovický 2014-01-19 18:16:02 UTC
This change doesn't affect the product. VERIFIED by looking at the commits.


Note You need to log in before you can comment on or make changes to this bug.