Bug 1043099 - Add new autogroup chart to dashboard shows empty chart in dashboard
Summary: Add new autogroup chart to dashboard shows empty chart in dashboard
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Operations Network
Classification: JBoss
Component: UI
Version: JON 3.1.2
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ER04
: JON 3.3.0
Assignee: Jay Shaughnessy
QA Contact: Mike Foley
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-12-13 23:02 UTC by Mike Thompson
Modified: 2014-12-11 14:00 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-12-11 14:00:19 UTC
Type: Bug


Attachments (Terms of Use)

Description Mike Thompson 2013-12-13 23:02:56 UTC
Description of problem:
When adding an autogroup chart to the dashboard from the group resource tree via right click and Measurements -> Add to Dashboard X

Version-Release number of selected component (if applicable):
3.1.2 and current master (presumably 3.2.0)


How reproducible:
Always

Steps to Reproduce:
1. Pull up a resource group detail view
2. right click
3. select Measurements --> Add to Dashboard X
4. Go to that Dashboard

Actual results:
The portlet is added but nothing is shown in the view.
Clicking on configuration only shows groups -- no autogroups to select from.


Expected results:
A graph should be rendered in the portlet


Additional info:
Did this ever work? Are we supposed to be able to do this for autogroups?

Comment 1 Jay Shaughnessy 2014-09-05 03:13:28 UTC
I think this was fixed upstream in Bug 1079225.

Comment 2 Jay Shaughnessy 2014-09-05 14:19:18 UTC
The bug fix above may have been required to make this work, but acouple of things:

- We no longer have that right-click from the menu option.  We add to the dash via the monitoring->graphs subtab

- Although I think we can support autogroup metric charts because they are backed by real groups, I'm not 100% sure we should because the group membership is only updated implicitly, when the user clicks on that node in the tree.

- regardless of whether it would work, the ability to add the graph is broken on the monitoring->graphs for autogroups.

 I'll take a quick  look to see if it's something simple...

Comment 3 Jay Shaughnessy 2014-09-05 18:30:08 UTC
This is true for autoclusters as well.  In short, the ResourceGroupD3GraphPortlet is not EntityContext-aware.  And I'm not really sure it should be.  I think what we should likely do is prevent adding AutoGroup/AutoCluster charts to the dash.  They are really conveniences while navigating a resource or compatGroup tree, respectively.  Their membership is not actively managed.

Moving to ER03 for further consideration, but I think we should take the "AddToDash" widget away from the view for these special groups.

Note, we could support this, but thew work on the portlet is mildly significant.

Comment 5 Jay Shaughnessy 2014-09-16 16:53:58 UTC
For the reasons above I don't think it's a good idea to add autogroup or autocluster charts to the dash.  Removing the option since it never worked anyway.

Comment 6 Jay Shaughnessy 2014-09-16 19:40:38 UTC
master commit afb91cb6f70bd38a6e562da789add0bde3e21cbc
Author: Jay Shaughnessy <jshaughn>
Date:   Tue Sep 16 14:54:49 2014 -0400

    Disable the ability to add Autogroup or Autocluster metric graphs to the
    dashboard.  It doesn't work because the portlets don't support them, and
    these types of implicit groups should not be referenced outside of their
    Tree navigation context. Despite being persisted they are maintained only
    at click-time.

release/jon3.3.x commit b09ff2c85982f11e45283157f1836a25d334617a
Author: Jay Shaughnessy <jshaughn>
Date:   Tue Sep 16 14:54:49 2014 -0400

    (cherry picked from commit afb91cb6f70bd38a6e562da789add0bde3e21cbc)
    Signed-off-by: Jay Shaughnessy <jshaughn>

Comment 7 Simeon Pinder 2014-10-01 21:33:30 UTC
Moving to ON_QA as available for test with build:
https://brewweb.devel.redhat.com/buildinfo?buildID=388959


Note You need to log in before you can comment on or make changes to this bug.