Bug 1043340 - oo-diagnostics gives out a wrong installation command when the oo-admin-yum-validator package is not be installed
Summary: oo-diagnostics gives out a wrong installation command when the oo-admin-yum-v...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Node
Version: 2.0.0
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: ---
Assignee: Luke Meyer
QA Contact: libra bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-12-16 03:27 UTC by Ma xiaoqiang
Modified: 2017-03-08 17:35 UTC (History)
3 users (show)

Fixed In Version: rubygem-openshift-origin-common-1.17.2.5-1.el6op
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-01-17 16:20:37 UTC
Target Upstream Version:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Ma xiaoqiang 2013-12-16 03:27:08 UTC 
Description of problem:
oo-diagnostics gives out a wrong installation command when the oo-admin-yum-validator package is not be installed 

Version-Release number of selected component (if applicable):
rubygem-openshift-origin-common-1.17.2.2-1.el6op.noarch

How reproducible:
always

Steps to Reproduce:
1.setup the testing env with openshift.sh or remove the openshift-enterprise-yum-validator.noarch package on an existing testing env 
2.rum 'oo-diagnostics'
#oo-diagnostics


Actual results:
<--snip-->
WARN: test_yum_configuration
        oo-admin-yum-validator is not installed. Please install with:
          yum install openshift-enterprise-release-2.0
        This tool helps validate and fix your package source
        configuration. Incorrect configuration could lead to
        failure to install the correct RPMs.

The wrong command:yum install openshift-enterprise-release-2.0
When running the command 
#yum install openshift-enterprise-release-2.0
No package openshift-enterprise-release-2.0 available.

Expected results:
oo-diagnostics should give out the correct command.
The correct command: yum install openshift-enterprise-yum-validator.noarch

Additional info:
Comment 2 Luke Meyer 2013-12-16 15:09:09 UTC 
Hm, yeah, good point. I guess it should say
yum install openshift-enterprise-release-2.0.*
or just
yum install openshift-enterprise-release
I think I prefer the former.
Comment 3 Luke Meyer 2013-12-23 17:15:05 UTC 
Next build of rubygem-openshift-origin-common

Changed upstream to just say:
yum install openshift-enterprise-release

After further thought, it doesn't seem like there is much point to making this version-specific for enterprise; whatever version is available in the current channels should be the right one or the issues they see won't be helped by this specific message.

origin-server:
https://github.com/openshift/origin-server/pull/4397
commit 57a925c3d80d7ae779560fd36c85c9886d5b1d76
Author: Luke Meyer <lmeyer>
Date:   Mon Dec 23 12:04:53 2013 -0500

    <oo-diagnostics> OSE version-agnostic - bug 1043340


enterprise-server:
https://github.com/openshift/enterprise-server/pull/177
Comment 4 Ma xiaoqiang 2014-01-02 01:34:08 UTC 
check on puddle [2.0.1/2013-12-31.1]
# oo-diagnostics 
<--snip-->
WARN: test_yum_configuration
        oo-admin-yum-validator is not installed. Please install with:
          yum install openshift-enterprise-release
        This tool helps validate and fix your package source
        configuration. Incorrect configuration could lead to
        failure to install the correct RPMs.
# yum install openshift-enterprise-release
<--snip-->
Installed:
  openshift-enterprise-release.noarch 0:2.0.0c-1.git.34.4185e96.el6op                                                                                   

Dependency Installed:
  openshift-enterprise-yum-validator.noarch 0:2.0.0c-1.git.34.4185e96.el6op                                                                             

Complete!

move it to verify
Note You need to log in before you can comment on or make changes to this bug.