Hide Forgot
Description of problem: virsh command cpu-stats return invalid return code. Version-Release number of selected component (if applicable): libvirt-1.1.1-15.el7.x86_64 How reproducible: 100% Steps to Reproduce: With a running vm test-vm, 1. Call cpu-stats with --start or/and --count option, but without --total option. Like following examples: # virsh cpu-stats test-vm --start 1 2. Check return code. # echo $? Actual results: 1 Expected results: 0
Fixed upstream by: commit 9eb444364e5afca1e02448c48e0cb4ce36bf65db Author: Guannan Ren <gren> CommitDate: 2013-08-27 15:17:03 +0800 virsh: fix return value error of cpu-stats virsh cpu-stats guest --start 0 --count 3 It outputs right but the return value is 1 rather than 0 echo $? 1 Found by running libvirt-autotest ./run -t libvirt --tests virsh_cpu_stats git describe: v1.1.1-232-g9eb4443 contains: v1.1.2-rc1~16
Downstream patch posted: http://post-office.corp.redhat.com/archives/rhvirt-patches/2013-December/msg00562.html
This patch is VERIFIED. Verification steps: # virsh cpu-stats virt-tests-vm1 # echo $? 0 # virsh cpu-stats virt-tests-vm1 --start 1 # echo $? 1 for libvirt-1.1.1-15.el7 0 for libvirt-1.1.1-16.el7 > virsh cpu-stats virt-tests-vm1 --count 1 # echo $? 1 for libvirt-1.1.1-15.el7 0 for libvirt-1.1.1-16.el7 # virsh cpu-stats virt-tests-vm1 --count 1 --total # echo $? 0 # virsh cpu-stats virt-tests-vm1 --start 1 --count 1 --total # echo $? 0 # virsh cpu-stats virt-tests-vm1 --start 1 --count 1 # echo $? 1 for libvirt-1.1.1-15.el7 0 for libvirt-1.1.1-16.el7 And all tests are PASS for virt-test: (1/11) type_specific.virsh.cpu_stats.positive_test.option1: PASS (13.89 s) (2/11) type_specific.virsh.cpu_stats.positive_test.option2: PASS (19.55 s) (3/11) type_specific.virsh.cpu_stats.positive_test.option3: PASS (14.37 s) (4/11) type_specific.virsh.cpu_stats.positive_test.option4: PASS (13.87 s) (5/11) type_specific.virsh.cpu_stats.positive_test.option5: PASS (14.39 s) (6/11) type_specific.virsh.cpu_stats.positive_test.option6: PASS (13.89 s) (7/11) type_specific.virsh.cpu_stats.positive_test.paused_option: PASS (14.37 s) (8/11) type_specific.virsh.cpu_stats.negative_test.no_option: PASS (13.98 s) (9/11) type_specific.virsh.cpu_stats.negative_test.unexpect_option: PASS (14.68 s) (10/11) type_specific.virsh.cpu_stats.negative_test.invalid_option: PASS (14.74 s) (11/11) type_specific.virsh.cpu_stats.negative_test.invalid_start_option: PASS (15.13 s) So this patch is verified.
This request was resolved in Red Hat Enterprise Linux 7.0. Contact your manager or support representative in case you have further questions about the request.