Spec URL: http://in.waw.pl/~zbyszek/fedora/openav-luppp.spec SRPM URL: http://in.waw.pl/~zbyszek/fedora/openav-luppp-1.0-1.fc20.src.rpm Description: Luppp is a music creation tool, intended for live use. It focuses on real time processing and a fast intuitive workflow. It uses Jack for audio output. Fedora Account System Username: zbyszek koji f21: http://koji.fedoraproject.org/koji/taskinfo?taskID=6289683 koji f20: http://koji.fedoraproject.org/koji/taskinfo?taskID=6289682 koji f19: http://koji.fedoraproject.org/koji/taskinfo?taskID=6289684
The Spec URL is broken.
Ooops, fixed. Spec URL: http://in.waw.pl/~zbyszek/fedora/openav-luppp.spec SRPM URL: http://in.waw.pl/~zbyszek/fedora/openav-luppp-1.0-2.fc20.src.rpm
In the meanwhile I've also sent a pull request for .desktop and appdata: https://github.com/harryhaaren/openAV-Luppp/pull/71
Full review below. Issues: - Missing in post and postun: /usr/bin/update-desktop-database &> /dev/null || : - These BR are not needed: gcc-c++ - Must require hicolor-icon-theme - Sould use -p with install to preserve timestamps - Install desktop file via desktop-file-install --dir=%{buildroot}%{_datadir}/applications/ %{SOURCE2} and remove desktop-file-validate call Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "ISC", "MIT/X11 (BSD like)", "*No copyright* GPL (v3 or later)", "Unknown or generated". 12 files have unknown license. Detailed output of licensecheck in /home/sandro/.Data/Desktop/1043573-openav- luppp/licensecheck.txt [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor, /usr/share/icons/hicolor/scalable [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [?]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: openav-luppp-1.0-2.fc21.x86_64.rpm openav-luppp-1.0-2.fc21.src.rpm openav-luppp.x86_64: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce openav-luppp.x86_64: W: no-manual-page-for-binary luppp openav-luppp.src: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce 2 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint openav-luppp openav-luppp.x86_64: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce openav-luppp.x86_64: W: no-manual-page-for-binary luppp 1 packages and 0 specfiles checked; 0 errors, 2 warnings. # echo 'rpmlint-done:' Requires -------- openav-luppp (rpmlib, GLIBC filtered): /bin/sh libc.so.6()(64bit) libcairo.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libjack.so.0()(64bit) liblo.so.7()(64bit) libm.so.6()(64bit) libntk.so.1()(64bit) libpthread.so.0()(64bit) libsamplerate.so.0()(64bit) libsamplerate.so.0(libsamplerate.so.0.0)(64bit) libsndfile.so.1()(64bit) libsndfile.so.1(libsndfile.so.1.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) Provides -------- openav-luppp: application() application(luppp.desktop) openav-luppp openav-luppp(x86-64) Source checksums ---------------- https://github.com/harryhaaren/openAV-Luppp/archive/release-1.0.tar.gz : CHECKSUM(SHA256) this package : e447739f66cbcc98d70b19ad73262b523de95ec4c3009942ba513375fd61d30c CHECKSUM(SHA256) upstream package : e447739f66cbcc98d70b19ad73262b523de95ec4c3009942ba513375fd61d30c Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1043573 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
(In reply to Sandro Mani from comment #4) > Full review below. Issues: > - Missing in post and postun: > /usr/bin/update-desktop-database &> /dev/null || : > - These BR are not needed: gcc-c++ > - Must require hicolor-icon-theme > - Sould use -p with install to preserve timestamps > - Install desktop file via > desktop-file-install --dir=%{buildroot}%{_datadir}/applications/ > %{SOURCE2} > and remove desktop-file-validate call All fixed. Spec URL: http://in.waw.pl/~zbyszek/fedora/openav-luppp.spec SRPM URL: http://in.waw.pl/~zbyszek/fedora/openav-luppp-1.0-3.fc20.src.rpm
All ok, approved!
Thank you for the review! New Package SCM Request ======================= Package Name: openav-luppp Short Description: Live performance mixing tool Owners: zbyszek Branches: f19 f20 InitialCC:
Git done (by process-git-requests).
openav-luppp-1.0-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/openav-luppp-1.0-3.fc20
openav-luppp-1.0-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/openav-luppp-1.0-3.fc19
openav-luppp-1.0-3.fc20 has been pushed to the Fedora 20 testing repository.
openav-luppp-1.0-3.fc20 has been pushed to the Fedora 20 stable repository.
openav-luppp-1.0-3.fc19 has been pushed to the Fedora 19 stable repository.