Hide Forgot
Description of problem: I have been playing around with cppcheck and it seems to indicate several potential issues. please check. note there that cppcheck is capable of doing a lot more extensive checks but more potential for false warnings. I have reported similar issues against systemd and other programs and you might consider adding a build target http://cgit.freedesktop.org/systemd/systemd/commit/?id=16f4efb4150c65e3c61adaa8ea512489de49f532 cppcheck . --std=c99 --quiet [daemon/remote.c:5202]: (error) Possible null pointer dereference: files [daemon/remote.c:5254]: (error) Possible null pointer dereference: files [src/conf/domain_conf.c:4732]: (error) Possible null pointer dereference: seclabels [src/interface/interface_backend_udev.c:846]: (error) Possible null pointer dereference: slave_list [src/interface/interface_backend_udev.c:953]: (error) Possible null pointer dereference: member_list [src/locking/lock_driver_sanlock.c:1022]: (error) Uninitialized variable: res_count [src/network/bridge_driver.c:817]: (error) syntax error [src/nwfilter/nwfilter_ebiptables_driver.c:3962]: (error) Possible null pointer dereference: ebtChains [src/qemu/qemu_driver.c:970]: (error) Possible null pointer dereference: domains [src/storage/storage_backend_mpath.c:242]: (error) Uninitialized variable: next
After a quick run through this list I believe these are all false positives, which isn't entirely surprising since we're already using Coverity to check this on a nightly basis.
Thanks for the quick response