Bug 1045238 - Improve R build
Summary: Improve R build
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: R
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
Assignee: Tom "spot" Callaway
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-12-20 00:19 UTC by Ulrich Drepper
Modified: 2013-12-20 19:40 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-12-20 19:40:17 UTC
Type: Bug


Attachments (Terms of Use)

Description Ulrich Drepper 2013-12-20 00:19:18 UTC
Description of problem:
It's very easy to get a bit more out of the existing R source by adding some more config options.  First, instruct the build to use the system blas.  Less duplication, possibly better implementation.

Second, use LTO.  This compiler feature seems stable not and it does indeed lead to small performance gains.  Not too much but it's measurable.

Version-Release number of selected component (if applicable):
R-3.0.2-1

How reproducible:
N/A

Steps to Reproduce:
1.look at .spec file
2.
3.

Actual results:
Add the patch below.

Expected results:


Additional info:

Use this patch:
--- R.spec-save 2013-12-03 19:30:07.000000000 -0500
+++ R.spec      2013-12-03 19:53:27.000000000 -0500
@@ -303,10 +303,12 @@
 ( %configure \
     --with-system-zlib --with-system-bzlib --with-system-pcre \
     --with-lapack \
+    --with-blas \
     --with-tcl-config=%{_libdir}/tclConfig.sh \
     --with-tk-config=%{_libdir}/tkConfig.sh \
     --enable-R-shlib \
     --enable-prebuilt-html \
+    --enable-lto \
     rdocdir=%{?_pkgdocdir}%{!?_pkgdocdir:%{_docdir}/%{name}-%{version}} \
     rincludedir=%{_includedir}/R \
     rsharedir=%{_datadir}/R) \

Comment 1 Tom "spot" Callaway 2013-12-20 15:47:44 UTC
Sensible. Blas was disabled a long time ago because R upstream felt that using the system copy was buggy, but it seems alright to enable it now. I'll do this in rawhide only for the time being, then enable it everywhere when the next R point release lands.

Thanks for the patch!

Comment 2 Tom "spot" Callaway 2013-12-20 19:40:17 UTC
Applied in R-3.0.2-2.fc21


Note You need to log in before you can comment on or make changes to this bug.