Bug 1046624 - Unable to heal symbolic Links
Summary: Unable to heal symbolic Links
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: replicate
Version: pre-release
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: vsomyaju
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-12-26 11:19 UTC by vsomyaju
Modified: 2015-03-05 00:06 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.5.1beta
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-06-24 11:03:12 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description vsomyaju 2013-12-26 11:19:58 UTC
Description of problem:

Unable to self-heal symbolic links

Version-Release number of selected component (if applicable):
glusterfs 3git built on Dec 26 2013

How reproducible:
always

Steps to Reproduce:
1. Create replicate volume
2. create  a file and directory from mount point
3. Kill one brick
4. Create symbolic link to file and directory
5. Bring back the killed brick up.
6. At mount point execute ls

Actual results:
Symbolic links are not getting healed

Expected results:
Symbolic link should get healed.

Additional info:

Comment 1 Anand Avati 2013-12-26 11:38:26 UTC
REVIEW: http://review.gluster.org/6599 (cluster/afr: Unable to self heal symbolic links) posted (#1) for review on master by venkatesh somyajulu (vsomyaju)

Comment 2 Anand Avati 2013-12-26 11:41:43 UTC
REVIEW: http://review.gluster.org/6600 (cluster/afr: Unable to self heal symbolic links) posted (#1) for review on release-3.5 by venkatesh somyajulu (vsomyaju)

Comment 3 jiademing.dd 2013-12-27 09:48:24 UTC
Are you sure?In glusterfs-3.4.1, I do this case, kill one brick,then link -s dir, restart the brick, heal the symlink by glusterfsd.

Comment 4 Anand Avati 2014-01-02 06:01:36 UTC
REVIEW: http://review.gluster.org/6599 (cluster/afr: Unable to self heal symbolic links) posted (#2) for review on master by venkatesh somyajulu (vsomyaju)

Comment 5 Anand Avati 2014-01-02 06:03:11 UTC
REVIEW: http://review.gluster.org/6600 (cluster/afr: Unable to self heal symbolic links) posted (#2) for review on release-3.5 by venkatesh somyajulu (vsomyaju)

Comment 6 Anand Avati 2014-01-03 10:51:03 UTC
REVIEW: http://review.gluster.org/6599 (cluster/afr: Unable to self heal symbolic links) posted (#5) for review on master by venkatesh somyajulu (vsomyaju)

Comment 7 Anand Avati 2014-01-03 10:52:54 UTC
REVIEW: http://review.gluster.org/6600 (cluster/afr: Unable to self heal symbolic links) posted (#4) for review on release-3.5 by venkatesh somyajulu (vsomyaju)

Comment 8 Anand Avati 2014-01-07 09:28:31 UTC
REVIEW: http://review.gluster.org/6599 (cluster/afr: Unable to self heal symbolic links) posted (#7) for review on master by venkatesh somyajulu (vsomyaju)

Comment 9 Anand Avati 2014-01-14 04:42:17 UTC
COMMIT: http://review.gluster.org/6599 committed in master by Anand Avati (avati) 
------
commit ce86c132347f0a788ab50ffbd6795a2eb982074e
Author: Venkatesh Somyajulu <vsomyaju>
Date:   Fri Jan 3 13:54:25 2014 +0530

    cluster/afr: Unable to self heal symbolic links
    
    Problem:
    Under the entry self heal, readlink is done at the
    source and sink. When readlink is done at the sink,
    because link is not present at the sink, afr expects
    ENOENT. AFR translator takes decisions for new link
    creation based on ENOENT but server translator is modified
    to return ESTALE because of which afr xlator is not able
    to heal.
    
    Fix:
    The check for inode absence at server includes ESTALE as
    well.
    
    Change-Id: I319e4cb4156a243afee79365b7b7a5a7823e9a24
    BUG: 1046624
    Signed-off-by: Venkatesh Somyajulu <vsomyaju>
    Reviewed-on: http://review.gluster.org/6599
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anand Avati <avati>

Comment 10 Anand Avati 2014-05-08 13:31:43 UTC
COMMIT: http://review.gluster.org/6600 committed in release-3.5 by Niels de Vos (ndevos) 
------
commit f46a3198b1a3d794c23b8ac2ab9334326c4918c8
Author: Venkatesh Somyajulu <vsomyaju>
Date:   Fri Jan 3 13:54:25 2014 +0530

    cluster/afr: Unable to self heal symbolic links
    
    Problem:
    Under the entry self heal, readlink is done at the
    source and sink. When readlink is done at the sink,
    because link is not present at the sink, afr expects
    ENOENT. AFR translator takes decisions for new link
    creation based on ENOENT but server translator is modified
    to return ESTALE because of which afr xlator is not able
    to heal.
    
    Fix:
    The check for inode absence at server includes ESTALE as
    well.
    
    Change-Id: I9218da214ed44f7219570ad9dae298d6b5cbded9
    BUG: 1046624
    Signed-off-by: Venkatesh Somyajulu <vsomyaju>
    Reviewed-on: http://review.gluster.org/6600
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>

Comment 11 Niels de Vos 2014-05-25 09:07:03 UTC
The first (and last?) Beta for GlusterFS 3.5.1 has been released [1]. Please verify if the release solves this bug report for you. In case the glusterfs-3.5.1beta release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-May/040377.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 12 Niels de Vos 2014-06-24 11:03:12 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.1, please reopen this bug report.

glusterfs-3.5.1 has been announced on the Gluster Users mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-June/040723.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.