Bug 1048104 - Build with FORTIFY_SOURCE or provide the reason why it is not used
Summary: Build with FORTIFY_SOURCE or provide the reason why it is not used
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: gperftools
Version: 20
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Tom "spot" Callaway
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-01-03 07:57 UTC by Honza Horak
Modified: 2014-01-21 05:50 UTC (History)
2 users (show)

Fixed In Version: gperftools-2.1-4.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-01-21 05:50:38 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Honza Horak 2014-01-03 07:57:41 UTC
Description of problem:
There are the following C(XX)FLAGS definitions in the gperftools.spec:
CFLAGS=`echo $RPM_OPT_FLAGS -fno-strict-aliasing -Wno-unused-local-typedefs -DTCMALLOC_LARGE_PAGES | sed -e 's/-Wp,-D_FORTIFY_SOURCE=2//g' | sed -e 's|-fexceptions||g'`
CXXFLAGS=`echo $RPM_OPT_FLAGS -fno-strict-aliasing -Wno-unused-local-typedefs -DTCMALLOC_LARGE_PAGES | sed -e 's/-Wp,-D_FORTIFY_SOURCE=2//g' | sed -e 's|-fexceptions||g'`

I don't have a clue why the FORTIFY_SOURCE is removed here and don't see it in other RPM packages (openSUSE nor upstream's). Thus, I think it is not necessary and gperftools should be built with FORTIFY_SOURCE. If there was a reason to do so, it should be tracked in some BZ (which I haven't found) or in a comment in spec file.


Version-Release number of selected component (if applicable):
gperftools-2.1-2.fc20.x86_64


Steps to Reproduce:
1. see the gperftools.spec

Actual results:
FORTIFY_SOURCE is disabled, explicitly removed from C(XX)FLAGS

Expected results:
FORTIFY_SOURCE is enabled, not removed from C(XX)FLAGS

Comment 1 Tom "spot" Callaway 2014-01-05 01:50:54 UTC
I don't remember why I did that. Probably needed it to get a previous revision to build at some point. Confirmed that it is no longer necessary, re-enabling it in f20+.

Comment 2 Fedora Update System 2014-01-06 06:32:02 UTC
gperftools-2.1-4.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/gperftools-2.1-4.fc20

Comment 3 Fedora Update System 2014-01-07 09:40:49 UTC
Package gperftools-2.1-4.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing gperftools-2.1-4.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-0303/gperftools-2.1-4.fc20
then log in and leave karma (feedback).

Comment 4 Fedora Update System 2014-01-21 05:50:38 UTC
gperftools-2.1-4.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.