Bug 1048331 - Regression: request['HTTP_X_FORWARDED_PROTO'] not returning?
Summary: Regression: request['HTTP_X_FORWARDED_PROTO'] not returning?
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: OpenShift Online
Classification: Red Hat
Component: Image
Version: 2.x
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: ---
Assignee: Dan Mace
QA Contact: libra bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-01-03 18:20 UTC by Clayton Coleman
Modified: 2015-05-15 00:36 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-01-15 20:26:08 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Clayton Coleman 2014-01-03 18:20:53 UTC
An Origin user reported this issue:

http://stackoverflow.com/questions/20862510/how-to-determine-if-an-incoming-url-request-to-an-openshift-python-3-3-app-is-h/20864649#20864649

It's possible that

a) the library they were using no longer supports direct [] access on the "request" object
b) We stopped sending HTTP_X_FORWARDED_PROTO the same way
c) A change to mod_wsgi changed how these things were set, and that change is
  1) intentional
  2) intentional

Not sure what the cause is - I suspect C), but we need to be sure it was intentional.  If it was intentional, we can simply respond to the stack overflow question.

Comment 1 Dan Mace 2014-01-15 20:26:08 UTC
Using the Python 3 WSGI application interface gives you access to the environment and a response object. The user didn't provide enough information about their http middleware to reproduce their issue. Their library apparently provides to them a request abstraction (and indirectly, access to environment, which according to them contains the header they want).

Any regression would likely be in the library they're using. I verified that in a Python 3 app using the wsgi application interface that the HTTP_X_FORWARDED_PROTO value from environment is correct.

Feel free to re-open the bug if there is concrete evidence of (or a means to reproduce) a platform regression.


Note You need to log in before you can comment on or make changes to this bug.