Bug 1048476 - rpmbuild qemu %bcond_without seccomp still compiles even ..
Summary: rpmbuild qemu %bcond_without seccomp still compiles even ..
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: qemu
Version: 18
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Fedora Virtualization Maintainers
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-01-04 14:01 UTC by lejeczek
Modified: 2014-01-06 17:37 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-01-06 17:37:35 UTC
Type: Bug


Attachments (Terms of Use)

Description lejeczek 2014-01-04 14:01:43 UTC
Description of problem:

..though with

--without seccomp

seems like in dobuild() macro adding this in line 591

%else
        --disable-seccomp \

fixes the problem,
there is probably better way? to fix it, could be that relevant conditional macros' logic is broken? 


Version-Release number of selected component (if applicable):

qemu-1.2.2-14.fc18.src.rpm


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Cole Robinson 2014-01-06 17:37:35 UTC
Despite the use of bcond here, those conditionals weren't really meant for rpmbuild use, more to encode defaults per architecture.

I pushed this to rawhide which should fix the report:

commit e65bbe3b55f554a20718bae27903fd0f85559d4c
Author: Cole Robinson <crobinso@redhat.com>
Date:   Mon Jan 6 12:34:57 2014 -0500

    spec: Fix some --without conditionals (bz 1048476)

diff --git a/qemu.spec b/qemu.spec
index f6c9593..c5bf93a 100644
--- a/qemu.spec
+++ b/qemu.spec
@@ -795,9 +795,13 @@ dobuild() {
         --enable-tpm \
 %if 0%{?have_spice:1}
         --enable-spice \
+%else
+        --disable-spice \
 %endif
 %if 0%{?have_seccomp:1}
         --enable-seccomp \
+%else
+        --disable-seccomp \
 %endif
 %if %{without rbd}
         --disable-rbd \

But a larger cleanup is likely needed to make this stuff more clear. But this bug is pretty minor, and anyone that is motivated to pull down an srpm and pass custom build flags should be able to edit the spec to fit their needs, so just closing as RAWHIDE


Note You need to log in before you can comment on or make changes to this bug.