Bug 1054068 - [0.3.9-1] Broken features in 0.3.9-1 release: Rich rules not working
Summary: [0.3.9-1] Broken features in 0.3.9-1 release: Rich rules not working
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: firewalld
Version: 20
Hardware: noarch
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Thomas Woerner
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1054656 (view as bug list)
Depends On:
Blocks: 1054270
TreeView+ depends on / blocked
 
Reported: 2014-01-16 07:59 UTC by siukoon
Modified: 2014-01-18 04:20 UTC (History)
5 users (show)

Fixed In Version: firewalld-0.3.9.2-1.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1054270 (view as bug list)
Environment:
Last Closed: 2014-01-18 04:20:16 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description siukoon 2014-01-16 07:59:39 UTC
Description of problem:
1. firewalld cannot start after upgrade from 0.3.8-1 to 0.3.9-1
2. Afterwards, server is not accessible remotely.

Version-Release number of selected component (if applicable):
0.3.9-1

How reproducible:
100% 

Steps to Reproduce:
1. yum update, and firewalld is upgrade from 0.3.8-1 to 0.3.9-1 successfully.
2. ssh-telnet remotely failed.  Login console locally.
3. firewall-cmd --reload, error on __rule(), start code review.

Code review findings:
1. In src/firewall/core/fw_zone.py, line 344:
mark = self.__rule(enable, zone, args)
// Seems __rule() requires more argument.  Should it be mark = self.__rule(enable, zone, args, None)?
2. In config/xmlschema/zone.xsd:
<xs:attribute name="family" type="familyrestrict" use="required"/>
has been removed from sourcefamilytype/sourceaddresstype.  However, in src/firewall/core/rich.py, line 415:
function check(self) will check self.family and raise FirewallError(MISSING_FAMILY).  Is it a conflict?

Actual results:
Error: __rule() takes 5 arguments ...

Expected results:
Success

Additional info:

Comment 2 Fedora Update System 2014-01-16 15:32:16 UTC
firewalld-0.3.9.1-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/firewalld-0.3.9.1-1.fc20

Comment 3 siukoon 2014-01-16 17:53:49 UTC
I have just tried the patch.  It works for my use cases.

Comment 4 Jiri Popelka 2014-01-17 08:29:33 UTC
*** Bug 1054656 has been marked as a duplicate of this bug. ***

Comment 5 Tomas Dolezal 2014-01-18 00:40:46 UTC
firewalld-0.3.9.2-1.fc20.noarch

fixed for me: interfaces found and iptables rules are generated again
karma given

Comment 6 Fedora Update System 2014-01-18 04:20:16 UTC
firewalld-0.3.9.2-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.