Spec URL: http://bpepple.fedorapeople.org/rpms/python-django-admin-bootstrapped.spec SRPM URL: http://bpepple.fedorapeople.org/rpms/python-django-admin-bootstrapped-1.6.4-1.fc20.src.rpm Description: A Django admin theme using Twitter Bootstrap. It doesn't need any kind of modification on your side, just add it to the installed apps. Fedora Account System Username: bpepple Scratch Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=6416506
I'm sorry, I'm out of time for now.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Upstream lastest release is now 1.6.8 - Use versioned macros. Change %{__python} to %{__python2} and %{python_sitelib} to %{python2_sitelib}. See: https://fedoraproject.org/wiki/Packaging:Python#Macros - The license needs clarification. In setup.py and PyPI metadata, the license is BSD while LICENSE is a copy of ASL 2.0. - The source tarball timestamps in source RPM are not preserved. See: https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 10 files have unknown license. Detailed output of licensecheck in /home/makerpm/reviews/1054394-python-django-admin- bootstrapped/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python3.4/site-packages, /usr/lib/python3.4 [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.4/site-packages, /usr/lib/python3.4 [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 2 files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3 -django-admin-bootstrapped [x]: Package functions as described. [!]: Latest version is packaged. [!]: Package does not include license text files separate from upstream. -> Ask upstream to include it in PyPI tarball. [!]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. -> Tests require network connectivity [!]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-django-admin-bootstrapped-1.6.4-1.fc22.noarch.rpm python3-django-admin-bootstrapped-1.6.4-1.fc22.noarch.rpm python-django-admin-bootstrapped-1.6.4-1.fc22.src.rpm python-django-admin-bootstrapped.src: W: strange-permission django-admin-bootstrapped-1.6.4.tar.gz 0600L 3 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint python-django-admin-bootstrapped python3-django-admin-bootstrapped 2 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:' Requires -------- python-django-admin-bootstrapped (rpmlib, GLIBC filtered): python(abi) python-django python3-django-admin-bootstrapped (rpmlib, GLIBC filtered): python(abi) Provides -------- python-django-admin-bootstrapped: python-django-admin-bootstrapped python3-django-admin-bootstrapped: python3-django-admin-bootstrapped Source checksums ---------------- https://pypi.python.org/packages/source/d/django-admin-bootstrapped/django-admin-bootstrapped-1.6.4.tar.gz : CHECKSUM(SHA256) this package : e9b92ef9e8b6f6d485c220da8ab865500a663238ff2b511f16047bc6a09939df CHECKSUM(SHA256) upstream package : e9b92ef9e8b6f6d485c220da8ab865500a663238ff2b511f16047bc6a09939df
Macros from http://fedoraproject.org/wiki/Packaging:Python#Macros are quite handy here. Only Fedora has python3, fedora 12 is ancient. IMHO one should write that piece here: %if (0%{?fedora} > 12 || 0%{?rhel} > 5) %global with_python3 1 %else %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print (get_python_lib())")} %endif better: %if %{?fedora} %global with_python3 1 %endif and use the macros from link above: %if 0%{?rhel} && 0%{?rhel} <= 6 %{!?__python2: %global __python2 /usr/bin/python2} %{!?python2_sitelib: %global python2_sitelib %(%{__python2} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")} %{!?python2_sitearch: %global python2_sitearch %(%{__python2} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib(1))")} %endif
tieugene's scratch build of django-autocomplete-light.spec for cli-build/1456332402.93717.hTQzCZRs/django-autocomplete-light.spec and f23 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=13115178
Is this review stale?
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time, but it seems that the review is still being working out by you. If this is right, please respond to this comment clearing the NEEDINFO flag and try to reach out the submitter to proceed with the review. If you're not interested in reviewing this ticket anymore, please clear the fedora-review flag and reset the assignee, so that a new reviewer can take this ticket. Without any reply, this request will shortly be resetted.
This is an automatic action taken by review-stats script. The ticket reviewer failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we reset the status and the assignee of this ticket.
This review request is very old. Do you still intend to complete it? If so, I can review. If not, please close the issue and mark it as FE-DEADREVIEW, or do nothing, in which case automation will close it in one month. Things to fix: Issues reported in earlier comments, update to newest version, reworking python2/3 setup, considering that Fedora is python3 only now.
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.