Bug 1055436 - Review Request: povray - The Persistence of Vision Ray Tracer
Summary: Review Request: povray - The Persistence of Vision Ray Tracer
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Christopher Meng
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-01-20 09:24 UTC by Ralf Corsepius
Modified: 2014-02-06 03:58 UTC (History)
5 users (show)

Fixed In Version: povray-3.7-0.2.20131116git39ce8a2.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-02-06 03:44:46 UTC
Type: ---
Embargoed:
i: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Ralf Corsepius 2014-01-20 09:24:36 UTC
Spec URL: http://corsepiu.fedorapeople.org/packages/povray.spec
SRPM URL: http://corsepiu.fedorapeople.org/packages/povray-3.7-0.1.20131116git39ce8a2.fc21.src.rpm
Description:
POV-Ray is a free, full-featured ray tracer.

Fedora Account System Username: corsepiu

Comment 1 Christopher Meng 2014-01-20 10:41:54 UTC
Damn, just sent email to the team about the packaging, you've done it now:) Empty my trash again. 

Taken.

Comment 2 Christopher Meng 2014-01-24 06:51:14 UTC
DEBUG: Report completed:  4652.393 seconds


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



Issues:
=======
- Large documentation must go in a -doc subpackage. Large could be size (~1MB)
  or number of files.
  Note: Documentation size is 13557760 bytes in 326 files.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "BSD (3 clause)", "AGPL (v3 or later)", "Unknown or generated". 109 files
     have unknown license. Detailed output of licensecheck:

AGPL (v3 or later)
------------------
povray-3.7-stable/source/backend/bounding/bbox.cpp
povray-3.7-stable/source/backend/bounding/bbox.h
povray-3.7-stable/source/backend/bounding/bcyl.cpp
povray-3.7-stable/source/backend/bounding/bcyl.h
povray-3.7-stable/source/backend/bounding/boundingtask.cpp
povray-3.7-stable/source/backend/bounding/boundingtask.h
povray-3.7-stable/source/backend/bounding/bsphere.cpp
povray-3.7-stable/source/backend/bounding/bsphere.h
povray-3.7-stable/source/backend/colour/colour.cpp
povray-3.7-stable/source/backend/colour/colour.h
povray-3.7-stable/source/backend/colour/colutils.cpp
povray-3.7-stable/source/backend/colour/colutils.h
povray-3.7-stable/source/backend/colour/spectral.cpp
povray-3.7-stable/source/backend/colour/spectral.h
povray-3.7-stable/source/backend/configbackend.h
povray-3.7-stable/source/backend/control/benchmark.cpp
povray-3.7-stable/source/backend/control/benchmark.h
povray-3.7-stable/source/backend/control/messagefactory.cpp
povray-3.7-stable/source/backend/control/messagefactory.h
povray-3.7-stable/source/backend/control/renderbackend.cpp
povray-3.7-stable/source/backend/control/renderbackend.h
povray-3.7-stable/source/backend/frame.h
povray-3.7-stable/source/backend/interior/interior.cpp
povray-3.7-stable/source/backend/interior/interior.h
povray-3.7-stable/source/backend/interior/media.cpp
povray-3.7-stable/source/backend/interior/media.h
povray-3.7-stable/source/backend/lighting/photonestimationtask.cpp
povray-3.7-stable/source/backend/lighting/photonestimationtask.h
povray-3.7-stable/source/backend/lighting/photons.cpp
povray-3.7-stable/source/backend/lighting/photons.h
povray-3.7-stable/source/backend/lighting/photonshootingstrategy.cpp
povray-3.7-stable/source/backend/lighting/photonshootingstrategy.h
povray-3.7-stable/source/backend/lighting/photonshootingtask.cpp
povray-3.7-stable/source/backend/lighting/photonshootingtask.h
povray-3.7-stable/source/backend/lighting/photonsortingtask.cpp
povray-3.7-stable/source/backend/lighting/photonsortingtask.h
povray-3.7-stable/source/backend/lighting/photonstrategytask.cpp
povray-3.7-stable/source/backend/lighting/photonstrategytask.h
povray-3.7-stable/source/backend/lighting/point.cpp
povray-3.7-stable/source/backend/lighting/point.h
povray-3.7-stable/source/backend/lighting/rad_data.cpp
povray-3.7-stable/source/backend/lighting/radiosity.cpp
povray-3.7-stable/source/backend/lighting/radiosity.h
povray-3.7-stable/source/backend/lighting/subsurface.cpp
povray-3.7-stable/source/backend/lighting/subsurface.h
povray-3.7-stable/source/backend/math/chi2.h
povray-3.7-stable/source/backend/math/hcmplx.cpp
povray-3.7-stable/source/backend/math/hcmplx.h
povray-3.7-stable/source/backend/math/mathutil.cpp
povray-3.7-stable/source/backend/math/mathutil.h
povray-3.7-stable/source/backend/math/matrices.cpp
povray-3.7-stable/source/backend/math/matrices.h
povray-3.7-stable/source/backend/math/polysolv.cpp
povray-3.7-stable/source/backend/math/polysolv.h
povray-3.7-stable/source/backend/math/quatern.cpp
povray-3.7-stable/source/backend/math/quatern.h
povray-3.7-stable/source/backend/math/splines.cpp
povray-3.7-stable/source/backend/math/splines.h
povray-3.7-stable/source/backend/math/vector.h
povray-3.7-stable/source/backend/parser/express.cpp
povray-3.7-stable/source/backend/parser/fnsyntax.cpp
povray-3.7-stable/source/backend/parser/function.cpp
povray-3.7-stable/source/backend/parser/parse.cpp
povray-3.7-stable/source/backend/parser/parse.h
povray-3.7-stable/source/backend/parser/parsestr.cpp
povray-3.7-stable/source/backend/parser/parstxtr.cpp
povray-3.7-stable/source/backend/parser/reswords.cpp
povray-3.7-stable/source/backend/parser/reswords.h
povray-3.7-stable/source/backend/parser/tokenize.cpp
povray-3.7-stable/source/backend/pattern/pattern.cpp
povray-3.7-stable/source/backend/pattern/pattern.h
povray-3.7-stable/source/backend/pattern/warps.cpp
povray-3.7-stable/source/backend/pattern/warps.h
povray-3.7-stable/source/backend/povray.cpp
povray-3.7-stable/source/backend/povray.h
povray-3.7-stable/source/backend/render/radiositytask.cpp
povray-3.7-stable/source/backend/render/radiositytask.h
povray-3.7-stable/source/backend/render/ray.cpp
povray-3.7-stable/source/backend/render/ray.h
povray-3.7-stable/source/backend/render/rendertask.cpp
povray-3.7-stable/source/backend/render/rendertask.h
povray-3.7-stable/source/backend/render/trace.cpp
povray-3.7-stable/source/backend/render/trace.h
povray-3.7-stable/source/backend/render/tracepixel.cpp
povray-3.7-stable/source/backend/render/tracepixel.h
povray-3.7-stable/source/backend/render/tracetask.cpp
povray-3.7-stable/source/backend/render/tracetask.h
povray-3.7-stable/source/backend/scene/atmosph.cpp
povray-3.7-stable/source/backend/scene/atmosph.h
povray-3.7-stable/source/backend/scene/camera.cpp
povray-3.7-stable/source/backend/scene/camera.h
povray-3.7-stable/source/backend/scene/objects.cpp
povray-3.7-stable/source/backend/scene/objects.h
povray-3.7-stable/source/backend/scene/scene.cpp
povray-3.7-stable/source/backend/scene/scene.h
povray-3.7-stable/source/backend/scene/threaddata.cpp
povray-3.7-stable/source/backend/scene/threaddata.h
povray-3.7-stable/source/backend/scene/view.cpp
povray-3.7-stable/source/backend/scene/view.h
povray-3.7-stable/source/backend/shape/bezier.cpp
povray-3.7-stable/source/backend/shape/bezier.h
povray-3.7-stable/source/backend/shape/blob.cpp
povray-3.7-stable/source/backend/shape/blob.h
povray-3.7-stable/source/backend/shape/boxes.cpp
povray-3.7-stable/source/backend/shape/boxes.h
povray-3.7-stable/source/backend/shape/cones.cpp
povray-3.7-stable/source/backend/shape/cones.h
povray-3.7-stable/source/backend/shape/csg.cpp
povray-3.7-stable/source/backend/shape/csg.h
povray-3.7-stable/source/backend/shape/discs.cpp
povray-3.7-stable/source/backend/shape/discs.h
povray-3.7-stable/source/backend/shape/fpmetric.cpp
povray-3.7-stable/source/backend/shape/fpmetric.h
povray-3.7-stable/source/backend/shape/fractal.cpp
povray-3.7-stable/source/backend/shape/fractal.h
povray-3.7-stable/source/backend/shape/hfield.cpp
povray-3.7-stable/source/backend/shape/hfield.h
povray-3.7-stable/source/backend/shape/isosurf.cpp
povray-3.7-stable/source/backend/shape/isosurf.h
povray-3.7-stable/source/backend/shape/lathe.cpp
povray-3.7-stable/source/backend/shape/lathe.h
povray-3.7-stable/source/backend/shape/mesh.cpp
povray-3.7-stable/source/backend/shape/mesh.h
povray-3.7-stable/source/backend/shape/ovus.cpp
povray-3.7-stable/source/backend/shape/ovus.h
povray-3.7-stable/source/backend/shape/planes.cpp
povray-3.7-stable/source/backend/shape/planes.h
povray-3.7-stable/source/backend/shape/poly.cpp
povray-3.7-stable/source/backend/shape/poly.h
povray-3.7-stable/source/backend/shape/polygon.cpp
povray-3.7-stable/source/backend/shape/polygon.h
povray-3.7-stable/source/backend/shape/prism.cpp
povray-3.7-stable/source/backend/shape/prism.h
povray-3.7-stable/source/backend/shape/quadrics.cpp
povray-3.7-stable/source/backend/shape/quadrics.h
povray-3.7-stable/source/backend/shape/sor.cpp
povray-3.7-stable/source/backend/shape/sor.h
povray-3.7-stable/source/backend/shape/spheres.cpp
povray-3.7-stable/source/backend/shape/spheres.h
povray-3.7-stable/source/backend/shape/sphsweep.cpp
povray-3.7-stable/source/backend/shape/sphsweep.h
povray-3.7-stable/source/backend/shape/super.cpp
povray-3.7-stable/source/backend/shape/super.h
povray-3.7-stable/source/backend/shape/torus.cpp
povray-3.7-stable/source/backend/shape/torus.h
povray-3.7-stable/source/backend/shape/triangle.cpp
povray-3.7-stable/source/backend/shape/triangle.h
povray-3.7-stable/source/backend/shape/truetype.cpp
povray-3.7-stable/source/backend/shape/truetype.h
povray-3.7-stable/source/backend/support/bsptree.cpp
povray-3.7-stable/source/backend/support/bsptree.h
povray-3.7-stable/source/backend/support/fileutil.cpp
povray-3.7-stable/source/backend/support/fileutil.h
povray-3.7-stable/source/backend/support/fixedallocator.h
povray-3.7-stable/source/backend/support/imageutil.cpp
povray-3.7-stable/source/backend/support/imageutil.h
povray-3.7-stable/source/backend/support/jitter.cpp
povray-3.7-stable/source/backend/support/jitter.h
povray-3.7-stable/source/backend/support/msgutil.cpp
povray-3.7-stable/source/backend/support/msgutil.h
povray-3.7-stable/source/backend/support/octree.cpp
povray-3.7-stable/source/backend/support/octree.h
povray-3.7-stable/source/backend/support/randomsequences.cpp
povray-3.7-stable/source/backend/support/randomsequences.h
povray-3.7-stable/source/backend/support/simplevector.h
povray-3.7-stable/source/backend/support/statistics.cpp
povray-3.7-stable/source/backend/support/statistics.h
povray-3.7-stable/source/backend/support/task.cpp
povray-3.7-stable/source/backend/support/task.h
povray-3.7-stable/source/backend/support/taskqueue.cpp
povray-3.7-stable/source/backend/support/taskqueue.h
povray-3.7-stable/source/backend/texture/avxfma4check.h
povray-3.7-stable/source/backend/texture/normal.cpp
povray-3.7-stable/source/backend/texture/normal.h
povray-3.7-stable/source/backend/texture/pigment.cpp
povray-3.7-stable/source/backend/texture/pigment.h
povray-3.7-stable/source/backend/texture/texture.cpp
povray-3.7-stable/source/backend/texture/texture.h
povray-3.7-stable/source/backend/vm/fncode.h
povray-3.7-stable/source/backend/vm/fnintern.cpp
povray-3.7-stable/source/backend/vm/fnintern.h
povray-3.7-stable/source/backend/vm/fnpovfpu.cpp
povray-3.7-stable/source/backend/vm/fnpovfpu.h
povray-3.7-stable/source/base/animation/animation.cpp
povray-3.7-stable/source/base/animation/animation.h
povray-3.7-stable/source/base/animation/moov.cpp
povray-3.7-stable/source/base/animation/moov.h
povray-3.7-stable/source/base/configbase.h
povray-3.7-stable/source/base/fileinputoutput.cpp
povray-3.7-stable/source/base/fileinputoutput.h
povray-3.7-stable/source/base/image/bmp.cpp
povray-3.7-stable/source/base/image/bmp.h
povray-3.7-stable/source/base/image/colourspace.cpp
povray-3.7-stable/source/base/image/colourspace.h
povray-3.7-stable/source/base/image/encoding.cpp
povray-3.7-stable/source/base/image/encoding.h
povray-3.7-stable/source/base/image/gif.cpp
povray-3.7-stable/source/base/image/gif.h
povray-3.7-stable/source/base/image/gifdecod.cpp
povray-3.7-stable/source/base/image/hdr.cpp
povray-3.7-stable/source/base/image/hdr.h
povray-3.7-stable/source/base/image/iff.cpp
povray-3.7-stable/source/base/image/iff.h
povray-3.7-stable/source/base/image/image.cpp
povray-3.7-stable/source/base/image/image.h
povray-3.7-stable/source/base/image/jpeg.cpp
povray-3.7-stable/source/base/image/jpeg_pov.h
povray-3.7-stable/source/base/image/metadata.h
povray-3.7-stable/source/base/image/openexr.cpp
povray-3.7-stable/source/base/image/openexr.h
povray-3.7-stable/source/base/image/pgm.cpp
povray-3.7-stable/source/base/image/pgm.h
povray-3.7-stable/source/base/image/png.cpp
povray-3.7-stable/source/base/image/png_pov.h
povray-3.7-stable/source/base/image/ppm.cpp
povray-3.7-stable/source/base/image/ppm.h
povray-3.7-stable/source/base/image/targa.cpp
povray-3.7-stable/source/base/image/targa.h
povray-3.7-stable/source/base/image/tiff.cpp
povray-3.7-stable/source/base/image/tiff_pov.h
povray-3.7-stable/source/base/path.cpp
povray-3.7-stable/source/base/path.h
povray-3.7-stable/source/base/platformbase.h
povray-3.7-stable/source/base/pointer.h
povray-3.7-stable/source/base/pov_err.cpp
povray-3.7-stable/source/base/pov_err.h
povray-3.7-stable/source/base/povdebug.h
povray-3.7-stable/source/base/povms.cpp
povray-3.7-stable/source/base/povms.h
povray-3.7-stable/source/base/povmscpp.cpp
povray-3.7-stable/source/base/povmscpp.h
povray-3.7-stable/source/base/povmsgid.h
povray-3.7-stable/source/base/processoptions.cpp
povray-3.7-stable/source/base/processoptions.h
povray-3.7-stable/source/base/safemath.h
povray-3.7-stable/source/base/stringutilities.cpp
povray-3.7-stable/source/base/stringutilities.h
povray-3.7-stable/source/base/textstream.cpp
povray-3.7-stable/source/base/textstream.h
povray-3.7-stable/source/base/textstreambuffer.cpp
povray-3.7-stable/source/base/textstreambuffer.h
povray-3.7-stable/source/base/timer.cpp
povray-3.7-stable/source/base/timer.h
povray-3.7-stable/source/base/types.h
povray-3.7-stable/source/frontend/animationprocessing.cpp
povray-3.7-stable/source/frontend/animationprocessing.h
povray-3.7-stable/source/frontend/configfrontend.h
povray-3.7-stable/source/frontend/console.cpp
povray-3.7-stable/source/frontend/console.h
povray-3.7-stable/source/frontend/defaultplatformbase.cpp
povray-3.7-stable/source/frontend/defaultplatformbase.h
povray-3.7-stable/source/frontend/display.cpp
povray-3.7-stable/source/frontend/display.h
povray-3.7-stable/source/frontend/filemessagehandler.cpp
povray-3.7-stable/source/frontend/filemessagehandler.h
povray-3.7-stable/source/frontend/imagemessagehandler.cpp
povray-3.7-stable/source/frontend/imagemessagehandler.h
povray-3.7-stable/source/frontend/imageprocessing.cpp
povray-3.7-stable/source/frontend/imageprocessing.h
povray-3.7-stable/source/frontend/parsermessagehandler.cpp
povray-3.7-stable/source/frontend/parsermessagehandler.h
povray-3.7-stable/source/frontend/processrenderoptions.cpp
povray-3.7-stable/source/frontend/processrenderoptions.h
povray-3.7-stable/source/frontend/renderfrontend.cpp
povray-3.7-stable/source/frontend/renderfrontend.h
povray-3.7-stable/source/frontend/rendermessagehandler.cpp
povray-3.7-stable/source/frontend/rendermessagehandler.h
povray-3.7-stable/source/frontend/shelloutprocessing.cpp
povray-3.7-stable/source/frontend/shelloutprocessing.h
povray-3.7-stable/source/frontend/simplefrontend.h
povray-3.7-stable/source/lightgrp.cpp
povray-3.7-stable/source/lightgrp.h
povray-3.7-stable/source/optout.cpp
povray-3.7-stable/source/pov_mem.cpp
povray-3.7-stable/source/pov_mem.h
povray-3.7-stable/source/povrayold.h
povray-3.7-stable/source/statspov.h
povray-3.7-stable/unix/disp.h
povray-3.7-stable/unix/disp_sdl.cpp
povray-3.7-stable/unix/disp_sdl.h
povray-3.7-stable/unix/disp_text.cpp
povray-3.7-stable/unix/disp_text.h
povray-3.7-stable/vfe/syspovdebug.h
povray-3.7-stable/vfe/syspovprotobackend.h
povray-3.7-stable/vfe/syspovprotobase.h
povray-3.7-stable/vfe/syspovprotofrontend.h
povray-3.7-stable/vfe/unix/platformbase.cpp
povray-3.7-stable/vfe/unix/syspovconfig.h
povray-3.7-stable/vfe/unix/syspovconfigbackend.h
povray-3.7-stable/vfe/unix/syspovconfigbase.h
povray-3.7-stable/vfe/unix/syspovconfigfrontend.h
povray-3.7-stable/vfe/unix/unixconsole.cpp
povray-3.7-stable/vfe/unix/unixoptions.cpp
povray-3.7-stable/vfe/unix/unixoptions.h
povray-3.7-stable/vfe/unix/vfeplatform.cpp
povray-3.7-stable/vfe/unix/vfeplatform.h
povray-3.7-stable/vfe/vfe.cpp
povray-3.7-stable/vfe/vfe.h
povray-3.7-stable/vfe/vfeconf.h
povray-3.7-stable/vfe/vfecontrol.cpp
povray-3.7-stable/vfe/vfedisplay.cpp
povray-3.7-stable/vfe/vfepovms.cpp
povray-3.7-stable/vfe/vfepovms.h
povray-3.7-stable/vfe/vfesession.cpp
povray-3.7-stable/vfe/vfesession.h
povray-3.7-stable/vfe/win/compilers/msvc.h
povray-3.7-stable/vfe/win/console/winconsole.cpp
povray-3.7-stable/vfe/win/platformbase.cpp
povray-3.7-stable/vfe/win/syspovconfig.h
povray-3.7-stable/vfe/win/syspovconfigbackend.h
povray-3.7-stable/vfe/win/syspovconfigbase.h
povray-3.7-stable/vfe/win/syspovconfigfrontend.h
povray-3.7-stable/vfe/win/syspovimage.h
povray-3.7-stable/vfe/win/vfeplatform.cpp
povray-3.7-stable/vfe/win/vfeplatform.h
povray-3.7-stable/windows/cmedit/StdStringList.cpp
povray-3.7-stable/windows/cmedit/StdStringList.h
povray-3.7-stable/windows/cmedit/ccodemax.cpp
povray-3.7-stable/windows/cmedit/ccodemax.h
povray-3.7-stable/windows/cmedit/cmedit.cpp
povray-3.7-stable/windows/cmedit/cmedit.h
povray-3.7-stable/windows/cmedit/dialogs.cpp
povray-3.7-stable/windows/cmedit/dialogs.h
povray-3.7-stable/windows/cmedit/editorinterface.cpp
povray-3.7-stable/windows/cmedit/editorinterface.h
povray-3.7-stable/windows/cmedit/eventhandlers.cpp
povray-3.7-stable/windows/cmedit/eventhandlers.h
povray-3.7-stable/windows/cmedit/menusupport.cpp
povray-3.7-stable/windows/cmedit/menusupport.h
povray-3.7-stable/windows/cmedit/povlangdef.h
povray-3.7-stable/windows/cmedit/settings.cpp
povray-3.7-stable/windows/cmedit/settings.h
povray-3.7-stable/windows/pvbitmap.cpp
povray-3.7-stable/windows/pvbitmap.h
povray-3.7-stable/windows/pvdemo.h
povray-3.7-stable/windows/pvdialog.cpp
povray-3.7-stable/windows/pvdialog.h
povray-3.7-stable/windows/pvdisplay.cpp
povray-3.7-stable/windows/pvdisplay.h
povray-3.7-stable/windows/pvedit.cpp
povray-3.7-stable/windows/pvedit.h
povray-3.7-stable/windows/pvengine.cpp
povray-3.7-stable/windows/pvengine.h
povray-3.7-stable/windows/pvfiles.cpp
povray-3.7-stable/windows/pvfrontend.cpp
povray-3.7-stable/windows/pvfrontend.h
povray-3.7-stable/windows/pvguiext.cpp
povray-3.7-stable/windows/pvguiext.h
povray-3.7-stable/windows/pvlegal.h
povray-3.7-stable/windows/pvmem.cpp
povray-3.7-stable/windows/pvmem.h
povray-3.7-stable/windows/pvmenu.cpp
povray-3.7-stable/windows/pvmisc.cpp
povray-3.7-stable/windows/pvtext.cpp
povray-3.7-stable/windows/pvupdate.cpp
povray-3.7-stable/windows/rtrsupport/rtrsupport.cpp
povray-3.7-stable/windows/rtrsupport/rtrsupport.h
povray-3.7-stable/windows/rtrsupport/rtrvidcap.h
povray-3.7-stable/windows/rtrsupport/vidcap.cpp
povray-3.7-stable/windows/rtrsupport/vidcapimpl.cpp

BSD (3 clause)
--------------
povray-3.7-stable/source/backend/math/chi2.cpp

Unknown or generated
--------------------
povray-3.7-stable/distribution/include/arrays.inc
povray-3.7-stable/distribution/include/chars.inc
povray-3.7-stable/distribution/include/colors.inc
povray-3.7-stable/distribution/include/consts.inc
povray-3.7-stable/distribution/include/debug.inc
povray-3.7-stable/distribution/include/finish.inc
povray-3.7-stable/distribution/include/functions.inc
povray-3.7-stable/distribution/include/glass.inc
povray-3.7-stable/distribution/include/glass_old.inc
povray-3.7-stable/distribution/include/golds.inc
povray-3.7-stable/distribution/include/ior.inc
povray-3.7-stable/distribution/include/logo.inc
povray-3.7-stable/distribution/include/makegrass.inc
povray-3.7-stable/distribution/include/math.inc
povray-3.7-stable/distribution/include/meshmaker.inc
povray-3.7-stable/distribution/include/metals.inc
povray-3.7-stable/distribution/include/rad_def.inc
povray-3.7-stable/distribution/include/rand.inc
povray-3.7-stable/distribution/include/screen.inc
povray-3.7-stable/distribution/include/shapes.inc
povray-3.7-stable/distribution/include/shapes2.inc
povray-3.7-stable/distribution/include/shapes3.inc
povray-3.7-stable/distribution/include/shapes_old.inc
povray-3.7-stable/distribution/include/shapesq.inc
povray-3.7-stable/distribution/include/skies.inc
povray-3.7-stable/distribution/include/stage1.inc
povray-3.7-stable/distribution/include/stars.inc
povray-3.7-stable/distribution/include/stdcam.inc
povray-3.7-stable/distribution/include/stdinc.inc
povray-3.7-stable/distribution/include/stoneold.inc
povray-3.7-stable/distribution/include/stones.inc
povray-3.7-stable/distribution/include/stones1.inc
povray-3.7-stable/distribution/include/stones2.inc
povray-3.7-stable/distribution/include/strings.inc
povray-3.7-stable/distribution/include/sunpos.inc
povray-3.7-stable/distribution/include/textures.inc
povray-3.7-stable/distribution/include/transforms.inc
povray-3.7-stable/distribution/include/woodmaps.inc
povray-3.7-stable/distribution/include/woods.inc
povray-3.7-stable/distribution/scenes/advanced/balcony/bglass.inc
povray-3.7-stable/distribution/scenes/advanced/balcony/building.inc
povray-3.7-stable/distribution/scenes/advanced/balcony/chair.inc
povray-3.7-stable/distribution/scenes/advanced/balcony/cloth.inc
povray-3.7-stable/distribution/scenes/advanced/balcony/sky.inc
povray-3.7-stable/distribution/scenes/advanced/balcony/table.inc
povray-3.7-stable/distribution/scenes/advanced/balcony/table_cloth.inc
povray-3.7-stable/distribution/scenes/advanced/balcony/table_stuff.inc
povray-3.7-stable/distribution/scenes/advanced/balcony/terrain.inc
povray-3.7-stable/distribution/scenes/advanced/balcony/water.inc
povray-3.7-stable/distribution/scenes/advanced/blocks/makestacks.inc
povray-3.7-stable/distribution/scenes/advanced/blocks/stacks.inc
povray-3.7-stable/distribution/scenes/advanced/drums2/drums.inc
povray-3.7-stable/distribution/scenes/advanced/glasschess/chesspiece1.inc
povray-3.7-stable/distribution/scenes/advanced/grenadine/lemon.inc
povray-3.7-stable/distribution/scenes/advanced/ntreal/ntreal.inc
povray-3.7-stable/distribution/scenes/advanced/teapot/teapot.inc
povray-3.7-stable/distribution/scenes/advanced/teapot/teapot_c1.inc
povray-3.7-stable/distribution/scenes/advanced/teapot/teapot_c2.inc
povray-3.7-stable/distribution/scenes/advanced/teapot/teapot_c3.inc
povray-3.7-stable/distribution/scenes/advanced/teapot/teapot_sph.inc
povray-3.7-stable/distribution/scenes/advanced/teapot/teapot_tri.inc
povray-3.7-stable/distribution/scenes/camera/camera-context.inc
povray-3.7-stable/distribution/scenes/camera/mesh_camera/bake.sh
povray-3.7-stable/distribution/scenes/camera/mesh_camera/demo_common.inc
povray-3.7-stable/distribution/scenes/camera/mesh_camera/demo_globals.inc
povray-3.7-stable/distribution/scenes/camera/mesh_camera/demo_room.inc
povray-3.7-stable/distribution/scenes/camera/mesh_camera/meshcam_macros.inc
povray-3.7-stable/distribution/scenes/camera/mesh_camera/vase1.inc
povray-3.7-stable/distribution/scenes/camera/mesh_camera/vase2.inc
povray-3.7-stable/distribution/scenes/incdemo/glasses/sample.inc
povray-3.7-stable/distribution/scenes/incdemo/metals/stage_xy.inc
povray-3.7-stable/distribution/scenes/incdemo/metals/stage_xz.inc
povray-3.7-stable/distribution/scenes/incdemo/shotxtr.inc
povray-3.7-stable/distribution/scenes/incdemo/woods/testcam.inc
povray-3.7-stable/distribution/scenes/incdemo/woods/testobjs.inc
povray-3.7-stable/distribution/scenes/language/macros/local.inc
povray-3.7-stable/distribution/scenes/objectmods/thingy.inc
povray-3.7-stable/distribution/scenes/objects/chess.inc
povray-3.7-stable/distribution/scenes/objects/prism3.inc
povray-3.7-stable/distribution/scenes/objects/quartic/axisbox.inc
povray-3.7-stable/distribution/scenes/portfolio/html_gen.inc
povray-3.7-stable/distribution/scenes/textures/patterns/pignorm.inc
povray-3.7-stable/source/backend/vm/fncode.cpp
povray-3.7-stable/source/base/font/crystal.cpp
povray-3.7-stable/source/base/font/crystal.h
povray-3.7-stable/source/base/font/cyrvetic.cpp
povray-3.7-stable/source/base/font/cyrvetic.h
povray-3.7-stable/source/base/font/povlogo.cpp
povray-3.7-stable/source/base/font/povlogo.h
povray-3.7-stable/source/base/font/timrom.cpp
povray-3.7-stable/source/base/font/timrom.h
povray-3.7-stable/source/precomp.cpp
povray-3.7-stable/source/precomp.h
povray-3.7-stable/unix/prebuild.sh
povray-3.7-stable/unix/scripts/allanim.sh
povray-3.7-stable/unix/scripts/allscene.sh
povray-3.7-stable/unix/scripts/portfolio.sh
povray-3.7-stable/unix/scripts/render_anim.sh
povray-3.7-stable/unix/scripts/render_scene.sh
povray-3.7-stable/unix/scripts/rerunpov.sh
povray-3.7-stable/unix/scripts/runpov.sh
povray-3.7-stable/vfe/vfeprecomp.cpp
povray-3.7-stable/vfe/vfeprecomp.h
povray-3.7-stable/vfe/win/cpuinfo.cpp
povray-3.7-stable/windows/cmedit/StdString.h
povray-3.7-stable/windows/cmedit/resource.h
povray-3.7-stable/windows/resource.h
povray-3.7-stable/windows/winprecomp.cpp
povray-3.7-stable/windows/winprecomp.h

[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[ ]: Avoid bundling fonts in non-fonts packages.
     Note: Package contains font files
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
     Note: Arch-ed rpms have a total of 14960640 bytes in /usr/share
     povray-3.7-0.1.20131116git39ce8a2.fc21.i686.rpm:14960640
     See:
     http://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Package should not use obsolete m4 macros


Rpmlint
-------
Checking: povray-3.7-0.1.20131116git39ce8a2.fc21.i686.rpm
          povray-scenes-3.7-0.1.20131116git39ce8a2.fc21.noarch.rpm
          povray-3.7-0.1.20131116git39ce8a2.fc21.src.rpm
povray-scenes.noarch: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 1 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint povray-scenes povray
povray-scenes.noarch: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 1 warnings.
# echo 'rpmlint-done:'



Requires
--------
povray-scenes (rpmlib, GLIBC filtered):
    /bin/bash

povray (rpmlib, GLIBC filtered):
    /bin/sh
    config(povray)
    libHalf.so.11
    libIex-2_1.so.11
    libIexMath-2_1.so.11
    libIlmImf-Imf_2_1.so.21
    libIlmThread-2_1.so.11
    libImath-2_1.so.11
    libSDL-1.2.so.0
    libX11.so.6
    libXpm.so.4
    libboost_system.so.1.54.0
    libboost_thread.so.1.54.0
    libc.so.6
    libgcc_s.so.1
    libgcc_s.so.1(GCC_3.0)
    libgcc_s.so.1(GCC_4.0.0)
    libjpeg.so.62
    libjpeg.so.62(LIBJPEG_6.2)
    libm.so.6
    libpng16.so.16
    libpng16.so.16(PNG16_0)
    libpthread.so.0
    librt.so.1
    libstdc++.so.6
    libstdc++.so.6(CXXABI_1.3)
    libstdc++.so.6(CXXABI_1.3.1)
    libtiff.so.5
    libtiff.so.5(LIBTIFF_4.0)
    libz.so.1
    rtld(GNU_HASH)



Provides
--------
povray-scenes:
    povray-scenes

povray:
    config(povray)
    povray
    povray(x86-32)



Source checksums
----------------
https://github.com/POV-Ray/povray/archive/3.7-stable/39ce8a24e50651904010dda15872d63be15d7c37/povray-3.7-20131116git39ce8a2.tar.gz :
  CHECKSUM(SHA256) this package     : a51b421d3ec0a5ad6d40db0d06c3f26f4ec9fd083354cb1bcb16ef20fe7fff77
  CHECKSUM(SHA256) upstream package : a51b421d3ec0a5ad6d40db0d06c3f26f4ec9fd083354cb1bcb16ef20fe7fff77


Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review -rvn povray-3.7-0.1.20131116git39ce8a2.fc21.src.rpm
Buildroot used: fedora-rawhide-i386
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

----------------------------

1. How to deal with that large doc piece?

2. I've sent en email to inquiry if it's legitimate to use "The Fedora Project":

https://lists.fedoraproject.org/pipermail/packaging/2014-January/009965.html

Comment 3 Ralf Corsepius 2014-01-24 16:39:24 UTC
(In reply to Christopher Meng from comment #2)

> 1. How to deal with that large doc piece?
I do not intend to split them into a separate doc-package.

These docs are application docs without which this package would not be helpful to users. All that splitting out them would do is adding package complexity.

> 2. I've sent en email to inquiry if it's legitimate to use "The Fedora
> Project":
> 
> https://lists.fedoraproject.org/pipermail/packaging/2014-January/009965.html

As outlined on the list, I am going apply some magic to derive COMPILED_BY from %vendor.

Comment 4 Ralf Corsepius 2014-01-24 17:34:06 UTC
Next iteration with modified COMPILED_BY magic:

Spec URL: http://corsepiu.fedorapeople.org/packages/povray.spec
SRPM URL: http://corsepiu.fedorapeople.org/packages/povray-3.7-0.2.20131116git39ce8a2.fc21.src.rpm

Comment 5 Christopher Meng 2014-01-27 06:24:34 UTC
Fine: http://koji.fedoraproject.org/koji/taskinfo?taskID=6457016

PACKAGE APPROVED.

Comment 6 Ralf Corsepius 2014-01-28 03:16:09 UTC
Thanks for the review, Christopher.

New Package SCM Request
=======================
Package Name: povray
Short Description: The Persistence of Vision Ray Tracer
Owners: corsepiu
Branches: f20 f19

Comment 7 Gwyn Ciesla 2014-01-28 13:06:41 UTC
Git done (by process-git-requests).

Comment 8 Fedora Update System 2014-01-28 14:20:35 UTC
povray-3.7-0.2.20131116git39ce8a2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/povray-3.7-0.2.20131116git39ce8a2.fc19

Comment 9 Fedora Update System 2014-01-28 14:20:50 UTC
povray-3.7-0.2.20131116git39ce8a2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/povray-3.7-0.2.20131116git39ce8a2.fc20

Comment 10 Fedora Update System 2014-01-29 03:07:37 UTC
povray-3.7-0.2.20131116git39ce8a2.fc20 has been pushed to the Fedora 20 testing repository.

Comment 11 Fedora Update System 2014-02-06 03:44:46 UTC
povray-3.7-0.2.20131116git39ce8a2.fc19 has been pushed to the Fedora 19 stable repository.

Comment 12 Fedora Update System 2014-02-06 03:58:46 UTC
povray-3.7-0.2.20131116git39ce8a2.fc20 has been pushed to the Fedora 20 stable repository.


Note You need to log in before you can comment on or make changes to this bug.