Bug 1056130 - add-user.sh syntax cygwin fix
Summary: add-user.sh syntax cygwin fix
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Enterprise Application Platform 6
Classification: JBoss
Component: Scripts and Commands
Version: 6.2.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: CR1
: EAP 6.2.2
Assignee: Permaine Cheung
QA Contact: Petr Kremensky
Russell Dickenson
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-01-21 14:44 UTC by Aleksandar Kostadinov
Modified: 2014-06-02 12:50 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
It was found that the add-user.sh script would fail when run in Cygwin environments. The cause was identified as a poorly formatted line of code in the script. The syntax has been corrected and the script now operates as expected in Cygwin environments.
Clone Of:
: 1057625 (view as bug list)
Environment:
Last Closed: 2014-06-02 12:50:03 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1072231 0 unspecified CLOSED [QE] (6.2.2) add-user.sh is not working with cygwin 2021-02-22 00:41:40 UTC

Internal Links: 1072231

Description Aleksandar Kostadinov 2014-01-21 14:44:24 UTC
add-user.sh fails under cygwin for bad syntax. It's a trivial one line change like WFLY-130 (https://github.com/wildfly/wildfly/pull/5737):

> diff --git a/build/src/main/resources/bin/add-user.sh b/build/src/main/resources/bin
> index 38cc026..074ed0c 100755
> --- a/build/src/main/resources/bin/add-user.sh
> +++ b/build/src/main/resources/bin/add-user.sh
> @@ -11,7 +11,7 @@ DIRNAME=`dirname "$0"`
>  # OS specific support (must be 'true' or 'false').
>  cygwin=false;
>  if  [ `uname|grep -i CYGWIN` ]; then
> -    cygwin = true;
> +    cygwin=true;
>  fi
>  
>  # For Cygwin, ensure paths are in UNIX format before anything is touched

Comment 1 Scott Mumford 2014-01-23 04:19:29 UTC
Marking for inclusion in 6.2.1 Release Notes and adding draft text.

Comment 2 Permaine Cheung 2014-01-23 19:28:02 UTC
I'm working on a PR for this, do we have a BZ for this against 6.3.0?

Comment 3 Aleksandar Kostadinov 2014-01-23 20:23:37 UTC
I haven't filed any other bz issue.

Comment 4 Permaine Cheung 2014-01-24 13:49:47 UTC
I cloned this BZ for 6.3.0:
https://bugzilla.redhat.com/show_bug.cgi?id=1057625

Comment 5 Permaine Cheung 2014-01-24 14:34:05 UTC
Marking this as ASSIGNED as this didn't make it to the 6.2.1 CR2 tag, will be sending in the PR shortly.

Comment 8 Petr Kremensky 2014-03-04 09:32:23 UTC
Verified on EAP 6.2.2.CP.CR2


Note You need to log in before you can comment on or make changes to this bug.