Bug 1060895 - redis.init does not properly shutdown the daemon
Summary: redis.init does not properly shutdown the daemon
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: redis
Version: rawhide
Hardware: All
OS: All
unspecified
high
Target Milestone: ---
Assignee: Christopher Meng
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-02-03 20:51 UTC by bugzillas
Modified: 2020-12-27 22:44 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-07-10 16:13:14 UTC
Type: Bug
Embargoed:
bugzillas: needinfo-


Attachments (Terms of Use)

Description bugzillas 2014-02-03 20:51:32 UTC
Description of problem:

http://pkgs.fedoraproject.org/cgit/redis.git/commit/redis.init?id=8ddfa61371530c513767adf684b714f2a20d324b

The init script included in all releases uses kill to stop the redid process. For proper shutdown redis-cli SHUTDOWN should be used. When persistence is configured this makes sure redis properly disconnects clients and saves the data to disk.

Version-Release number of selected component (if applicable):

Applicable to all released versions


How reproducible:

Shutdown redid with the init script


Steps to Reproduce:
1. have snapshot or aof on
2. service redis stop

Actual results:

Redis shuts down without proper save.

Expected results:

Redis dumps data to disk and shuts down.

Additional info:

Comment 1 Christopher Meng 2014-06-19 08:00:04 UTC
I'm not sure if you are using Fedora rawhide or elder versions.

For Rawhide, I've switched the package to systemd today by redis-2.8.11-1.fc21 in rawhide. In systemd unit files redis-server.service and redis-sentinel.service, you can see I've used "ExecStop=/usr/bin/redis-cli shutdown" to control the stop.

If you are using Fedora 20, don't worry, I'm updating this package on f20 to the latest 2.6 version.


Note You need to log in before you can comment on or make changes to this bug.