Bug 106315 - bad source code
bad source code
Product: Red Hat Linux
Classification: Retired
Component: zebra (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jay Fenlason
David Lawrence
Depends On:
  Show dependency treegraph
Reported: 2003-10-05 05:50 EDT by d.binderman
Modified: 2014-08-31 19:25 EDT (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2004-06-30 11:29:31 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description d.binderman 2003-10-05 05:50:59 EDT
Description of problem:

Hello there,

I just tried to compile package zebra-0.93b-1, from Redhat 9.0,
with compiler flag -Wall.

The compiler said

ospf6_route.c:669: warning: operation on `p' may be undefined
ospf6_route.c:681: warning: operation on `p' may be undefined

The source code is

                  snprintf (p++, line + sizeof (line) - p, " ");

This looks like someone is assuming left to right evaluation order.
This code needs rework.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
Actual results:

Expected results:

Additional info:
Comment 1 Jay Fenlason 2004-06-30 11:29:31 EDT
This has been fixed in quagga, which replaced zebra in Fedora Core.

Note You need to log in before you can comment on or make changes to this bug.