Red Hat Bugzilla – Bug 1065058
Review Request: textql - Execute SQL against structured text like CSV or TSV
Last modified: 2016-09-08 04:34:28 EDT
Spec URL: http://data.fabiolocati.com/fedora/textql/textql.spec
SRPM URL: http://data.fabiolocati.com/fedora/textql/textql-0.0-1.gita7fbbe2.fc20.src.rpm
Koji URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=6527905
Description: This tool allows you to run sql-like queries on structured files
like CSV and TSV.
Fedora Account System Username: fale
This is my second fedora package (1st one is at bug 1062942) from scratch and third work on fedora packages (there is also bug 1062668) and I'm looking for a sponsor.
Some quick comments -
You can drop
* BuildRequires: gcc
* BuildRequires: gcc-go
You package builds for me in mock. Try building the binary rpm and check for errors using rpmlint.
$ rpmlint textql.spec /var/lib/mock/fedora-rawhide-x86_64/result/textql-*rpm
textql.spec: W: invalid-url Source0: textql-a7fbbe2.tar
textql.src: W: spelling-error %description -l en_US sql -> sq, sol, sq l
textql.src: W: invalid-url Source0: textql-a7fbbe2.tar
textql.x86_64: W: spelling-error %description -l en_US sql -> sq, sol, sq l
textql.x86_64: W: no-manual-page-for-binary textql
textql-debuginfo.x86_64: E: debuginfo-without-sources
3 packages and 1 specfiles checked; 1 errors, 5 warnings.
debuginfo-without-source is particularly a problem.
Hope this helps.
Thanks for the comment. I've ignored the error since another package is created (textql-debuginfo-0.0-1.gita7fbbe2.fc20.i686.rpm) which contains all debug files:
I'll move the debug part in the core package and drop the second one :).
You'd better wait for a while, go packaging guideline is being developed:
(In reply to Fabio Alessandro Locati from comment #2)
> Hi :),
> Thanks for the comment. I've ignored the error since another package is
> created (textql-debuginfo-0.0-1.gita7fbbe2.fc20.i686.rpm) which contains all
> debug files:
> I'll move the debug part in the core package and drop the second one :).
Please nuke the debuginfo, it's nonsense to include them in the main package.
golang packages should have no debuginfo.
ping. What is the situation here? Do you want to continue or drop this one?
In the mean time a lot of polices on GOLANG has been polished, and therefore I've re-created the SPEC from scratch.
Just found this https://bugzilla.redhat.com/show_bug.cgi?id=1062942#c25 and according to that this review should not block for FE-NEEDSPONSOR queue.
That is true. I forgot to remove the blocking status from this repo when I got accepted as a packager. Good catch Parag :) and thanks!