From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030903

Description of problem:
When the network interface netdump uses is not up, or is not correct etc, the
init script does not fail correctly, but continues.

This can be an obvious 'gotcha' (eg) if you have more than one network card.

Version-Release number of selected component (if applicable):
netdump-0.6.8-2

How reproducible:
Always

Steps to Reproduce:
1. misconfigure the DEV param in /etc/sysconfig/netdump
2. start the netdump service: service netdump start
3. lean back and enjoy the errors
    

Actual Results:  ambigious output, continues to try etc.

Expected Results:  simple, clear error message, stopping the 'service start'

Additional info:

Good, simple fix is:

diff -du /etc/init.d/netdump-orig /etc/init.d/netdump
--- /etc/init.d/netdump-orig    Wed Oct  8 10:28:58 2003
+++ /etc/init.d/netdump Wed Oct  8 10:36:23 2003
@@ -67,7 +67,16 @@
     local oldIFS arp_output line
  
     arping -c 1 -I $DEV $host &> /dev/null
-    [ $? -ne 0 ] && echo "$prog: cannot arp $host" 1>&2 && usage
+    local rc=$?
+    if [ $rc -ne 0 ]; then
+       if [ $rc -eq 2 ]; then
+           echo "$prog: interface $DEV not up"
+       else
+           echo "$prog: cannot arp $host" 1>&2
+       fi
+
+       exit 1
+    fi
  
     # output from arp -a of the form:
     # good: host.domain (A.B.C.D) at 00:50:BF:06:48:C1 [ether] on eth0
@@ -120,6 +129,11 @@
     MAGIC1=$(random_hex_int)
     MAGIC2=$(random_hex_int)
     LOCALADDR=$(ip_of_device $DEV)
+    if [ -z "$LOCALADDR" ]; then
+       echo "$prog: failed to find device $DEV"
+       exit 1
+    fi
+
     ssh -x -i /etc/sysconfig/netdump_id_dsa netdump@$NETDUMPADDR echo
"$MAGIC2$MAGIC1" \> /var/crash/magic/$LOCALADDR || echo "$prog: could not ssh to
server $NETDUMPADDR"
             
     IPHEX=`dquad_to_hex $IPADDR`