Bug 1066304 - Review Request: python-progress - Easy to use progress bars
Summary: Review Request: python-progress - Easy to use progress bars
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Tomas 'Sheldon' Radej
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-02-18 08:48 UTC by Bohuslav "Slavek" Kabrda
Modified: 2014-04-07 03:27 UTC (History)
3 users (show)

Fixed In Version: python-progress-1.2-2.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-02-19 14:03:03 UTC
Type: ---
Embargoed:
tradej: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Bohuslav "Slavek" Kabrda 2014-02-18 08:48:05 UTC
Spec URL: http://bkabrda.fedorapeople.org/pkgs/progress/python-progress.spec
SRPM URL: http://bkabrda.fedorapeople.org/pkgs/progress/python-progress-1.2-1.fc18.src.rpm
Description: Collection of easy to use progress bars and spinners.
Fedora Account System Username: bkabrda

Comment 1 Tomas 'Sheldon' Radej 2014-02-18 08:52:25 UTC
On it.

Comment 2 Tomas 'Sheldon' Radej 2014-02-18 14:49:23 UTC
Fails to build due to missing BR on python(3)-setuptools.

Comment 4 Tomas 'Sheldon' Radej 2014-02-18 15:09:06 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "ISC", "Unknown or generated". 2 files have unknown license. Detailed
     output of licensecheck in /home/tradej/development/reviews/1066304
     -python-progress/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-progress
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python-progress-1.2-2.fc21.noarch.rpm
          python3-progress-1.2-2.fc21.noarch.rpm
          python-progress-1.2-2.fc21.src.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint python-progress python3-progress
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
# echo 'rpmlint-done:'



Requires
--------
python-progress (rpmlib, GLIBC filtered):
    python(abi)

python3-progress (rpmlib, GLIBC filtered):
    python(abi)



Provides
--------
python-progress:
    python-progress

python3-progress:
    python3-progress



Source checksums
----------------
https://pypi.python.org/packages/source/p/progress/progress-1.2.tar.gz :
  CHECKSUM(SHA256) this package     : 5b6a50f9ac76820f619d7789b5354881c8c10060a64047e415868d8f503cc2eb
  CHECKSUM(SHA256) upstream package : 5b6a50f9ac76820f619d7789b5354881c8c10060a64047e415868d8f503cc2eb


Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review -b 1066304 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

*** APPROVED ***

Comment 5 Bohuslav "Slavek" Kabrda 2014-02-19 08:21:07 UTC
Thanks for your review!


New Package SCM Request
=======================
Package Name: python-progress
Short Description: Easy to use progress bars
Owners: bkabrda
Branches: 
InitialCC:

Comment 6 Christopher Meng 2014-02-19 08:46:04 UTC
1. BuildRequires: python-devel

Use python2-devel

2. %{python_sitelib}

Use 

%{python2_sitelib}

3. py?.? 

Well, to be more specific, try %python{2,3}_version

Comment 7 Bohuslav "Slavek" Kabrda 2014-02-19 09:18:06 UTC
(In reply to Christopher Meng from comment #6)
> 1. BuildRequires: python-devel
> 
> Use python2-devel
> 
> 2. %{python_sitelib}
> 
> Use 
> 
> %{python2_sitelib}
> 
> 3. py?.? 
> 
> Well, to be more specific, try %python{2,3}_version

Right, will do that before committing to dist-git.

Comment 8 Gwyn Ciesla 2014-02-19 13:28:51 UTC
Git done (by process-git-requests).

Comment 9 Miro Hrončok 2014-03-28 08:28:39 UTC
Package Change Request
======================
Package Name: python-progress
New Branches: f20
Owners: bkabrda churchyard

Comment 10 Gwyn Ciesla 2014-03-28 12:48:14 UTC
Git done (by process-git-requests).

Comment 11 Fedora Update System 2014-03-28 14:09:36 UTC
python-progress-1.2-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/python-progress-1.2-2.fc20

Comment 12 Fedora Update System 2014-04-07 03:27:38 UTC
python-progress-1.2-2.fc20 has been pushed to the Fedora 20 stable repository.


Note You need to log in before you can comment on or make changes to this bug.