Bug 1066985 - When new asset created, the commit in git is done by global git user, instead of user currently logged in business central
Summary: When new asset created, the commit in git is done by global git user, instead...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss BRMS Platform 6
Classification: Retired
Component: Business Central
Version: unspecified
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ER1
: 6.0.2
Assignee: Tihomir Surdilovic
QA Contact: Jan Hrcek
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-02-19 13:10 UTC by Jan Hrcek
Modified: 2014-08-06 19:53 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-08-06 19:53:23 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Git log showing the history of a repository (201.21 KB, image/png)
2014-02-19 13:10 UTC, Jan Hrcek
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1063436 0 high CLOSED New files are created with 2 commits on git instead of just one 2021-02-22 00:41:40 UTC

Internal Links: 1063436

Description Jan Hrcek 2014-02-19 13:10:14 UTC
Created attachment 865056 [details]
Git log showing the history of a repository

Description of problem:
Whenever I create a new asset in business central, a commit appears in the underlying .niogit repository. However, the author of this commit is not the user that was logged in the business central when the asset was created, but in my case it seems to be taken from global git config.
Please see the screenshot attached.

So far this seems to have not been causing any issues, but I indetified this as the root cause for Bug 1038108.

Version-Release number of selected component (if applicable):
BPMS 6.0.1 ER1

How reproducible:
Always

Steps to Reproduce:
1. Login to business central (in my case user with role admin)
2. Create some project and create some new assets of various types (processes, forms, DRLs etc.)
3. Check the underlying git repository

Actual results:
When new asset is created, the corresponding commit is done with user from global git config. Contrast this to commits that arise when you edit and save the asset (done with user who's logged into business central)

Expected results:
All comits done when creating/editting assets in business central should be done under the user, that is logged into business central.

Comment 1 manstis 2014-02-20 12:08:00 UTC
See referenced BZ.

When we used to create a new file as a separate commit the git global config user would be used. Now we've corrected this to create a new file with a single commit we provide the user details (i.e. logged in user).

I have checked with the latest source code in community and can confirm I did not see any rogue user names (or double commits for that matter).

Comment 2 Jan Hrcek 2014-03-07 10:55:36 UTC
I can confirm, that the issue of double commits and "rogue" users has been mostly fixed in BPMS 6.0.1 ER2. However there are still two cases that may have slipped your attention.

The global git user (as opposed to user logged into business central) is still used in the following cases:
1) When creating new package (Authoring > Project Authoring > New Item > Package)
2) When creating new process (Authoring > Project Authoring > New Item > Business Process)

in each case it seems that .niogit file and .<packageName> files are still added using git global user.

For all the other cases it work correctly, i.e. commits are done with the user that is logged in the business central. Could you please review the 2 remaining cases?

Comment 7 Jan Hrcek 2014-04-29 06:05:08 UTC
Ok, now all the assets are created with the user currently logged into business central. Verified with BPMS 6.0.2 ER2


Note You need to log in before you can comment on or make changes to this bug.