Spec URL: http://ojuba.org/oji/SPECS/hda-verb.spec SRPM URL: http://ojuba.org/oji/SRPMS/hda-verb-0.4-1.oj35.src.rpm Description: hda-verb is a tiny program that allows you to access the HD-audio codecs directly, allowing you to send commands (verbs) to them. For hda-verb to work you must be running a linux kernel with CONFIG_SND_HDA_HWDEP option enabled. Fedora Account System Username:moceap
I can take it.
Thanks.
somebody call me and said: There are another package provide hda-verb, it's alsa-tools. But it has 0.3 not 0.4 !!
So this package will cause a conflict then? I will do a detailed review later today ... (forgot to mention this in my first comment).
from your spec file, please include the license file in %doc. You spec file now reads as %doc ChangeLog README including the COPYING file, it should be %doc ChangeLog README COPYING
Ok spec : http://ojuba.org/test/hda-verb.spec srpm : http://ojuba.org/test/hda-verb-0.4-2.oj35.src.rpm
Few more comments - * In the %install section, can you not just use %make_install? * To me this looks like a conflict with alsa-tools. $ rpmls alsa-tools-1.0.27-3.fc20.x86_64.rpm -rwxr-xr-x /usr/bin/as10k1 -rwxr-xr-x /usr/bin/cspctl -rwxr-xr-x /usr/bin/echomixer -rwxr-xr-x /usr/bin/envy24control -rwxr-xr-x /usr/bin/hda-verb <----- -rwxr-xr-x /usr/bin/hdajackretask -rwxr-xr-x /usr/bin/hdspconf -rwxr-xr-x /usr/bin/hdspmixer $ rpmls hda-verb-0.4-1.fc20.x86_64.rpm -rwxr-xr-x /usr/sbin/hda-verb drwxr-xr-x /usr/share/doc/hda-verb -rw-r--r-- /usr/share/doc/hda-verb/ChangeLog http://fedoraproject.org/wiki/Packaging:Conflicts Let me know what you think.
Ok, It conflicts.