Bug 1069493 - Review Request: uncommons-antlib - Tools for building modular software with Apache Ant
Summary: Review Request: uncommons-antlib - Tools for building modular software with A...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-02-25 06:41 UTC by gil cattaneo
Modified: 2014-02-25 16:22 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-02-25 16:22:16 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description gil cattaneo 2014-02-25 06:41:21 UTC
Spec URL: http://gil.fedorapeople.org/uncommons-antlib.spec
SRPM URL: http://gil.fedorapeople.org/uncommons-antlib-0.3.2-1.fc19.src.rpm
Description:
The Uncommons Antlib provides macro definitions, custom tasks and other tools
to support the development of modular Java software using Apache Ant.  It
builds on the concepts, processes and best practices established in the
development of several Ant-based projects, particularly the Uncommons.org
open source projects.

The guiding principle behind the design of the Uncommons Antlib is convention
over configuration. Ant build scripts are greatly simplified by relying on
consistent directory structures and naming conventions.
Fedora Account System Username: gil

Comment 1 Mikolaj Izdebski 2014-02-25 16:14:47 UTC
You can require java-headless on all Fedoras, teher's no need for conditional.

Sed command to remove Class-Path should be changed to something like /Class-Path/d.  The reason is that if upstream modifies this line (which is likely as it contains dependency versions) you may easily miss this during package update, leafing to Class-Path sneaking into manifest.

Ant config file in ant.d should not list ant itself.  It should be marked as %config instead of %config(noreplace)

Comment 2 gil cattaneo 2014-02-25 16:22:16 UTC
No longer required


Note You need to log in before you can comment on or make changes to this bug.