Spec URL: http://ablu.fedorapeople.org/flare-engine.spec SRPM URL: http://ablu.fedorapeople.org/flare-engine-0.19-1.fc20.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6583078 Fedora Account System Username: ablu Description: Flare (Free Libre Action Roleplaying Engine) is a simple game engine built to handle a very specific kind of game: single-player 2D action RPGs. Flare is not a re-implementation of an existing game or engine. It is a tribute to and exploration of the action RPG genre. Rather than building a very abstract, robust game engine, the goal of this project is to build several real games and harvest an engine from the common, reusable code. The first game, in progress, is a fantasy dungeon crawl. Flare uses simple file formats (INI style config files) for most of the game data, allowing anyone to easily modify game contents. Open formats are preferred (png, ogg). The game code is C++. This package contains the engine only. rpmlint: flare-engine.src: W: spelling-error %description -l en_US config -> con fig, con-fig, configure flare-engine.src: W: spelling-error %description -l en_US png -> pg, ping, pang flare-engine.src: W: spelling-error %description -l en_US ogg -> egg, org, boggy flare-engine.x86_64: W: spelling-error %description -l en_US config -> con fig, con-fig, configure flare-engine.x86_64: W: spelling-error %description -l en_US png -> pg, ping, pang flare-engine.x86_64: W: spelling-error %description -l en_US ogg -> egg, org, boggy 3 packages and 0 specfiles checked; 0 errors, 6 warnings. This package is splitting out the engine out of the current flare package in order to allow other flare mods being packaged. Regards, Erik
Trying to assign to Christopher Meng as he requested in #1052191. But no idea if i am doing it right...
Apply http://ablu.fedorapeople.org/0001-Updated-to-0.19-release-split-out-engine-code.patch to the fedora flare package repository if you want to test a packaged mod against the engine. Regards, Erik
Are you still interested in reviewing this?
I'm sorry for the delay, I will review it tomorrow.
Ah. no rush. I was just interested wether you still have time. I myself did not had time for nearly a month now and can now start to care about all this stuff again :)
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [?]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3 or later)", "Unknown or generated", "zlib/libpng". 4 files have unknown license. Detailed output of licensecheck: GPL (v3 or later) ----------------- flare-engine.0.19/src/AStarContainer.cpp flare-engine.0.19/src/AStarContainer.h flare-engine.0.19/src/AStarNode.cpp flare-engine.0.19/src/AStarNode.h flare-engine.0.19/src/Animation.cpp flare-engine.0.19/src/Animation.h flare-engine.0.19/src/AnimationManager.cpp flare-engine.0.19/src/AnimationManager.h flare-engine.0.19/src/AnimationSet.cpp flare-engine.0.19/src/AnimationSet.h flare-engine.0.19/src/Avatar.cpp flare-engine.0.19/src/Avatar.h flare-engine.0.19/src/BehaviorAlly.cpp flare-engine.0.19/src/BehaviorAlly.h flare-engine.0.19/src/BehaviorStandard.cpp flare-engine.0.19/src/BehaviorStandard.h flare-engine.0.19/src/CampaignManager.cpp flare-engine.0.19/src/CampaignManager.h flare-engine.0.19/src/CombatText.cpp flare-engine.0.19/src/CombatText.h flare-engine.0.19/src/CommonIncludes.h flare-engine.0.19/src/EffectManager.cpp flare-engine.0.19/src/EffectManager.h flare-engine.0.19/src/Enemy.cpp flare-engine.0.19/src/Enemy.h flare-engine.0.19/src/EnemyBehavior.cpp flare-engine.0.19/src/EnemyBehavior.h flare-engine.0.19/src/EnemyGroupManager.cpp flare-engine.0.19/src/EnemyGroupManager.h flare-engine.0.19/src/EnemyManager.cpp flare-engine.0.19/src/EnemyManager.h flare-engine.0.19/src/Entity.cpp flare-engine.0.19/src/Entity.h flare-engine.0.19/src/EventManager.cpp flare-engine.0.19/src/EventManager.h flare-engine.0.19/src/FileParser.cpp flare-engine.0.19/src/FileParser.h flare-engine.0.19/src/FontEngine.cpp flare-engine.0.19/src/FontEngine.h flare-engine.0.19/src/GameState.cpp flare-engine.0.19/src/GameState.h flare-engine.0.19/src/GameStateConfig.cpp flare-engine.0.19/src/GameStateConfig.h flare-engine.0.19/src/GameStateCutscene.cpp flare-engine.0.19/src/GameStateCutscene.h flare-engine.0.19/src/GameStateLoad.cpp flare-engine.0.19/src/GameStateLoad.h flare-engine.0.19/src/GameStateNew.cpp flare-engine.0.19/src/GameStateNew.h flare-engine.0.19/src/GameStatePlay.cpp flare-engine.0.19/src/GameStatePlay.h flare-engine.0.19/src/GameStateTitle.cpp flare-engine.0.19/src/GameStateTitle.h flare-engine.0.19/src/GameSwitcher.cpp flare-engine.0.19/src/GameSwitcher.h flare-engine.0.19/src/GetText.cpp flare-engine.0.19/src/GetText.h flare-engine.0.19/src/Hazard.h flare-engine.0.19/src/HazardManager.cpp flare-engine.0.19/src/HazardManager.h flare-engine.0.19/src/ImageManager.cpp flare-engine.0.19/src/ImageManager.h flare-engine.0.19/src/InputState.cpp flare-engine.0.19/src/InputState.h flare-engine.0.19/src/ItemManager.cpp flare-engine.0.19/src/ItemManager.h flare-engine.0.19/src/ItemStorage.cpp flare-engine.0.19/src/ItemStorage.h flare-engine.0.19/src/Loot.cpp flare-engine.0.19/src/Loot.h flare-engine.0.19/src/LootManager.cpp flare-engine.0.19/src/LootManager.h flare-engine.0.19/src/Map.cpp flare-engine.0.19/src/Map.h flare-engine.0.19/src/MapCollision.cpp flare-engine.0.19/src/MapCollision.h flare-engine.0.19/src/MapRenderer.cpp flare-engine.0.19/src/MapRenderer.h flare-engine.0.19/src/Menu.cpp flare-engine.0.19/src/Menu.h flare-engine.0.19/src/MenuActionBar.cpp flare-engine.0.19/src/MenuActionBar.h flare-engine.0.19/src/MenuActiveEffects.cpp flare-engine.0.19/src/MenuActiveEffects.h flare-engine.0.19/src/MenuCharacter.cpp flare-engine.0.19/src/MenuCharacter.h flare-engine.0.19/src/MenuConfirm.cpp flare-engine.0.19/src/MenuConfirm.h flare-engine.0.19/src/MenuEnemy.cpp flare-engine.0.19/src/MenuEnemy.h flare-engine.0.19/src/MenuExit.cpp flare-engine.0.19/src/MenuExit.h flare-engine.0.19/src/MenuHUDLog.cpp flare-engine.0.19/src/MenuHUDLog.h flare-engine.0.19/src/MenuInventory.cpp flare-engine.0.19/src/MenuInventory.h flare-engine.0.19/src/MenuItemStorage.cpp flare-engine.0.19/src/MenuItemStorage.h flare-engine.0.19/src/MenuLog.cpp flare-engine.0.19/src/MenuLog.h flare-engine.0.19/src/MenuManager.cpp flare-engine.0.19/src/MenuManager.h flare-engine.0.19/src/MenuMiniMap.cpp flare-engine.0.19/src/MenuMiniMap.h flare-engine.0.19/src/MenuNPCActions.cpp flare-engine.0.19/src/MenuNPCActions.h flare-engine.0.19/src/MenuPowers.cpp flare-engine.0.19/src/MenuPowers.h flare-engine.0.19/src/MenuStash.cpp flare-engine.0.19/src/MenuStash.h flare-engine.0.19/src/MenuStatBar.cpp flare-engine.0.19/src/MenuStatBar.h flare-engine.0.19/src/MenuTalker.cpp flare-engine.0.19/src/MenuTalker.h flare-engine.0.19/src/MenuVendor.cpp flare-engine.0.19/src/MenuVendor.h flare-engine.0.19/src/MessageEngine.cpp flare-engine.0.19/src/MessageEngine.h flare-engine.0.19/src/ModManager.cpp flare-engine.0.19/src/ModManager.h flare-engine.0.19/src/NPC.cpp flare-engine.0.19/src/NPC.h flare-engine.0.19/src/NPCManager.cpp flare-engine.0.19/src/NPCManager.h flare-engine.0.19/src/PowerManager.cpp flare-engine.0.19/src/PowerManager.h flare-engine.0.19/src/QuestLog.cpp flare-engine.0.19/src/QuestLog.h flare-engine.0.19/src/SaveLoad.cpp flare-engine.0.19/src/Settings.cpp flare-engine.0.19/src/Settings.h flare-engine.0.19/src/SharedGameResources.cpp flare-engine.0.19/src/SharedGameResources.h flare-engine.0.19/src/SharedResources.cpp flare-engine.0.19/src/SharedResources.h flare-engine.0.19/src/SoundManager.cpp flare-engine.0.19/src/SoundManager.h flare-engine.0.19/src/StatBlock.cpp flare-engine.0.19/src/StatBlock.h flare-engine.0.19/src/Stats.cpp flare-engine.0.19/src/Stats.h flare-engine.0.19/src/TileSet.cpp flare-engine.0.19/src/TileSet.h flare-engine.0.19/src/TooltipData.cpp flare-engine.0.19/src/TooltipData.h flare-engine.0.19/src/Utils.cpp flare-engine.0.19/src/Utils.h flare-engine.0.19/src/UtilsDebug.cpp flare-engine.0.19/src/UtilsDebug.h flare-engine.0.19/src/UtilsFileSystem.cpp flare-engine.0.19/src/UtilsFileSystem.h flare-engine.0.19/src/UtilsMath.h flare-engine.0.19/src/UtilsParsing.cpp flare-engine.0.19/src/UtilsParsing.h flare-engine.0.19/src/Widget.cpp flare-engine.0.19/src/Widget.h flare-engine.0.19/src/WidgetButton.cpp flare-engine.0.19/src/WidgetButton.h flare-engine.0.19/src/WidgetCheckBox.cpp flare-engine.0.19/src/WidgetCheckBox.h flare-engine.0.19/src/WidgetInput.cpp flare-engine.0.19/src/WidgetInput.h flare-engine.0.19/src/WidgetLabel.cpp flare-engine.0.19/src/WidgetLabel.h flare-engine.0.19/src/WidgetListBox.cpp flare-engine.0.19/src/WidgetListBox.h flare-engine.0.19/src/WidgetScrollBar.cpp flare-engine.0.19/src/WidgetScrollBar.h flare-engine.0.19/src/WidgetScrollBox.cpp flare-engine.0.19/src/WidgetScrollBox.h flare-engine.0.19/src/WidgetSlider.cpp flare-engine.0.19/src/WidgetSlider.h flare-engine.0.19/src/WidgetSlot.cpp flare-engine.0.19/src/WidgetSlot.h flare-engine.0.19/src/WidgetTabControl.cpp flare-engine.0.19/src/WidgetTabControl.h flare-engine.0.19/src/WidgetTooltip.cpp flare-engine.0.19/src/WidgetTooltip.h flare-engine.0.19/src/main.cpp Unknown or generated -------------------- flare-engine.0.19/astyle_flare.sh flare-engine.0.19/extract_xml.sh flare-engine.0.19/src/Hazard.cpp flare-engine.0.19/src/resource.h zlib/libpng ----------- flare-engine.0.19/src/SDL_gfxBlitFunc.c [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/flare(flare-data) [?]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1034240 bytes in /usr/share [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: flare-engine-0.19-1.fc22.i686.rpm flare-engine-0.19-1.fc22.src.rpm flare-engine.i686: W: spelling-error %description -l en_US config -> con fig, con-fig, configure flare-engine.i686: W: spelling-error %description -l en_US png -> pg, ping, pang flare-engine.i686: W: spelling-error %description -l en_US ogg -> egg, org, foggy flare-engine.src: W: spelling-error %description -l en_US config -> con fig, con-fig, configure flare-engine.src: W: spelling-error %description -l en_US png -> pg, ping, pang flare-engine.src: W: spelling-error %description -l en_US ogg -> egg, org, foggy 2 packages and 0 specfiles checked; 0 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint flare-engine flare-engine.i686: W: spelling-error %description -l en_US config -> con fig, con-fig, configure flare-engine.i686: W: spelling-error %description -l en_US png -> pg, ping, pang flare-engine.i686: W: spelling-error %description -l en_US ogg -> egg, org, foggy 1 packages and 0 specfiles checked; 0 errors, 3 warnings. # echo 'rpmlint-done:' Requires -------- flare-engine (rpmlib, GLIBC filtered): libSDL-1.2.so.0 libSDL_gfx.so.15 libSDL_image-1.2.so.0 libSDL_mixer-1.2.so.0 libSDL_ttf-2.0.so.0 libc.so.6 libgcc_s.so.1 libm.so.6 libpthread.so.0 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) rtld(GNU_HASH) Provides -------- flare-engine: flare-engine flare-engine(x86-32) Source checksums ---------------- http://downloads.sourceforge.net/project/flare-game/Linux/flare-engine.0.19.tar.gz : CHECKSUM(SHA256) this package : 69811133b22c2c95ca7f35f0db6e63b693e646a433843c0f1c50a2d7f4d581e1 CHECKSUM(SHA256) upstream package : 69811133b22c2c95ca7f35f0db6e63b693e646a433843c0f1c50a2d7f4d581e1 Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/bin/fedora-review -rvn flare-engine-0.19-1.fc20.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG ---------------------------- 1. SDL_gfx code bundled, can you clarify the issue with upstream, I need an explanation. 2. /usr/lib/ccache/c++ -DDATA_INSTALL_DIR=\"/usr/share/flare/\" -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m32 -march=i686 -mtune=atom -fasynchronous-unwind-tables -Wall -Wextra -Wunused -Wshadow -Woverloaded-virtual -Wunreachable-code -fno-math-errno -fno-exceptions -ffast-math -I/usr/include/SDL -o CMakeFiles/flare.dir/src/WidgetScrollBar.cpp.o -c /builddir/build/BUILD/flare-engine.0.19/src/WidgetScrollBar.cpp As you can see(pick-up example from the build.log), Fedora specific CXXFLAGS is set before the custom flags defined by the upstream(-Wall -Wextra -Wunused -Wshadow -Woverloaded-virtual -Wunreachable-code -fno-math-errno -fno-exceptions). If in the future they modify by adding some flags may confuse debuginfo, or cause wrong optimization like O3, you can't find them in the first time. 3. It bundles liberation-sans-fonts. Please use symlink and add explicit requires on this font package. 4. changelog invalid, email addr needed. * Sat Mar 01 2014 Erik Schilling - 0.19-1 Hint: for F21+, make install DESTDIR=%{buildroot} = %make_install make %{?_smp_mflags} = %make_build
SPEC: https://ablu.fedorapeople.org/flare-engine.spec SRPM: https://ablu.fedorapeople.org/flare-engine-0.19-2.fc20.src.rpm DIFF: http://sprunge.us/BMHZ?diff KOJI: http://koji.fedoraproject.org/koji/taskinfo?taskID=7227482 - Actually apply system gfx patch - Disallow the project to override environment compiler flags - Delete bundeled ttf and use symlink - Added missing mail address to changelog Thanks a lot for the quick review :) Regards, Erik
Append -print to "find %{buildroot}%{_datadir}/%{shortname}/ -name "*.ttf" -delete" in case that upstream may add more fonts in the future, it will help you figure out the issue faster. ---------------------------- PACKAGE APPROVED.
Thanks a lot! New Package SCM Request ======================= Package Name: flare-engine Short Description: A single player, 2D-isometric, action Role-Playing Engine Upstream URL: http://flarerpg.org/ Owners: ablu Branches: f19 f20 f21 InitialCC:
Git done (by process-git-requests).
Thanks :)
No builds so far.
I sadly have a lot less time than expected. Also I wanted to sync this with the flare package update. I already made all changes and in theory only need to push. I hope I will be able to do a final test this evening and trigger builds then. Sorry for the delay.
Builds are running now.
flare-0.19-2.fc19,flare-engine-0.19-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/flare-0.19-2.fc19,flare-engine-0.19-3.fc19
flare-0.19-2.fc20,flare-engine-0.19-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/flare-0.19-2.fc20,flare-engine-0.19-3.fc20
Package flare-0.19-2.fc19, flare-engine-0.19-3.fc19: * should fix your issue, * was pushed to the Fedora 19 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing flare-0.19-2.fc19 flare-engine-0.19-3.fc19' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-9680/flare-0.19-2.fc19,flare-engine-0.19-3.fc19 then log in and leave karma (feedback).
flare-0.19-2.fc20, flare-engine-0.19-3.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
flare-0.19-2.fc19, flare-engine-0.19-3.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.