Bug 1071874 - Login page not displayed - missing i18n resource for english
Summary: Login page not displayed - missing i18n resource for english
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss BPMS Platform 6
Classification: Retired
Component: BAM
Version: 6.0.1
Hardware: Unspecified
OS: Unspecified
urgent
urgent
Target Milestone: ER2
: 6.0.1
Assignee: David Gutierrez
QA Contact: Jan Hrcek
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-03-03 11:24 UTC by Jan Hrcek
Modified: 2014-08-06 20:02 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-08-06 20:02:57 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Jan Hrcek 2014-03-03 11:24:21 UTC
Description of problem:
After clean installation of BPMS 6.0.1 ER2 and going to http://localhost:8080/dashbuilder I'm getting:

HTTP Status 500 - java.util.MissingResourceException: Can't find bundle for base name org.jboss.dashboard.login, locale en

I believe that there is some conflict between product build configuration with the recent fix for Bug 1065271.

Version-Release number of selected component (if applicable):
BPMS 6.0.1 ER2

How reproducible:
Always

Steps to Reproduce:
1. Perform clean installation of BPMS (unzip EAP 6.1.1 and then BPMS 6.0.1.ER2 on top of it)
2. Point your browser to http://localhost:8080/dashbuilder

Actual results:
Error page [1] is displayed instead of dashbuilder login page

Expected results:
Login page should be displayed (at minimum in english locale)

Additional info:

[1]

JBWEB000065: HTTP Status 500 - java.util.MissingResourceException: Can't find bundle for base name org.jboss.dashboard.login, locale en

JBWEB000309: type JBWEB000066: Exception report

JBWEB000068: message java.util.MissingResourceException: Can't find bundle for base name org.jboss.dashboard.login, locale en

JBWEB000069: description JBWEB000145: The server encountered an internal error that prevented it from fulfilling this request.

JBWEB000070: exception

org.apache.jasper.JasperException: java.util.MissingResourceException: Can't find bundle for base name org.jboss.dashboard.login, locale en
	org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:409)
	org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:309)
	org.apache.jasper.servlet.JspServlet.service(JspServlet.java:242)
	javax.servlet.http.HttpServlet.service(HttpServlet.java:847)

JBWEB000071: root cause

java.util.MissingResourceException: Can't find bundle for base name org.jboss.dashboard.login, locale en
	java.util.ResourceBundle.throwMissingResourceException(ResourceBundle.java:1499)
	java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1322)
	java.util.ResourceBundle.getBundle(ResourceBundle.java:796)
	org.apache.jsp.login_jsp._jspService(login_jsp.java:88)
	org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:69)
	javax.servlet.http.HttpServlet.service(HttpServlet.java:847)
	org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:365)
	org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:309)
	org.apache.jasper.servlet.JspServlet.service(JspServlet.java:242)
	javax.servlet.http.HttpServlet.service(HttpServlet.java:847)

Comment 1 Jan Hrcek 2014-03-03 12:29:30 UTC
Here's a link for ER2 build for your convenience (use jboss-bpms-6.0.1.GA-redhat-2-deployable-eap6.x.zip) http://dev138.mw.lab.eng.bos.redhat.com/candidate/bpms-6.0.1-ER2/

Comment 2 Pedro Zapata 2014-03-03 12:34:23 UTC
The following change in login.jsp was lost during the tag creation merge process.
https://github.com/droolsjbpm/dashboard-builder/commit/217c48a3286daaa4d5f8bd398a5d6c227b588d8d

in the file modules/dashboard-webapp/src/main/webapp/login.jsp

ResourceBundle i18nBundle = LocaleManager.lookup().getBundle("org.jboss.dashboard.login", currentLocale);

should be:

ResourceBundle i18nBundle = LocaleManager.lookup().getBundle("org.jboss.dashboard.login.messages", currentLocale);

Comment 3 Edson Tirelli 2014-03-03 19:51:19 UTC
David,

It looks like the commit listed by Pedro is being overridden by a commit from the product branch:

[kiereleaseuser@hp-dl380pg8-01 dashboard-builder]$ git log --oneline -6 modules/dashboard-webapp/src/main/webapp/login.jsp
9e9e7b8 BZ1047119 - FavIcon in BPMS and BRMS inconsistent (cherry picked from commit 3cdf23af9c0783abd6ac0aea1513719425148a0d)
234491c BZ-983406 - Productized page title is "KIE workbench" but should be "Business central
dd79cd3 BZ-1004208: Changed skn-input class and refactored some styles.
38892b0 BZ:1007267 - First login into the Dashboard ends with white screen
e4cc8c5 BZ-982548 Apply the redhat branding and apply Rogers's fix for resolving conflict to login.jsp (cherry picked from commit 4758bc319af0a836d6584fc64a3cbf3668175b24)
7608a4c BZ-1065271 - Localization resource bundles for Import Dashboard panel can't be found


As you can see, there are 5 commits in the product branch that touch the same files as your commit and at least one of them is overriding your change. I am afraid the only way to fix this is to re-do the fixes from your commit in the product branch as well.

There is not much Michael or I can do at the tagging time, if one of the existing product commits overrides your changes in the community.

Comment 4 David Gutierrez 2014-03-04 08:08:38 UTC
What I'm wondering about is why any changes in the community bits affecting branding files must be also copied to the product branding branch. I'd guess 6.0.x branch and branding branch to be properly merged and if any conflicts are encountered then engineering would be asked to resolve them.

I know what you propose is a way to avoid conflicts during the merge phase but the problem here is that not every engineer is aware of the potential conflicts a change in community bits can cause.

So I think to overwrite community bits with branding stuff is not a good practice by default. In my opinion conflicts should be handled by hand.

Comment 5 Edson Tirelli 2014-03-04 14:05:11 UTC
David, GIT **is** merging the commits, but always merging the product commits into the community commits. The person doing the release, may or may not get a conflict, depending if GIT is able to merge the changes automatically or not. 

Lets discuss this in detail on a call. Can you please fix this in the product branch meanwhile?

Comment 6 David Gutierrez 2014-03-04 15:34:14 UTC
Fixed.

Github commit (prod-6.0.1.GA.x-2014.02.28): https://github.com/jboss-integration/dashboard-builder/commit/0dbfe9afc3370c2b011684f2bb21c13350d9fee6

Comment 7 Edson Tirelli 2014-03-04 17:16:43 UTC
This was cherry-picked into the 6.0.1.ER2 tag.

Comment 8 Jan Hrcek 2014-03-06 08:44:58 UTC
Ok, verified with BPMS 6.0.1 ER2


Note You need to log in before you can comment on or make changes to this bug.