Bug 1079484 - Review Request: python-lazy - Lazy attributes for python objects
Summary: Review Request: python-lazy - Lazy attributes for python objects
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Christopher Meng
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-03-21 16:41 UTC by David Shea
Modified: 2014-04-14 22:41 UTC (History)
2 users (show)

Fixed In Version: python-lazy-1.1-2.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-04-14 22:34:17 UTC
Type: ---
Embargoed:
i: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description David Shea 2014-03-21 16:41:54 UTC
Spec URL: http://dshea.fedorapeople.org/python-lazy/python-lazy.spec
SRPM URL: http://dshea.fedorapeople.org/python-lazy/python-lazy-1.1-1.fc21.src.rpm

Description:

python-lazy is a python module that provides a decorator to create lazy attributes. Here's the %description copied from the README:

Lazy attributes are computed attributes that are evaluated only once, the first
time they are used.  Subsequent uses return the results of the first call. They
come handy when code should run

- *late*, i.e. just before it is needed, and
- *once*, i.e. not twice, in the lifetime of an object.

You can think of it as deferred initialization.
The possibilities are endless.


Fedora Account System Username: dshea

Comment 1 Christopher Meng 2014-03-25 09:45:11 UTC
%{__rm} --> rm

%{__python} --> %{__python2}

%{__make} --> make

%{__cp} --> cp

%{__mkdir_p} --> mkdir -p

%{python_sitelib} --> %{python2_sitelib}

Comment 3 Christopher Meng 2014-03-28 07:08:50 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated




===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 10 files have unknown license. Detailed output of
     licensecheck:

Unknown or generated
--------------------
lazy-1.1/docs/conf.py
lazy-1.1/lazy/__init__.py
lazy-1.1/lazy/lazy.py
lazy-1.1/lazy/tests/test_lazy.py
lazy-1.1/setup.py

[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 471040 bytes in 54 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[!]: Package meets the Packaging Guidelines::Python
[!]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-lazy
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: python-lazy-1.1-1.fc21.noarch.rpm
          python3-lazy-1.1-1.fc21.noarch.rpm
          python-lazy-1.1-1.fc21.src.rpm
python-lazy.noarch: W: invalid-url URL: https://pypi.python.org/pypi/lazy <urlopen error _ssl.c:492: The handshake operation timed out>
python-lazy.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-lazy-1.1/html/_static/jquery.js
python3-lazy.noarch: W: invalid-url URL: https://pypi.python.org/pypi/lazy <urlopen error _ssl.c:492: The handshake operation timed out>
python3-lazy.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python3-lazy-1.1/html/_static/jquery.js
python-lazy.src: W: invalid-url Source0: https://pypi.python.org/packages/source/l/lazy/lazy-1.1.zip <urlopen error _ssl.c:492: The handshake operation timed out>
3 packages and 0 specfiles checked; 0 errors, 5 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint python3-lazy python-lazy
python3-lazy.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python3-lazy-1.1/html/_static/jquery.js
python-lazy.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-lazy-1.1/html/_static/jquery.js
2 packages and 0 specfiles checked; 0 errors, 2 warnings.
# echo 'rpmlint-done:'



Requires
--------
python3-lazy (rpmlib, GLIBC filtered):
    python(abi)

python-lazy (rpmlib, GLIBC filtered):
    python(abi)



Provides
--------
python3-lazy:
    python3-lazy

python-lazy:
    python-lazy



Source checksums
----------------
https://pypi.python.org/packages/source/l/lazy/lazy-1.1.zip :
  CHECKSUM(SHA256) this package     : 52ed3d79f18ea362cc8f59dd38ac0cafc4b1b9b7f478e0178d31a27a926693d9
  CHECKSUM(SHA256) upstream package : 52ed3d79f18ea362cc8f59dd38ac0cafc4b1b9b7f478e0178d31a27a926693d9


Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review -rvn python-lazy-1.1-1.fc21.src.rpm
Buildroot used: fedora-rawhide-i386
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

----------------------------------
1. mkdir -p %{buildroot}%{_docdir}/python-lazy-%{version}
mkdir -p %{buildroot}%{_docdir}/python3-lazy-%{version}

Unversioned docdir changes are now in operation. 

2. Test suites found, can you test it in %check?

3. Please remove the egg shipped in tarball before building.

4. python-devel --> python2-devel

Comment 4 David Shea 2014-03-28 13:40:24 UTC
(In reply to Christopher Meng from comment #3)

> 1. mkdir -p %{buildroot}%{_docdir}/python-lazy-%{version}
> mkdir -p %{buildroot}%{_docdir}/python3-lazy-%{version}
> 
> Unversioned docdir changes are now in operation. 

Removed -%{version} from all of the docdir paths.

> 
> 2. Test suites found, can you test it in %check?

Done.

> 
> 3. Please remove the egg shipped in tarball before building.

Removed in %prep, so the packaged .egg-info will be the one created during the build.

> 4. python-devel --> python2-devel

Done. 


v3:
SPEC URL: http://dshea.fedorapeople.org/python-lazy/v3/python-lazy.spec
SRPM URL: http://dshea.fedorapeople.org/python-lazy/v3/python-lazy-1.1-1.fc20.src.rpm

Comment 5 David Shea 2014-03-28 15:34:26 UTC
And now that the docdir paths are correct there's no need to list the default _pkgdocdir in the %files for python-lazy, so I removed the %doc line from the v3 SPEC and SRPM.

Comment 6 Christopher Meng 2014-03-30 05:20:20 UTC
PACKAGE APPROVED.

Comment 7 David Shea 2014-03-30 12:54:17 UTC
New Package SCM Request
=======================
Package Name: python-lazy
Short Description: Lazy attributes for python objects
Owners: dshea
Branches: f19 f20
InitialCC:

Comment 8 Gwyn Ciesla 2014-03-31 11:48:13 UTC
Git done (by process-git-requests).

Comment 9 Fedora Update System 2014-03-31 14:02:29 UTC
python-lazy-1.1-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/python-lazy-1.1-1.fc20

Comment 10 Fedora Update System 2014-03-31 14:41:09 UTC
python-lazy-1.1-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/python-lazy-1.1-2.fc20

Comment 11 Fedora Update System 2014-03-31 14:49:01 UTC
python-lazy-1.1-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/python-lazy-1.1-2.fc19

Comment 12 Fedora Update System 2014-04-02 09:20:28 UTC
Package python-lazy-1.1-2.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing python-lazy-1.1-2.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-4661/python-lazy-1.1-2.fc20
then log in and leave karma (feedback).

Comment 13 Fedora Update System 2014-04-14 22:34:17 UTC
python-lazy-1.1-2.fc19 has been pushed to the Fedora 19 stable repository.

Comment 14 Fedora Update System 2014-04-14 22:41:32 UTC
python-lazy-1.1-2.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.