Bug 108049 - %makeinstall should use %__make for make
%makeinstall should use %__make for make
Product: Red Hat Raw Hide
Classification: Retired
Component: redhat-rpm-config (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Elliot Lee
David Lawrence
Depends On:
  Show dependency treegraph
Reported: 2003-10-26 21:55 EST by Jens Petersen
Modified: 2007-04-18 12:58 EDT (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2003-11-03 15:35:31 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
trivial patch to use __make instead (468 bytes, patch)
2003-10-26 22:01 EST, Jens Petersen
no flags Details | Diff

  None (edit)
Description Jens Petersen 2003-10-26 21:55:24 EST
Description of problem:
I think it would be more consistent if %makeinstall was defined to use
%{__make} instead of make.  Could this please be done?
Comment 1 Jens Petersen 2003-10-26 22:01:38 EST
Created attachment 95501 [details]
trivial patch to use __make instead
Comment 2 Jeff Johnson 2003-10-27 12:37:25 EST
Consistent, yes. Worth the effort? Hardly.
Comment 3 Jens Petersen 2003-10-28 08:47:30 EST
It is a trivial patch, where is the effort?
I need this for building emacs on i386 currently...
Comment 4 Jeff Johnson 2003-10-30 07:32:32 EST
Yes, it's a trivial patch, but a huge QA effort to verify
nothing broke by rebuilding everything.

There's nothing forcing you to use %makeinstall,
nor is there any reason that you cannot attempt
redefinition in your xemacs spec file.

Nor is there anything stopping you from changing
%makeinstall in redhat-rpm-config 
Comment 5 Jens Petersen 2003-10-31 01:12:49 EST
Fair'nuf, shooting for redhat-rpm-config instead then.
Comment 6 Jens Petersen 2003-10-31 01:43:44 EST
Elliot, if you're ok with this (for the next release),
can I go ahead and make this change, or do you want to do it?
Comment 7 Elliot Lee 2003-11-03 15:35:31 EST
This is fixed in 

The comments about needing this for emacs worry me though. It
shouldn't be necessary to redefine __make except in very strange
Comment 8 Jens Petersen 2003-11-04 00:34:14 EST
Because I need "__make" to be "setarch i386" to build emacs
on ix86 currently... (bug 101818).
Comment 9 Jens Petersen 2003-11-04 00:34:48 EST
"setarch i386 make" that is.

Note You need to log in before you can comment on or make changes to this bug.