Bug 1080498 - Review Request: golang-github-smarterclayton-go-systemd - Go bindings to systemd D-BUS APIs
Summary: Review Request: golang-github-smarterclayton-go-systemd - Go bindings to syst...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Vincent Batts
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-03-25 14:36 UTC by Lokesh Mandvekar
Modified: 2014-12-07 04:35 UTC (History)
4 users (show)

Fixed In Version: golang-github-smarterclayton-go-systemd-0-0.4.git5cb9e9e.fc19
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-12-06 02:33:28 UTC
Type: ---
Embargoed:
vbatts: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Lokesh Mandvekar 2014-03-25 14:36:26 UTC
Spec URL: http://lsm5.fedorapeople.org/golang-github-smarterclayton-go-systemd/golang-github-smarterclayton-go-systemd.spec
SRPM URL: http://lsm5.fedorapeople.org/golang-github-smarterclayton-go-systemd/SRPMS/golang-github-smarterclayton-go-systemd-0-0.1.git5cb9e9e.fc21.src.rpm

Description:
Go bindings to systemd socket activation, journal and D-BUS APIs

Fedora Account System Username: lsm5

Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6672004

$ rpmlint golang-github-smarterclayton-go-systemd.spec RPMS/noarch/golang-github-smarterclayton-go-systemd-devel-0-0.1.git5cb9e9e.fc21.noarch.rpm SRPMS/golang-github-smarterclayton-go-systemd-0-0.1.git5cb9e9e.fc21.src.rpm 
golang-github-smarterclayton-go-systemd.spec:38: W: setup-not-quiet
golang-github-smarterclayton-go-systemd.src:38: W: setup-not-quiet
2 packages and 1 specfiles checked; 0 errors, 2 warnings.

Comment 1 Lokesh Mandvekar 2014-03-25 15:14:43 UTC
Spec URL: http://lsm5.fedorapeople.org/golang-github-smarterclayton-go-systemd/golang-github-smarterclayton-go-systemd.spec
SRPM URL: http://lsm5.fedorapeople.org/golang-github-smarterclayton-go-systemd/SRPMS/golang-github-smarterclayton-go-systemd-0-0.2.git5cb9e9e.fc21.src.rpm

go test commented out for now, but otherwise shows this:

+ GOPATH=/usr/share/gocode:/home/lsm5/repositories/pkgs/fedora/golang-github-smarterclayton-go-systemd/BUILDROOT/golang-github-smarterclayton-go-systemd-0-0.2.git5cb9e9e.fc21.x86_64//usr/share/gocode
+ go test github.com/smarterclayton/go-systemd/dbus
--- FAIL: TestStartStopUnit (0.01 seconds)
	methods_test.go:57: Expected one change, got %v []
--- FAIL: TestSubscriptionSetUnit (0.01 seconds)
	methods_test.go:57: Expected one change, got %v []
--- FAIL: TestSubscribeUnit (0.01 seconds)
	methods_test.go:57: Expected one change, got %v []
FAIL
FAIL	github.com/smarterclayton/go-systemd/dbus	0.267s
error: Bad exit status from /var/tmp/rpm-tmp.2gcWzP (%check)

Comment 2 Lokesh Mandvekar 2014-03-26 15:11:51 UTC
%changelog
* Wed Mar 26 2014 Lokesh Mandvekar <lsm5> 0-0.4.git
- summary update

* Tue Mar 25 2014 Lokesh Mandvekar <lsm5> 0-0.3.git
- rm dirs excluded from package


Spec URL: http://lsm5.fedorapeople.org/golang-github-smarterclayton-go-systemd/golang-github-smarterclayton-go-systemd.spec
SRPM URL: http://lsm5.fedorapeople.org/golang-github-smarterclayton-go-systemd/SRPMS/golang-github-smarterclayton-go-systemd-0-0.4.git5cb9e9e.fc21.src.rpm

Comment 3 Vincent Batts 2014-03-26 15:27:10 UTC
Those tests will be best commented out, since they actually affect the system's dbus and check the changes. this is not going to fly for koji build environments.
Without the test, we can drop the "BuildRequires:  golang(github.com/guelfey/go.dbus)
"

Otherwise it looks good.

Comment 4 Lokesh Mandvekar 2014-03-26 15:54:34 UTC
Yup, done in 0-0.4

Comment 5 Vincent Batts 2014-03-27 18:18:20 UTC
I see. Thanks!

Comment 6 Lokesh Mandvekar 2014-03-28 15:26:49 UTC
New Package SCM Request
=======================
Package Name: golang-github-smarterclayton-go-systemd
Short Description: Go bindings to systemd D-BUS APIs
Owners: lsm5
Branches: f19 f20 el6 epel7
InitialCC: golang-sig

Comment 7 Gwyn Ciesla 2014-03-28 15:54:46 UTC
Git done (by process-git-requests).

Comment 8 Fedora Update System 2014-03-28 20:56:24 UTC
golang-github-smarterclayton-go-systemd-0-0.4.git5cb9e9e.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/golang-github-smarterclayton-go-systemd-0-0.4.git5cb9e9e.fc19

Comment 9 Fedora Update System 2014-03-28 20:57:12 UTC
golang-github-smarterclayton-go-systemd-0-0.4.git5cb9e9e.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/golang-github-smarterclayton-go-systemd-0-0.4.git5cb9e9e.fc20

Comment 10 Fedora Update System 2014-03-28 20:57:51 UTC
golang-github-smarterclayton-go-systemd-0-0.4.git5cb9e9e.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/golang-github-smarterclayton-go-systemd-0-0.4.git5cb9e9e.el6

Comment 11 Fedora Update System 2014-03-29 19:16:21 UTC
golang-github-smarterclayton-go-systemd-0-0.4.git5cb9e9e.el6 has been pushed to the Fedora EPEL 6 testing repository.

Comment 13 Fedora Update System 2014-12-06 02:33:28 UTC
golang-github-smarterclayton-go-systemd-0-0.4.git5cb9e9e.fc20 has been pushed to the Fedora 20 stable repository.

Comment 14 Fedora Update System 2014-12-07 04:35:23 UTC
golang-github-smarterclayton-go-systemd-0-0.4.git5cb9e9e.fc19 has been pushed to the Fedora 19 stable repository.


Note You need to log in before you can comment on or make changes to this bug.