Red Hat Bugzilla – Bug 108213
LTC5169 - ethtool -S not working with the e1000 driver
Last modified: 2007-11-30 17:06:59 EST
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3.1) Gecko/20030425
Description of problem:
1 Goliad adapter
Steps to Reproduce:
1.run ethtool -S eth1
it will return:
Operation not supported.
Should give all the Intel Gigabit adapter statistis. The e1000 driver supports
it, the problem is withShould give all the Intel Gigabit adapter statistis.
Ethtool needs to get updated to support "-S" for the e1000 driver.
The problem in SLES8 was that both ETHTOOL_GSTRINGS and ETHTOOL_GSTATS were not
mapped by arch/ppc64/kernel/ioctl32.c::ethtool_ioctl()
They need to check these on RedHat.
------- Additional Comment #4 From Olof Johansson 2003-10-28 12:11 -------
This has been fixed in ameslab BK, so RedHat can pick it up from there. I'll
open up a mirror bug.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
I will attach a proposed patch to the RHEL 3 sources to correct this problem. If
you guys (IBM) get a chance to test it, it would be appreciated. I have verified
Created attachment 95588 [details]
Patch for ethtool -S <netdev> against RHEL 3 released product.
The problem was only a problem for ethtool compiled as a 32-bit application.
Worked fine as a 64-bit app.
------- Additional Comments From email@example.com 2003-30-10 21:21 -------
Rick, can you test the patch RH provided? They have modified the ioctl layers,
so the BK patch doesn't apply to their tree.
What |Removed |Added
------- Additional Comments From firstname.lastname@example.org 2003-31-10 13:07 -------
I just tested the patch and it works now. Defect has been fixed.
------- Additional Comments From email@example.com 2003-31-10 13:09 -------
When would we expect this patch to be in the RHEL3 distro. ?
Thank you for testing this patch. A suggestion was made from a kernel team
member for an improved version which I'd like to explore. My plan is to try the
second version and post it to here if all goes well. Either way, I expect this
issue to be resolved within the coming week.
But to answer your question, this problem will be fixed in Update 1 for RHEL 3.
Created attachment 95637 [details]
A second way to solve this problem
This patch creates a much simpler ethtool_ioctl interface for 32-bit apps. All
ioctl commands are supported this way (both now and with future drivers). This
code borrow heavily from the 2.5 code. A patch review by IBM would be
appreciated as would testing of this patch. It has been tested here and appears
to work, but futher verification is always nice.
------- Additional Comments From firstname.lastname@example.org 2003-31-10 17:44 -------
Julie, appropriate review method would be to post on linuxppc64-dev. Thanks.
The second patch was submitted on 05-OCT-03 and should appear in Update 1.
Closing on our side after verifying with IBM.