Bug 1084960 - supermin fails if TMPDIR contains space
Summary: supermin fails if TMPDIR contains space
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: supermin
Version: 20
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Richard W.M. Jones
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1084921
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-04-07 11:47 UTC by Richard W.M. Jones
Modified: 2014-04-17 06:00 UTC (History)
5 users (show)

Fixed In Version: supermin-5.1.7-2.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of: 1084921
Environment:
Last Closed: 2014-04-17 06:00:56 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Richard W.M. Jones 2014-04-07 11:47:35 UTC
+++ This bug was initially created as a clone of Bug #1084921 +++

Description of problem:
When setting at TMPDIR to a path that contains a white space, supermin is failing with an error.

Version-Release number of selected component (if applicable):
supermin: 5.1.6
libguestfs: 1.26.0

How reproducible:
Set TMPDIR to a path that includes a white space and try to use virt virt-sparsify

Steps to Reproduce:
1. export TMPDIR="/tmp/foo bar"
2. Run virt-sparsify

Actual results:
Fails with:

supermin: ext2: creating empty ext2 filesystem '/media/bigon/Little disk/.guestfs-1000/appliance.d.p4ovrvj6/root'
mke2fs: invalid blocks 'disk/.guestfs-1000/appliance.d.p4ovrvj6/root' on device '/media/bigon/Little'

Expected results:
The appliance is built and virt-sparsify can run

Additional info:

--- Additional comment from Richard W.M. Jones on 2014-04-07 07:46:43 EDT ---

There was missing quoting around the call out to mke2fs.  I
have fix it in this commit:

https://github.com/libguestfs/supermin/commit/ae88217aa64f1924ff88941d2ad0ce1aa6ad7fc4

I tested libguestfs-test-tool with this and TMPDIR pointing
to a directory containing a space, and everything else seems
to work.

Comment 1 Fedora Update System 2014-04-07 12:20:56 UTC
supermin-5.1.7-2.fc20, libguestfs-1.26.0-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/FEDORA-2014-4532/supermin-5.1.7-2.fc20,libguestfs-1.26.0-1.fc20

Comment 2 Fedora Update System 2014-04-09 00:54:05 UTC
Package supermin-5.1.7-2.fc20, libguestfs-1.26.0-1.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing supermin-5.1.7-2.fc20 libguestfs-1.26.0-1.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-4532/supermin-5.1.7-2.fc20,libguestfs-1.26.0-1.fc20
then log in and leave karma (feedback).

Comment 3 Fedora Update System 2014-04-17 06:00:56 UTC
supermin-5.1.7-2.fc20, libguestfs-1.26.0-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.