SPEC: http://v3.sk/~lkundrak/SPECS/python-cassandra-driver.spec SRPM: http://v3.sk/~lkundrak/SRPMS/python-scales-1.0.3-1.el7.src.rpm Description: A Python client driver for Apache Cassandra. This driver works exclusively with the Cassandra Query Language v3 (CQL3) and Cassandra's native protocol. As such, only Cassandra 1.2+ is supported.
Depends on bug #1088281
SRPM (correct link): http://v3.sk/~lkundrak/SRPMS/python-cassandra-driver-1.0.2-1.el7.src.rpm - version 1.1.0 is available (10 minutes ago :)) - %{__python} should be %{__python2}, the same for python sitelib. You can use python3 then. - nose tests are available, please add %check section - rpmlint python-cassandra-driver.spec:11: W: mixed-use-of-spaces-and-tabs (spaces: line 11, tab: line 1) 0 packages and 1 specfiles checked; 0 errors, 1 warnings.
SPEC: http://v3.sk/~lkundrak/SPECS/python-cassandra-driver.spec SRPM: http://v3.sk/~lkundrak/SRPMS/python-cassandra-driver-1.1.1-1.fc21.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions - Edit license info Note: See Generic MUST items ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. cassandra/util.py and cassandra/murmur3.c are licensed with MIT [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-cassandra-driver-1.1.1-1.fc21.x86_64.rpm python-cassandra-driver-1.1.1-1.fc21.src.rpm python-cassandra-driver.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/cassandra/io/libevwrapper.so 0775L python-cassandra-driver.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/cassandra/murmur3.so 0775L 2 packages and 0 specfiles checked; 2 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint python-cassandra-driver python-cassandra-driver.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/cassandra/io/libevwrapper.so 0775L python-cassandra-driver.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/cassandra/murmur3.so 0775L 1 packages and 0 specfiles checked; 2 errors, 0 warnings. # echo 'rpmlint-done:' Requires -------- python-cassandra-driver (rpmlib, GLIBC filtered): libc.so.6()(64bit) libev.so.4()(64bit) libpthread.so.0()(64bit) libpython2.7.so.1.0()(64bit) python(abi) python-blist python-futures python-scales rtld(GNU_HASH) Provides -------- python-cassandra-driver: python-cassandra-driver python-cassandra-driver(x86-64) Unversioned so-files -------------------- python-cassandra-driver: /usr/lib64/python2.7/site-packages/cassandra/io/libevwrapper.so python-cassandra-driver: /usr/lib64/python2.7/site-packages/cassandra/murmur3.so Source checksums ---------------- https://github.com/datastax/python-driver/archive/840064a9e27929c5f44ba06b72bfc3e69d905ee6/python-driver-840064a9e27929c5f44ba06b72bfc3e69d905ee6.tar.gz : CHECKSUM(SHA256) this package : eccbb8b49c7f1b5198c212492a32764ea7f6560a3015d9dac90784766a82bc0e CHECKSUM(SHA256) upstream package : eccbb8b49c7f1b5198c212492a32764ea7f6560a3015d9dac90784766a82bc0e Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -n python-cassandra-driver Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api, C/C++ Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG ---------------------------------- Please check and solve issues.
Thank you. Updated package: SPEC: http://v3.sk/~lkundrak/SPECS/python-cassandra-driver.spec SRPM: http://v3.sk/~lkundrak/SRPMS/python-cassandra-driver-1.1.1-2.el7.src.rpm
Looks good, package approved.
Thank you. New Package SCM Request ======================= Package Name: python-cassandra-driver Short Description: DataStax Python Driver for Apache Cassandra Owners: lkundrak filabrazilska Branches: f19 f20 el6 epel7
Git done (by process-git-requests).
Imported and built. Thank you.