(In reply to Sophie Kovalevsky from comment #0)
> This is a good circuit simulator written on python2.
> 
> Spec URL: http://sophiekovalevsky.fedorapeople.org/RPM/ahkab/ahkab.spec
> SRPM URL:
> http://sophiekovalevsky.fedorapeople.org/RPM/ahlab/ahkab-0.09-1.fc20.src.rpm

Please, fix the SRPM URL.

Thanks Antonio.

Here's again:

Spec URL: http://sophiekovalevsky.fedorapeople.org/RPM/ahkab/ahkab.spec
SRPM URL: http://sophiekovalevsky.fedorapeople.org/RPM/ahkab/ahkab-0.09-1.fc20.src.rpm

The compilation fails:

...
+ /usr/bin/python2 setup.py build
Traceback (most recent call last):
  File "setup.py", line 3, in <module>
    from setuptools import setup, find_packages
ImportError: No module named setuptools

There is a missing BR package.

>BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

Will you package this software in EPEL5, too ?

Not in this moment.

(In reply to Sophie Kovalevsky from comment #4)
> Not in this moment.

Okay, if it is not for EPEL5, then you can remove these lines:

BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
..
%defattr(-,root,root)

Here are the url with the new changes: 

Spec URL: http://sophiekovalevsky.fedorapeople.org/RPM/ahkab/ahkab.spec
SRPM URL: http://sophiekovalevsky.fedorapeople.org/RPM/ahkab/ahkab-0.09-2.fc20.src.rpm

1- Note: Dirs in package are owned also by: /usr/lib/python2.7/site-packages
     (python-libs)

%files
%doc README.md COPYING NEWS.md
%{python2_sitelib}/

In this way, your package owns %{python2_sitelib}/ entirely.
Please, change

 %{python2_sitelib}/  ---->  %{python2_sitelib}/ahkab/

2- ?.egg-info file is not packaged.

3- Fix executable permissions errors of

/usr/lib/python2.7/site-packages/ahkab/__main__.py 0644L
/usr/lib/python2.7/site-packages/ahkab/ahkab.py 0644L

 -- Minor issues --

4- Please, fix the permissions of your spec file. 

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "GPL (v2)", "Unknown or generated". 7 files have unknown license.
     Detailed output of licensecheck in
     /home/sagitter/1089017-ahkab/licensecheck.txt
[!]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/lib/python2.7/site-packages
     (python-libs)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 30720 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build process.
[!]: A package which is used by another package via an egg interface should
     provide egg info.
[!]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: ahkab-0.09-2.fc21.noarch.rpm
          ahkab-0.09-2.fc21.src.rpm
ahkab.noarch: E: explicit-lib-dependency python-matplotlib
ahkab.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ahkab/__main__.py 0644L /usr/bin/env
ahkab.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ahkab/ahkab.py 0644L /usr/bin/env
ahkab.src: W: strange-permission ahkab.spec 0666L
ahkab.src:39: W: macro-in-%changelog %defattr
2 packages and 0 specfiles checked; 3 errors, 2 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint ahkab
ahkab.noarch: E: explicit-lib-dependency python-matplotlib
ahkab.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ahkab/__main__.py 0644L /usr/bin/env
ahkab.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ahkab/ahkab.py 0644L /usr/bin/env
1 packages and 0 specfiles checked; 3 errors, 0 warnings.
# echo 'rpmlint-done:'



Requires
--------
ahkab (rpmlib, GLIBC filtered):
    numpy
    python
    python(abi)
    python-matplotlib
    sympy



Provides
--------
ahkab:
    ahkab



Source checksums
----------------
https://github.com/ahkab/ahkab/archive/036a6ce4c142356d8f9c004c1c3c05d31b85c16d/ahkab-036a6ce4c142356d8f9c004c1c3c05d31b85c16d.tar.gz :
  CHECKSUM(SHA256) this package     : 04cd2ac61cd3980f81eba5b197e152de0e8fa77185debf8aa6f11271ff147d47
  CHECKSUM(SHA256) upstream package : 04cd2ac61cd3980f81eba5b197e152de0e8fa77185debf8aa6f11271ff147d47


Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1089017
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

Here are the changes:


Spec URL: http://sophiekovalevsky.fedorapeople.org/RPM/ahkab/ahkab.spec
SRPM URL: http://sophiekovalevsky.fedorapeople.org/RPM/ahkab/ahkab-0.09-3.fc20.src.rpm

Good!
Package approved.

New Package SCM Request
=======================
Package Name: ahkab
Short Description: A SPICE-like electronic circuit simulator written in Python.
Owners: sophiekovalevsky
Branches: f19 f20
InitialCC:

Sophie, you need to set fedora-cvs flag with ? status.

Thanks Antonio.
I thought I was selected the right option.
Done.
(In reply to Antonio Trande from comment #11)
> Sophie, you need to set fedora-cvs flag with ? status.

(In reply to Sophie Kovalevsky from comment #12)
> Thanks Antonio.
> I thought I was selected the right option.

No problem! ;)

Git done (by process-git-requests).

ahkab-0.09-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/ahkab-0.09-3.fc19

ahkab-0.09-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/ahkab-0.09-3.fc20

ahkab-0.09-3.fc19 has been pushed to the Fedora 19 testing repository.

ahkab-0.09-3.fc19 has been pushed to the Fedora 19 stable repository.

ahkab-0.09-3.fc20 has been pushed to the Fedora 20 stable repository.